Skip to content

Commit 5cbc268

Browse files
Apply suggestions from code review
Co-authored-by: Ivan Dlugos <6349682+vaind@users.noreply.github.com>
1 parent 283729d commit 5cbc268

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

danger/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@ jobs:
3737

3838
* `extra-install-packages`: Additional packages that are required by the extra-dangerfile, you can find a list of packages here: https://packages.debian.org/search?suite=bookworm&keywords=curl.
3939
* type: string
40-
required: false
41-
default: ""
40+
* required: false
41+
* default: ""
4242

4343
## Outputs
4444

danger/action.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,9 +80,8 @@ runs:
8080
env:
8181
EXTRA_INSTALL_PACKAGES: ${{ inputs.extra-install-packages }}
8282
run: |
83-
docker exec --user root danger apt-get update
8483
echo "Installing packages: $EXTRA_INSTALL_PACKAGES"
85-
docker exec --user root danger sh -c "set -e && apt-get install -y --no-install-recommends $EXTRA_INSTALL_PACKAGES"
84+
docker exec --user root danger sh -c "set -e && apt-get update && apt-get install -y --no-install-recommends $EXTRA_INSTALL_PACKAGES"
8685
echo "All additional packages installed successfully."
8786
8887
- name: Run DangerJS

danger/dangerfile.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ async function checkActionsArePinned() {
186186
}
187187
}
188188

189-
async function CheckFromExternalChecks() {
189+
async function checkFromExternalChecks() {
190190
// Get the external dangerfile path from environment variable (passed via workflow input)
191191
// Priority: EXTRA_DANGERFILE (absolute path) -> EXTRA_DANGERFILE_INPUT (relative path)
192192
const extraDangerFilePath = process.env.EXTRA_DANGERFILE || process.env.EXTRA_DANGERFILE_INPUT;
@@ -227,7 +227,7 @@ async function checkAll() {
227227
await checkDocs();
228228
await checkChangelog();
229229
await checkActionsArePinned();
230-
await CheckFromExternalChecks();
230+
await checkFromExternalChecks();
231231
}
232232

233233
schedule(checkAll);

0 commit comments

Comments
 (0)