TST: linalg.lapack.sy_hetrs: consolidate tests

Author: mdhaber

scipy/linalg/flapack_sym_herm.pyf.src

@@ -317,7 +317,7 @@ end subroutine <prefix2c>heevd_lwork
      integer intent(hide), depend(b) :: nrhs = shape(b, 1)
      integer intent(hide), depend(a) :: lda = MAX(1, shape(a, 0))
      integer intent(hide), depend(b,n),check(ldb >= n) :: ldb = MAX(1, shape(b, 0))
-     integer intent(out):: info
+     integer intent(out) :: info
 
    end subroutine <prefix>sytrs
 
@@ -337,7 +337,7 @@ end subroutine <prefix2c>heevd_lwork
      integer intent(hide), depend(b) :: nrhs = shape(b, 1)
      integer intent(hide), depend(a) :: lda = MAX(1, shape(a, 0))
      integer intent(hide), depend(b,n),check(ldb >= n) :: ldb = MAX(1, shape(b, 0))
-     integer intent(out):: info
+     integer intent(out) :: info
 
    end subroutine <prefix2c>hetrs
 

scipy/linalg/tests/test_lapack.py

@@ -3415,43 +3415,27 @@ def test_tgsyl(dtype, trans, ijob):
                         err_msg='lhs2 and rhs2 do not match')
 
 
+@pytest.mark.parametrize('mtype', ['sy', 'he'])  # matrix type
 @pytest.mark.parametrize('dtype', DTYPES)
 @pytest.mark.parametrize('lower', (0, 1))
-def test_sytrs(dtype, lower):
+def test_sy_hetrs(mtype, dtype, lower):
+    if mtype == 'he' and dtype in REAL_DTYPES:
+        pytest.skip("hetrs not for real dtypes.")
     rng = np.random.default_rng(1723059677121834)
     n, nrhs = 20, 5
     if dtype in COMPLEX_DTYPES:
         A = (rng.uniform(size=(n, n)) + rng.uniform(size=(n, n))*1j).astype(dtype)
     else:
         A = rng.uniform(size=(n, n)).astype(dtype)
 
-    A = A + A.T
+    A = A + A.T if mtype == 'sy' else A + A.conj().T
     b = rng.uniform(size=(n, nrhs)).astype(dtype)
-    sytrf, sytrf_lwork, sytrs = get_lapack_funcs(['sytrf', 'sytrf_lwork', 'sytrs'],
-                                                 dtype=dtype)
-    lwork = sytrf_lwork(n, lower=lower)
-    ldu, ipiv, info = sytrf(A, lwork=lwork)
+    names = f'{mtype}trf', f'{mtype}trf_lwork', f'{mtype}trs'
+    trf, trf_lwork, trs = get_lapack_funcs(names, dtype=dtype)
+    lwork = trf_lwork(n, lower=lower)
+    ldu, ipiv, info = trf(A, lwork=lwork)
     assert info == 0
-    x, info = sytrs(a=ldu, ipiv=ipiv, b=b)
+    x, info = trs(a=ldu, ipiv=ipiv, b=b)
     assert info == 0
     eps = np.finfo(dtype).eps
     assert_allclose(A@x, b, atol=100*n*eps)
-
-
-@pytest.mark.parametrize('dtype', COMPLEX_DTYPES)
-@pytest.mark.parametrize('lower', (0, 1))
-def test_hetrs(dtype, lower):
-    rng = np.random.default_rng(1723059677121834)
-    n, nrhs = 20, 5
-    A = (rng.uniform(size=(n, n)) + rng.uniform(size=(n, n))*1j).astype(dtype)
-    A = A + A.conj().T
-    b = np.random.rand(n, nrhs).astype(dtype)
-    hetrf, hetrf_lwork, hetrs = get_lapack_funcs(['hetrf', 'hetrf_lwork', 'hetrs'],
-                                                 dtype=dtype)
-    lwork = hetrf_lwork(n, lower=lower)
-    ldu, ipiv, info = hetrf(A, lwork=lwork)
-    assert info == 0
-    x, info = hetrs(a=ldu, ipiv=ipiv, b=b)
-    assert info == 0
-    eps = np.finfo(dtype).eps
-    assert_allclose(A @ x, b, atol=100*n*eps)