Skip to content

Commit 576db92

Browse files
committed
TST: linalg/solve: reenable and fix the "pos def" solve test
Make sure that the input matrix is actually positive definite.
1 parent fc8d4e7 commit 576db92

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

scipy/linalg/tests/test_basic.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -914,9 +914,9 @@ def test_empty_rhs(self):
914914
assert_(x.shape == (2, 0), 'Returned empty array shape is wrong')
915915

916916
@pytest.mark.parametrize('dtype', [np.float64, np.complex128])
917-
# "pos" and "positive definite" need to be added
918917
@pytest.mark.parametrize('assume_a', ['diagonal', 'tridiagonal', 'banded',
919918
'lower triangular', 'upper triangular',
919+
'pos', 'positive definite',
920920
'symmetric', 'hermitian', 'banded',
921921
'general', 'sym', 'her', 'gen'])
922922
@pytest.mark.parametrize('nrhs', [(), (5,)])
@@ -951,8 +951,7 @@ def test_structure_detection(self, dtype, assume_a, nrhs, transposed,
951951
elif assume_a in {'hermitian', 'her'}:
952952
A = A + A.conj().T
953953
elif assume_a in {'positive definite', 'pos'}:
954-
A = A + A.T
955-
A += np.diag(A.sum(axis=1))
954+
A = A @ A.T.conj()
956955

957956
if fortran:
958957
A = np.asfortranarray(A)

0 commit comments

Comments
 (0)