Skip to content

Commit 5ecf486

Browse files
committed
TST: temp skip of extending tests
* Temporarily skip the tests flagged in scipygh-22039 on free-threaded Windows CPython. Note that free-threading itself may be a red herring here, and the issue may ultimately be some combination of the disabling of build isolation for free-threaded wheels compounded with the Windows platform. * Note that the error messages reported by these test meson builds are identical to those reported by in-place builds of SciPy, for which we already have skips on these tests. Even for the case of the in-place build test failure, which simplifies down to a single-line reproducer, `cimport scipy.linalg`, we still don't have a work around, so it seems like we may not want to hold up the release candidate for an even more challenging-to-reproduce scenario that has the same error message. Also, if there were fundamental issues with free threading on this platform/Python combination, they would presumably show up somewhere other than just these in-place-sensitive tests. [skip circle] [skip cirrus]
1 parent a803070 commit 5ecf486

File tree

3 files changed

+12
-0
lines changed

3 files changed

+12
-0
lines changed

scipy/linalg/tests/test_extending.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import os
22
import platform
3+
import sysconfig
34

45
import numpy as np
56
import pytest
@@ -13,6 +14,9 @@
1314
# essential per https://github.com/scipy/scipy/pull/20487#discussion_r1567057247
1415
@pytest.mark.skipif(IS_EDITABLE,
1516
reason='Editable install cannot find .pxd headers.')
17+
@pytest.mark.skipif((platform.system() == 'Windows' and
18+
sysconfig.get_config_var('Py_GIL_DISABLED')),
19+
reason='gh-22039')
1620
@pytest.mark.skipif(platform.machine() in ["wasm32", "wasm64"],
1721
reason="Can't start subprocess")
1822
@pytest.mark.skipif(cython is None, reason="requires cython")

scipy/optimize/tests/test_extending.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import os
22
import platform
3+
import sysconfig
34

45
import pytest
56

@@ -10,6 +11,9 @@
1011
# essential per https://github.com/scipy/scipy/pull/20487#discussion_r1567057247
1112
@pytest.mark.skipif(IS_EDITABLE,
1213
reason='Editable install cannot find .pxd headers.')
14+
@pytest.mark.skipif((platform.system() == 'Windows' and
15+
sysconfig.get_config_var('Py_GIL_DISABLED')),
16+
reason='gh-22039')
1317
@pytest.mark.skipif(platform.machine() in ["wasm32", "wasm64"],
1418
reason="Can't start subprocess")
1519
@pytest.mark.skipif(cython is None, reason="requires cython")

scipy/special/tests/test_extending.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import os
22
import platform
3+
import sysconfig
34

45
import pytest
56

@@ -11,6 +12,9 @@
1112
# essential per https://github.com/scipy/scipy/pull/20487#discussion_r1567057247
1213
@pytest.mark.skipif(IS_EDITABLE,
1314
reason='Editable install cannot find .pxd headers.')
15+
@pytest.mark.skipif((platform.system() == 'Windows' and
16+
sysconfig.get_config_var('Py_GIL_DISABLED')),
17+
reason='gh-22039')
1418
@pytest.mark.skipif(platform.machine() in ["wasm32", "wasm64"],
1519
reason="Can't start subprocess")
1620
@pytest.mark.skipif(cython is None, reason="requires cython")

0 commit comments

Comments
 (0)