Skip to content

Commit a4227c0

Browse files
committed
BLD: fix a missing build dependency for cython_special, and add a CI check
This was technically a race condition (no one seems to have hit it yet though). From the added CI step: ``` Run ninja -C build -t missingdeps Missing dep: scipy/special/cython_special.cpython-310-x86_64-linux-gnu.so.p/meson-generated_cython_special.c.o uses scipy/special/_ufuncs_defs.h (generated by CUSTOM_COMMAND) Processed 1310 nodes. Error: There are 1 missing dependency paths. 1 targets had depfile dependencies on 1 distinct generated inputs (from 1 rules) without a non-depfile dep path to the generator. There might be build flakiness if any of the targets listed above are built alone, or not late enough, in a clean output directory. ``` [skip cirrus] [skip circle]
1 parent 64a49b0 commit a4227c0

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

.github/workflows/linux.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,9 @@ jobs:
124124
python dev.py build --tags=runtime,python-runtime,devel,tests
125125
python tools/check_installation.py ${{ env.INSTALLDIR }}
126126
127+
- name: Check build-internal dependencies
128+
run: ninja -C build -t missingdeps
129+
127130
- name: Mypy
128131
if: matrix.python-version == '3.10'
129132
run: |

scipy/special/meson.build

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -133,12 +133,12 @@ cython_special_pxd = fs.copyfile('cython_special.pxd')
133133
uf_cython_gen = generator(cython,
134134
arguments : cython_args,
135135
output : '@[email protected]',
136-
depends : [_cython_tree, _ufuncs_pxi_pxd_sources, cython_special_pxd])
136+
depends : [_cython_tree, _ufuncs_pxi_pxd_sources, cython_special_pxd, cython_special[0]])
137137

138138
uf_cython_gen_cpp = generator(cython,
139139
arguments : cython_cplus_args,
140140
output : '@[email protected]',
141-
depends : [_cython_tree, _ufuncs_pxi_pxd_sources, cython_special_pxd])
141+
depends : [_cython_tree, _ufuncs_pxi_pxd_sources, cython_special_pxd, cython_special[0]])
142142

143143
py3.extension_module('_ufuncs',
144144
[

0 commit comments

Comments
 (0)