test fixes (#21)

Author: lithomas1

scipy/_lib/tests/test__util.py

@@ -1,3 +1,4 @@
+from contextlib import nullcontext
 from multiprocessing import Pool
 from multiprocessing.pool import Pool as PWL
 import re
@@ -12,8 +13,8 @@
 from hypothesis import given, strategies, reproduce_failure  # noqa: F401
 from scipy.conftest import skip_xp_invalid_arg
 
-from scipy._lib._array_api import (xp_assert_equal, xp_assert_close, is_numpy,
-                                   is_array_api_strict)
+from scipy._lib._array_api import (xp_assert_equal, xp_assert_close, is_jax,
+                                   is_numpy, is_array_api_strict)
 from scipy._lib._lazy_testing import lazy_xp_function
 from scipy._lib._util import (_aligned_zeros, check_random_state, MapWrapper,
                               getfullargspec_no_self, FullArgSpec,
@@ -385,19 +386,24 @@ def test_array_api_lazy(self, xp):
         # Lazy arrays don't support "omit" and "raise" policies
         # TODO test that we're emitting a user-friendly error message.
         #      Blocked by https://github.com/data-apis/array-api-compat/pull/228
-        with pytest.raises(TypeError):
+
+        # note: dask doesn't raise here since there are no nans in x
+        error_ctx = pytest.raises(TypeError) if is_jax(xp) else nullcontext()
+        with error_ctx:
             _contains_nan(x, "omit")
-        with pytest.raises(TypeError):
+        with error_ctx:
             _contains_nan(x, "raise")
 
         x = xpx.at(x)[1, 2, 1].set(np.nan)
 
         xp_assert_equal(_contains_nan(x), xp.asarray(True))
         xp_assert_equal(_contains_nan(x, "propagate"), xp.asarray(True))
         xp_assert_equal(_contains_nan(x, "omit", xp_omit_okay=True), xp.asarray(True))
-        with pytest.raises(TypeError):
+        # dask raises ValueError (from in the scipy code)
+        # jax raises a tracingerror (subclass of typeerror)
+        with pytest.raises((TypeError, ValueError)):
             _contains_nan(x, "omit")
-        with pytest.raises(TypeError):
+        with pytest.raises((TypeError, ValueError)):
             _contains_nan(x, "raise")
 
 

scipy/conftest.py

@@ -398,7 +398,7 @@ def skip_or_xfail_xp_backends(request: pytest.FixtureRequest,
                 for d in xp.empty(0).devices():
                     if 'cpu' not in d.device_kind:
                         skip_or_xfail(reason=reason)
-            elif xp.__name__ == 'dask.array':
+            elif xp.__name__ == 'dask.array' and 'dask.array' not in exceptions:
                 if xp_device(xp.empty(0)) != 'cpu':
                     skip_or_xfail(reason=reason)
 

scipy/integrate/tests/test_cubature.py

@@ -973,7 +973,7 @@ def test_break_points(self, problem, rule, rtol, atol, xp):
     )
     @skip_xp_backends(
         "dask.array",
-        reasons=["transforms make use of boolean index assignment"],
+        reason="transforms make use of boolean index assignment"
     )
     @pytest.mark.parametrize("problem", [
         (
@@ -1127,7 +1127,7 @@ def test_infinite_limits(self, problem, rule, rtol, atol, xp):
     )
     @skip_xp_backends(
         "dask.array",
-        reasons=["transforms make use of boolean index assignment"],
+        reason="transforms make use of boolean index assignment"
     )
     @pytest.mark.parametrize("problem", [
         (
@@ -1338,7 +1338,7 @@ def test_genz_malik_1d_raises_error(self, xp):
 )
 @skip_xp_backends(
     "dask.array",
-    reasons=["transforms make use of boolean index assignment"],
+    reason="transforms make use of boolean index assignment"
 )
 class TestTransformations:
     @pytest.mark.parametrize(("a", "b", "points"), [

scipy/ndimage/tests/test_filters.py

@@ -2647,6 +2647,7 @@ def test_gaussian_radius_invalid(xp):
 
 
 @skip_xp_backends("jax.numpy", reason="output array is read-only")
+@skip_xp_backends("dask.array", reason="wrong answer")
 class TestThreading:
     def check_func_thread(self, n, fun, args, out):
         from threading import Thread

scipy/signal/tests/test_windows.py

@@ -9,8 +9,8 @@
 from scipy.fft import fft
 from scipy.signal import windows, get_window, resample
 from scipy._lib._array_api import (
-     xp_assert_close, xp_assert_equal, array_namespace, is_torch, is_jax, is_cupy,
-     assert_array_almost_equal, SCIPY_DEVICE,
+     xp_assert_close, xp_assert_equal, array_namespace, is_dask,
+     is_torch, is_jax, is_cupy, assert_array_almost_equal, SCIPY_DEVICE,
 )
 
 skip_xp_backends = pytest.mark.skip_xp_backends
@@ -256,6 +256,7 @@ def test_basic(self, xp):
 
 
 @skip_xp_backends('jax.numpy', reason='item assignment')
+@skip_xp_backends('dask.array', reason='data-dependent output shapes')
 class TestChebWin:
 
     def test_basic(self, xp):
@@ -778,6 +779,7 @@ def test_boxcar(self, xp):
         xp_assert_equal(w, xp.ones_like(w))
 
     @skip_xp_backends('jax.numpy', reason='item assignment')
+    @skip_xp_backends('dask.array', reason='data-dependent output shapes')
     def test_cheb_odd(self, xp):
         with suppress_warnings() as sup:
             sup.filter(UserWarning, "This window is not suitable")
@@ -787,6 +789,7 @@ def test_cheb_odd(self, xp):
         )
 
     @skip_xp_backends('jax.numpy', reason='item assignment')
+    @skip_xp_backends('dask.array', reason='data-dependent output shapes')
     def test_cheb_even(self, xp):
         with suppress_warnings() as sup:
             sup.filter(UserWarning, "This window is not suitable")
@@ -854,6 +857,11 @@ def test_windowfunc_basics(xp):
         window = getattr(windows, window_name)
         if is_jax(xp) and window_name in ['taylor', 'chebwin']:
             pytest.skip(reason=f'{window_name = }: item assignment')
+        if is_dask(xp):
+            # https://github.com/dask/dask/issues/2620
+            pytest.skip(
+                reason="dask doesn't support FFT along axis containing multiple chunks"
+            )
         if window_name in ['dpss']:
             if is_cupy(xp):
                 pytest.skip(reason='dpss window is not implemented for cupy')