refactor(SpawnManager): abstract hitable volume method

Author: lucasctnh

Assets/Scripts/Gameplay/Services/SpawnManager.cs

@@ -47,7 +47,7 @@ private void OnGetHitableFromPool(Hitable hitable) {
 
 	private void OnReleaseHitableToPool(Hitable hitable) {
 		hitable.isReleased = true;
-		hitable.transform.position = GenerateRandomPosition(hitable); // TODO: check if this is causing physics spike
+		hitable.transform.position = GenerateRandomPosition(hitable);
 		hitable.gameObject.SetActive(false);
 	}
 
@@ -57,13 +57,7 @@ private void SpawnHitable() {
 			Hitable hitable = pool.Get();
 			hitable.GetComponent<Hitable>().SetKill(hitable => Kill(pool, hitable));
 
-			AudioSource[] audioSources = hitable.GetComponents<AudioSource>(); // TODO: abstract
-			if (audioSources != null && audioSources.Length != 0) {
-				foreach (AudioSource audioSource in audioSources) {
-					float obstacleVolume = AudioManager.Instance.GetTrackVolume(2) == 0 ? 0 : AudioManager.Instance.GetTrackVolume(2) + .2f;
-					audioSource.volume = obstacleVolume;
-				}
-			}
+			SetHitableVolume(hitable);
 
 			if (!CheckShouldSpawn(hitable))
 				pool.Release(hitable);
@@ -72,6 +66,17 @@ private void SpawnHitable() {
 		_isSelectingPool = true;
 	}
 
+	private void SetHitableVolume(Hitable hitable) {
+		AudioSource[] audioSources = hitable.GetComponents<AudioSource>();
+
+		if (audioSources != null && audioSources.Length != 0) {
+			foreach (AudioSource audioSource in audioSources) {
+				float obstacleVolume = AudioManager.Instance.GetTrackVolume(2) == 0 ? 0 : AudioManager.Instance.GetTrackVolume(2) + .2f;
+				audioSource.volume = obstacleVolume;
+			}
+		}
+	}
+
 	private bool CheckShouldSpawn(Hitable hitable) {
 		if (hitable.SpawnRate <= 0f)
 			return false;