Skip to content

Commit 4a77bae

Browse files
authored
Merge pull request #427 from lucaslorentz/compare_network_names
Compare network name as well to support podman
2 parents 338fd6b + fd56058 commit 4a77bae

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

generator/generator.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -244,6 +244,7 @@ func (g *CaddyfileGenerator) getIngressNetworks(logger *zap.Logger) (map[string]
244244
for _, ingressNetwork := range g.options.IngressNetworks {
245245
if dockerNetwork.Name == ingressNetwork {
246246
ingressNetworks[dockerNetwork.ID] = true
247+
ingressNetworks[dockerNetwork.Name] = true
247248
}
248249
}
249250
}
@@ -266,7 +267,8 @@ func (g *CaddyfileGenerator) getIngressNetworks(logger *zap.Logger) (map[string]
266267
if networkInfo.Ingress {
267268
continue
268269
}
269-
ingressNetworks[network.NetworkID] = true
270+
ingressNetworks[networkInfo.ID] = true
271+
ingressNetworks[networkInfo.Name] = true
270272
}
271273
}
272274
}

generator/generator_test.go

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,12 @@ import (
2020

2121
var caddyContainerID = "container-id"
2222
var caddyNetworkID = "network-id"
23+
var caddyNetworkName = "network-name"
2324

2425
const newLine = "\n"
2526
const containerIdLog = `INFO Caddy ContainerID {"ID": "container-id"}` + newLine
26-
const ingressNetworksMapLog = `INFO IngressNetworksMap {"ingres": "map[network-id:true]"}` + newLine
27-
const otherIngressNetworksMapLog = `INFO IngressNetworksMap {"ingres": "map[other-network-id:true]"}` + newLine
27+
const ingressNetworksMapLog = `INFO IngressNetworksMap {"ingres": "map[network-id:true network-name:true]"}` + newLine
28+
const otherIngressNetworksMapLog = `INFO IngressNetworksMap {"ingres": "map[other-network-id:true other-network-name:true]"}` + newLine
2829
const swarmIsAvailableLog = `INFO Swarm is available {"new": true}` + newLine
2930
const swarmIsDisabledLog = `INFO Swarm is available {"new": false}` + newLine
3031
const commonLogs = containerIdLog + ingressNetworksMapLog + swarmIsAvailableLog
@@ -183,6 +184,8 @@ func createBasicDockerClientMock() *docker.ClientMock {
183184
NetworkInspectData: map[string]types.NetworkResource{
184185
caddyNetworkID: {
185186
Ingress: false,
187+
ID: caddyNetworkID,
188+
Name: caddyNetworkName,
186189
},
187190
},
188191
}

0 commit comments

Comments
 (0)