Skip to content

Commit e77e4c0

Browse files
committed
Use GetValueWithSeverity for CSLINT237 and CSLINT238
🤖 Co-Authored-By: Claude Code <noreply@anthropic.com>
1 parent 1bebfe6 commit e77e4c0

File tree

3 files changed

+18
-8
lines changed

3 files changed

+18
-8
lines changed

.editorconfig

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,8 +79,8 @@ csharp_style_prefer_utf8_string_literals = true:suggestion
7979
csharp_style_prefer_primary_constructors = true:suggestion
8080

8181
# ── Tier 3: style – code quality ──
82-
csharp_no_empty_finalizers = true
83-
csharp_no_unnecessary_initialization = true
82+
csharp_no_empty_finalizers = true:warning
83+
csharp_no_unnecessary_initialization = true:suggestion
8484

8585
# ── Tier 3: style – blank line rules ──
8686
csharp_style_allow_blank_lines_between_consecutive_braces = false:warning

src/CsLint.Core/Rules/Tier3/EmptyFinalizerRule.cs

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,11 @@ public sealed class EmptyFinalizerRule : IRuleDefinition, IStyleRuleHandler
1414

1515
public LintSeverity DefaultSeverity => LintSeverity.Warning;
1616

17-
public bool IsEnabled(LintConfiguration configuration) =>
18-
string.Equals(configuration.GetValue("csharp_no_empty_finalizers"), "true", StringComparison.OrdinalIgnoreCase);
17+
public bool IsEnabled(LintConfiguration configuration)
18+
{
19+
(string? pref, string? _) = configuration.GetValueWithSeverity("csharp_no_empty_finalizers");
20+
return string.Equals(pref, "true", StringComparison.OrdinalIgnoreCase);
21+
}
1922

2023
public IReadOnlyList<LintDiagnostic> Analyze(RuleContext context)
2124
{
@@ -29,7 +32,9 @@ void IStyleRuleHandler.VisitDestructorDeclaration(
2932
LintConfiguration config,
3033
List<LintDiagnostic> diagnostics)
3134
{
32-
if (!string.Equals(config.GetValue("csharp_no_empty_finalizers"), "true", StringComparison.OrdinalIgnoreCase))
35+
(string? pref, string? _) = config.GetValueWithSeverity("csharp_no_empty_finalizers");
36+
37+
if (!string.Equals(pref, "true", StringComparison.OrdinalIgnoreCase))
3338
{
3439
return;
3540
}

src/CsLint.Core/Rules/Tier3/UnnecessaryInitializationRule.cs

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,11 @@ public sealed class UnnecessaryInitializationRule : IRuleDefinition, IStyleRuleH
2828

2929
public LintSeverity DefaultSeverity => LintSeverity.Info;
3030

31-
public bool IsEnabled(LintConfiguration configuration) =>
32-
string.Equals(configuration.GetValue(ConfigKey), "true", StringComparison.OrdinalIgnoreCase);
31+
public bool IsEnabled(LintConfiguration configuration)
32+
{
33+
(string? pref, string? _) = configuration.GetValueWithSeverity(ConfigKey);
34+
return string.Equals(pref, "true", StringComparison.OrdinalIgnoreCase);
35+
}
3336

3437
public IReadOnlyList<LintDiagnostic> Analyze(RuleContext context)
3538
{
@@ -43,7 +46,9 @@ void IStyleRuleHandler.VisitFieldDeclaration(
4346
LintConfiguration config,
4447
List<LintDiagnostic> diagnostics)
4548
{
46-
if (!string.Equals(config.GetValue(ConfigKey), "true", StringComparison.OrdinalIgnoreCase))
49+
(string? pref, string? _) = config.GetValueWithSeverity(ConfigKey);
50+
51+
if (!string.Equals(pref, "true", StringComparison.OrdinalIgnoreCase))
4752
{
4853
return;
4954
}

0 commit comments

Comments
 (0)