feat: limit flag

Author: lucassabreu

pkg/cmd/time-entry/report/util/report.go

@@ -27,6 +27,7 @@ type ReportFlags struct {
 	util.OutputFlags
 
 	FillMissingDates bool
+	Limit            int
 
 	Billable    bool
 	NotBillable bool
@@ -43,6 +44,13 @@ func (rf ReportFlags) Check() error {
 		return err
 	}
 
+	if err := cmdutil.XorFlag(map[string]bool{
+		"limit":              rf.Limit > 0,
+		"fill-missing-dates": rf.FillMissingDates,
+	}); err != nil {
+		return err
+	}
+
 	return cmdutil.XorFlag(map[string]bool{
 		"billable":     rf.Billable,
 		"not-billable": rf.NotBillable,
@@ -52,6 +60,7 @@ func (rf ReportFlags) Check() error {
 // NewReportFlags helps creating a util.ReportFlags for report commands
 func NewReportFlags() ReportFlags {
 	return ReportFlags{
+		Limit: 0,
 		OutputFlags: util.OutputFlags{
 			TimeFormat: timehlp.FullTimeFormat,
 		},
@@ -65,8 +74,10 @@ func AddReportFlags(
 	util.AddPrintTimeEntriesFlags(cmd, &rf.OutputFlags)
 	util.AddPrintMultipleTimeEntriesFlags(cmd)
 
+	cmd.Flags().IntVarP(&rf.Limit, "limit", "L", 0,
+		"Only look for this quantity of time entries")
 	cmd.Flags().BoolVarP(&rf.FillMissingDates, "fill-missing-dates", "e", false,
-		"add empty lines for dates without time entries")
+		"Add empty lines for dates without time entries")
 	cmd.Flags().StringVarP(&rf.Description, "description", "d", "",
 		"will filter time entries that contains this on the description field")
 	cmd.Flags().StringSliceVarP(&rf.Projects, "project", "p", []string{},
@@ -157,6 +168,14 @@ func ReportWithRange(
 	wg := errgroup.Group{}
 	logs := make([][]dto.TimeEntry, len(rf.Projects))
 
+	pages := api.AllPages()
+	if rf.Limit > 0 {
+		pages = api.PaginationParam{
+			Page:     1,
+			PageSize: rf.Limit,
+		}
+	}
+
 	for i := range rf.Projects {
 		i := i
 		wg.Go(func() error {
@@ -169,7 +188,7 @@ func ReportWithRange(
 				Description:     rf.Description,
 				ProjectID:       rf.Projects[i],
 				TagIDs:          rf.TagIDs,
-				PaginationParam: api.AllPages(),
+				PaginationParam: pages,
 			})
 
 			return err
@@ -195,6 +214,10 @@ func ReportWithRange(
 		)
 	})
 
+	if rf.Limit > 0 && len(log) > rf.Limit {
+		log = log[0:rf.Limit]
+	}
+
 	if rf.FillMissingDates && len(log) > 0 {
 		l := log
 		log = make([]dto.TimeEntry, 0, len(l))

pkg/cmd/time-entry/report/util/report_flag_test.go

@@ -7,42 +7,80 @@ import (
 	"github.com/stretchr/testify/assert"
 )
 
-func TestReportBillableFlagsChecks(t *testing.T) {
-	rf := util.NewReportFlags()
-	rf.Billable = true
-	rf.NotBillable = true
-
-	err := rf.Check()
-	if assert.Error(t, err) {
-		assert.Regexp(t,
-			"can't be used together.*billable.*not-billable", err.Error())
-	}
-
-	rf.Billable = false
-	rf.NotBillable = true
-
-	assert.NoError(t, rf.Check())
+func TestReportFlags_Check(t *testing.T) {
+	tts := map[string]struct {
+		rf  util.ReportFlags
+		err string
+	}{
+		"just billable": {
 
-	rf.Billable = true
-	rf.NotBillable = false
-
-	assert.NoError(t, rf.Check())
-}
-
-func TestReportProjectFlagsChecks(t *testing.T) {
-	rf := util.NewReportFlags()
-	rf.Client = "me"
-	rf.Projects = []string{}
-
-	assert.NoError(t, rf.Check())
+			rf: util.ReportFlags{
+				Billable:    true,
+				NotBillable: false,
+			},
+		},
+		"just not-billable": {
+			rf: util.ReportFlags{
+				Billable:    false,
+				NotBillable: true,
+			},
+		},
+		"only one billable": {
+			rf: util.ReportFlags{
+				Billable:    true,
+				NotBillable: true,
+			},
+			err: "can't be used together.*billable.*not-billable",
+		},
+		"just client": {
+			rf: util.ReportFlags{
+				Client: "me",
+			},
+		},
+		"just projects": {
+			rf: util.ReportFlags{
+				Projects: []string{"mine"},
+			},
+		},
+		"client and project": {
+			rf: util.ReportFlags{
+				Client:   "me",
+				Projects: []string{"mine"},
+			},
+		},
+		"fill missing dates": {
+			rf: util.ReportFlags{
+				FillMissingDates: true,
+			},
+		},
+		"limit": {
+			rf: util.ReportFlags{
+				Limit: 10,
+			},
+		},
+		"only limit or fill missing": {
+			rf: util.ReportFlags{
+				Limit:            10,
+				FillMissingDates: true,
+			},
+			err: "can't be used together.*fill-missing-dates.*limit",
+		},
+	}
 
-	rf.Client = ""
-	rf.Projects = []string{"mine"}
+	for name, tt := range tts {
+		t.Run(name, func(t *testing.T) {
+			err := tt.rf.Check()
 
-	assert.NoError(t, rf.Check())
+			if tt.err == "" {
+				assert.NoError(t, err)
+				return
+			}
 
-	rf.Client = "me"
-	rf.Projects = []string{"mine"}
+			if !assert.Error(t, err) {
+				return
+			}
 
-	assert.NoError(t, rf.Check())
+			assert.Regexp(t, tt.err, err.Error())
+		})
+	}
 }