(fix): interactive clone flow and --no-closing

Author: lucassabreu

CHANGELOG.md

@@ -6,6 +6,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [v0.3.1] - 2020-04-01
+
+## Fixed
+
+- fixed `--no-closing` being ignored
+- interactive flow of `clone` was keeping previous time interval
+
 ## [v0.3.0] - 2020-04-01
 
 ## Fixed

cmd/common.go

@@ -138,12 +138,19 @@ func newEntry(c *api.Client, te dto.TimeEntryImpl, interactive, autoClose bool)
 		}
 
 		var date *time.Time
-		if date, err = getDateTimeParam("Start", true, whenString, convertToTime); err != nil {
+		dateString := te.TimeInterval.Start.Format(fullTimeFormat)
+
+		if date, err = getDateTimeParam("Start", true, dateString, convertToTime); err != nil {
 			return te, err
 		}
 		te.TimeInterval.Start = *date
 
-		if date, err = getDateTimeParam("End", false, whenToCloseString, convertToTime); err != nil {
+		dateString = ""
+		if te.TimeInterval.End != nil {
+			dateString = te.TimeInterval.End.Format(fullTimeFormat)
+		}
+
+		if date, err = getDateTimeParam("End", false, dateString, convertToTime); err != nil {
 			return te, err
 		}
 		te.TimeInterval.End = date

cmd/in.go

@@ -122,7 +122,9 @@ func init() {
 
 	inCmd.Flags().StringP("format", "f", "", "golang text/template format to be applyed on each time entry")
 	inCmd.Flags().BoolP("json", "j", false, "print as json")
-	inCmd.Flags().BoolVar(&noClosing, "no-closing", false, "don't close any active time entry")
+	inCmd.PersistentFlags().BoolVar(&noClosing, "no-closing", false, "don't close any active time entry")
+
+	_ = viper.BindPFlag("no-closing", inCmd.PersistentFlags().Lookup("no-closing"))
 }
 
 func addTimeEntryFlags(cmd *cobra.Command) {

cmd/inClone.go

@@ -42,6 +42,7 @@ var inCloneCmd = &cobra.Command{
 			viper.GetString("user.id"),
 			c,
 		)
+		tec.TimeInterval.End = nil
 
 		if err != nil {
 			printError(err)
@@ -129,7 +130,6 @@ func init() {
 	rootCmd.AddCommand(inCloneCmd)
 	inCmd.AddCommand(inCloneCmd)
 
-	inCloneCmd.Flags().Bool("no-closing", false, "don't close any time entry")
 	inCloneCmd.Flags().String("when", "", "when the entry should be closed, if not informed will use current time")
 
 	inCloneCmd.Flags().StringP("format", "f", "", "golang text/template format to be applied on each time entry")