LDEV-6043 fix DecimalFormat bug

Author: zspitzer

core/src/main/java/lucee/runtime/op/Caster.java

@@ -1008,7 +1008,7 @@ public static String toDecimal(double value, boolean separator) {
 
 	private static String toDecimal(double value, char decDel, char thsDel) {
 		// TODO Caster toDecimal bessere impl.
-		String str = Caster.toBigDecimal((StrictMath.round(value * 100) / 100D)).toString();
+		String str = Caster.toBigDecimal((StrictMath.round(value * 100) / 100D)).toPlainString();
 		// str=toDouble(value).toString();
 		String[] arr = str.split("\\.");
 

loader/build.xml

@@ -2,7 +2,7 @@
 <project default="core" basedir="." name="Lucee" 
   xmlns:resolver="antlib:org.apache.maven.resolver.ant">
 
-  <property name="version" value="6.2.5.15-SNAPSHOT"/>
+  <property name="version" value="6.2.5.16-SNAPSHOT"/>
 
   <taskdef uri="antlib:org.apache.maven.resolver.ant" resource="org/apache/maven/resolver/ant/antlib.xml">
     <classpath>

loader/pom.xml

@@ -3,7 +3,7 @@
 
   <groupId>org.lucee</groupId>
   <artifactId>lucee</artifactId>
-  <version>6.2.5.15-SNAPSHOT</version>
+  <version>6.2.5.16-SNAPSHOT</version>
   <packaging>jar</packaging>
 
   <name>Lucee Loader Build</name>

test/tickets/LDEV6043.cfc

@@ -0,0 +1,53 @@
+component extends="org.lucee.cfml.test.LuceeTestCase" {
+
+	function beforeAll() {
+		variables.preciseMath = getApplicationSettings().preciseMath;
+	}
+
+	function afterAll() {
+		application action="update" preciseMath=variables.preciseMath;
+	}
+
+	function run( testResults, testBox ) {
+		describe( title="test case for LDEV-6043", body=function() {
+
+			afterEach( function() {
+				application action="update" preciseMath=variables.preciseMath;
+			});
+
+			it( "DecimalFormat with large numbers should not use scientific notation", function() {
+				expect( DecimalFormat( 10000000 ) ).toBe( "10,000,000.00" );
+				expect( DecimalFormat( 20000000 ) ).toBe( "20,000,000.00" );
+				expect( DecimalFormat( 100000000 ) ).toBe( "100,000,000.00" );
+				expect( DecimalFormat( 1000000000 ) ).toBe( "1,000,000,000.00" );
+			});
+
+			it( "DecimalFormat with negative large numbers", function() {
+				expect( DecimalFormat( -10000000 ) ).toBe( "-10,000,000.00" );
+				expect( DecimalFormat( -20000000 ) ).toBe( "-20,000,000.00" );
+			});
+
+			it( "DecimalFormat boundary values around scientific notation threshold", function() {
+				expect( DecimalFormat( 9999999 ) ).toBe( "9,999,999.00" );
+				expect( DecimalFormat( 19999999 ) ).toBe( "19,999,999.00" );
+				expect( DecimalFormat( 20000001 ) ).toBe( "20,000,001.00" );
+			});
+
+			it( "DecimalFormat with large numbers and preciseMath=true", function() {
+				application action="update" preciseMath=true;
+				expect( DecimalFormat( 10000000 ) ).toBe( "10,000,000.00" );
+				expect( DecimalFormat( 20000000 ) ).toBe( "20,000,000.00" );
+				expect( DecimalFormat( 100000000 ) ).toBe( "100,000,000.00" );
+			});
+
+			it( "DecimalFormat with large numbers and preciseMath=false", function() {
+				application action="update" preciseMath=false;
+				expect( DecimalFormat( 10000000 ) ).toBe( "10,000,000.00" );
+				expect( DecimalFormat( 20000000 ) ).toBe( "20,000,000.00" );
+				expect( DecimalFormat( 100000000 ) ).toBe( "100,000,000.00" );
+			});
+
+		});
+	}
+
+}