centralize built properties into a single file

Author: zspitzer

.github/workflows/main.yml

@@ -63,7 +63,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        lucee: ${{ fromJSON(inputs.luceeVersions || vars.LUCEE_TEST_VERSIONS || '["6.2/stable/light", "7.0/snapshot/light"]') }}
+        lucee: ${{ fromJSON(inputs.luceeVersions || '["6.2/stable/light", "7.0/stable/light"]') }}
     steps:
       - uses: actions/checkout@v4
 

build.properties

@@ -0,0 +1,12 @@
+bundlename: crypto.extension
+filename: crypto-extension
+bundleversion: 1.0.0.0
+extensionId: 17AB52DE-B300-A94B-E058FC978BE4542D
+luceeCoreVersion: 6.0.0.585
+releaseType: server
+appendix: -SNAPSHOT
+label: Crypto Extension
+description: BouncyCastle-based cryptographic functions
+mvnGroupId: org.lucee
+mvnGroupPath: org/lucee
+mvnArtifactId: extension-crypto

build.xml

@@ -4,18 +4,14 @@
 		Build Crypto Extension
 	</description>
 
-	<!-- Default properties for local builds (can be overridden via -D or parent pom) -->
-	<property name="bundleversion" value="1.0.0.0-SNAPSHOT"/>
+	<!-- Load properties from build.properties (can be overridden via -D or parent pom) -->
+	<property file="build.properties"/>
+
+	<!-- Computed version from bundleversion + appendix -->
+	<property name="bundleversion" value="${bundleversion}${appendix}"/>
+
+	<!-- Build defaults -->
 	<property name="maven.goal" value="package"/>
-	<property name="mvnGroupId" value="org.lucee"/>
-	<property name="mvnGroupPath" value="org/lucee"/>
-	<property name="mvnArtifactId" value="extension-crypto"/>
-	<property name="filename" value="crypto-extension"/>
-	<property name="id" value="17AB52DE-B300-A94B-E058FC978BE4542D"/>
-	<property name="label" value="Crypto Extension"/>
-	<property name="description" value="BouncyCastle-based cryptographic functions"/>
-	<property name="releaseType" value="server"/>
-	<property name="luceeCoreVersion" value="6.0.0.585"/>
 	<property name="maven.username" value=""/>
 	<property name="maven.password" value=""/>
 	<property name="gpg.passphrase" value=""/>
@@ -138,7 +134,7 @@
 		<echo file="${dist}/extension/META-INF/MANIFEST.MF">Manifest-Version: 1.0
 Built-Date: ${NOW}
 version: "${bundleversion}"
-id: "${id}"
+id: "${extensionId}"
 name: "${label}"
 description: "${description}"
 start-bundles: true

pom.xml

@@ -12,15 +12,7 @@
 		<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
 		<maven.compiler.source>11</maven.compiler.source>
 		<maven.compiler.target>11</maven.compiler.target>
-		<id>17AB52DE-B300-A94B-E058FC978BE4542D</id>
-		<bundlename>crypto.extension</bundlename>
-		<mvnGroupId>org.lucee</mvnGroupId>
-		<mvnGroupPath>org/lucee</mvnGroupPath>
-		<mvnArtifactId>extension-crypto</mvnArtifactId>
-		<filename>crypto-extension</filename>
-		<luceeCoreVersion>6.0.0.585</luceeCoreVersion>
-		<releaseType>server</releaseType>
-		<label>Crypto Extension</label>
+		<!-- Extension properties loaded from build.properties via properties-maven-plugin -->
 		<release.url>https://oss.sonatype.org/service/local/staging/deploy/maven2/</release.url>
 		<snapshot.url>https://oss.sonatype.org/content/repositories/snapshots/</snapshot.url>
 	</properties>
@@ -118,6 +110,26 @@
 
 	<build>
 		<plugins>
+			<!-- Load properties from build.properties -->
+			<plugin>
+				<groupId>org.codehaus.mojo</groupId>
+				<artifactId>properties-maven-plugin</artifactId>
+				<version>1.2.1</version>
+				<executions>
+					<execution>
+						<phase>initialize</phase>
+						<goals>
+							<goal>read-project-properties</goal>
+						</goals>
+						<configuration>
+							<files>
+								<file>${basedir}/build.properties</file>
+							</files>
+						</configuration>
+					</execution>
+				</executions>
+			</plugin>
+
 			<!-- Antrun plugin to execute the Ant build -->
 			<plugin>
 				<groupId>org.apache.maven.plugins</groupId>
@@ -135,7 +147,7 @@
 									<property name="bundleversion" value="${project.version}"/>
 									<property name="bundlename" value="${bundlename}"/>
 									<property name="filename" value="${project.artifactId}"/>
-									<property name="id" value="${id}"/>
+									<property name="extensionId" value="${extensionId}"/>
 									<property name="luceeCoreVersion" value="${luceeCoreVersion}"/>
 									<property name="releaseType" value="${releaseType}"/>
 									<property name="label" value="${label}"/>