LDEV-1402 rename logSystemOutput to consoleOutput

Author: zspitzer

luceedebug/src/main/java/luceedebug/DapServer.java

@@ -523,8 +523,8 @@ private void configureLogging(Map<String, Object> args) {
         // logExceptions - default false
         Log.setLogExceptions(caster.toBooleanValue(args.get("logExceptions"), false));
 
-        // logSystemOutput - default false
-        NativeDebuggerListener.setLogSystemOutput(caster.toBooleanValue(args.get("logSystemOutput"), false));
+        // consoleOutput - default false (streams System.out/err to debug console)
+        NativeDebuggerListener.setConsoleOutput(caster.toBooleanValue(args.get("consoleOutput"), false));
     }
 
     static final Pattern threadNamePrefixAndDigitSuffix = Pattern.compile("^(.+?)(\\d+)$");

luceedebug/src/main/java/luceedebug/Log.java

@@ -29,7 +29,7 @@ public class Log {
 	private static volatile boolean colorLogs = true;
 	private static volatile LogLevel logLevel = LogLevel.INFO;
 	private static volatile boolean logExceptions = false;
-	private static volatile boolean logSystemOutput = false;
+	private static volatile boolean consoleOutput = false;
 
 	// Internal debugging - only enabled via env var LUCEE_DEBUGGER_DEBUG
 	private static final boolean internalDebug;
@@ -85,12 +85,12 @@ public static void setLogExceptions(boolean enabled) {
 	}
 
 	/**
-	 * Set system output logging from launch.json.
+	 * Set console output streaming from launch.json.
 	 * When enabled, we skip sending directly to DAP since System.out/err
 	 * will be captured and forwarded via systemOutput().
 	 */
-	public static void setLogSystemOutput(boolean enabled) {
-		logSystemOutput = enabled;
+	public static void setConsoleOutput(boolean enabled) {
+		consoleOutput = enabled;
 	}
 
 	/**
@@ -101,9 +101,9 @@ public static void info(String message) {
 		if (!LogLevel.INFO.isEnabled(logLevel)) {
 			return;
 		}
-		// When logSystemOutput is enabled, skip System.out (it gets captured and
+		// When consoleOutput is enabled, skip System.out (it gets captured and
 		// forwarded to DAP, causing double-logging). Send directly to DAP instead.
-		if (!logSystemOutput) {
+		if (!consoleOutput) {
 			String consoleMsg;
 			if (colorLogs) {
 				consoleMsg = ANSI_CYAN + PREFIX + ANSI_RESET + message;
@@ -119,7 +119,7 @@ public static void info(String message) {
 	 * Log an error message. Always logged regardless of log level.
 	 */
 	public static void error(String message) {
-		if (!logSystemOutput) {
+		if (!consoleOutput) {
 			String consoleMsg;
 			if (colorLogs) {
 				consoleMsg = ANSI_RED + PREFIX + "ERROR: " + message + ANSI_RESET;
@@ -148,7 +148,7 @@ public static void debug(String message) {
 		if (!internalDebug) {
 			return;
 		}
-		if (!logSystemOutput) {
+		if (!consoleOutput) {
 			String consoleMsg;
 			if (colorLogs) {
 				consoleMsg = ANSI_DIM + PREFIX + "DEBUG: " + message + ANSI_RESET;
@@ -169,7 +169,7 @@ public static void trace(String message) {
 		if (!internalDebug) {
 			return;
 		}
-		if (!logSystemOutput) {
+		if (!consoleOutput) {
 			String consoleMsg;
 			if (colorLogs) {
 				consoleMsg = ANSI_DIM + PREFIX + "TRACE: " + message + ANSI_RESET;
@@ -190,7 +190,7 @@ public static void warn(String message) {
 		if (!LogLevel.INFO.isEnabled(logLevel)) {
 			return;
 		}
-		if (!logSystemOutput) {
+		if (!consoleOutput) {
 			String consoleMsg;
 			if (colorLogs) {
 				consoleMsg = ANSI_YELLOW + PREFIX + "WARN: " + message + ANSI_RESET;
@@ -229,7 +229,7 @@ public static void exception(Throwable t) {
 
 	/**
 	 * Forward System.out/err output to DAP client.
-	 * Called by NativeDebuggerListener.onOutput() when logSystemOutput is enabled.
+	 * Called by NativeDebuggerListener.onOutput() when consoleOutput is enabled.
 	 * Does NOT echo to console (would cause infinite loop).
 	 *
 	 * @param text The text that was written

luceedebug/src/main/java/luceedebug/coreinject/NativeDebuggerListener.java

@@ -167,9 +167,9 @@ private static class CachedExecutableLines {
 
 	/**
 	 * Flag to forward System.out/err to DAP client.
-	 * Set via launch.json logSystemOutput option.
+	 * Set via launch.json consoleOutput option.
 	 */
-	private static volatile boolean logSystemOutput = false;
+	private static volatile boolean consoleOutput = false;
 
 	/**
 	 * Fast-path flag: true when there's anything that could cause a suspend.
@@ -733,7 +733,7 @@ private static void onClientDisconnect() {
 
 		// Reset exception settings
 		breakOnUncaughtExceptions = false;
-		logSystemOutput = false;
+		consoleOutput = false;
 
 		// Note: We intentionally keep breakpoints - they'll be inactive
 		// since dapClientConnected=false, and will be replaced on next connect
@@ -762,20 +762,20 @@ public static boolean shouldBreakOnUncaughtExceptions() {
 	 * Set whether to forward System.out/err to DAP client.
 	 * Called from DapServer when handling attach request.
 	 */
-	public static void setLogSystemOutput(boolean enabled) {
-		logSystemOutput = enabled;
-		Log.setLogSystemOutput(enabled);
+	public static void setConsoleOutput(boolean enabled) {
+		consoleOutput = enabled;
+		Log.setConsoleOutput(enabled);
 	}
 
 	/**
 	 * Called by Lucee's DebuggerPrintStream when output is written to System.out/err.
-	 * Forwards to DAP client if logSystemOutput is enabled.
+	 * Forwards to DAP client if consoleOutput is enabled.
 	 *
 	 * @param text The text that was written
 	 * @param isStdErr true if stderr, false if stdout
 	 */
 	public static void onOutput(String text, boolean isStdErr) {
-		if (!logSystemOutput || !dapClientConnected) {
+		if (!consoleOutput || !dapClientConnected) {
 			return;
 		}
 		Log.systemOutput(text, isStdErr);

luceedebug/src/main/java/luceedebug/coreinject/frame/NativeDebugFrame.java

@@ -355,9 +355,9 @@ private static synchronized boolean initReflection( ClassLoader luceeClassLoader
 		}
 
 		try {
-			// Check if DEBUGGER_ENABLED is true (via env var)
+			// Check if debugger is enabled (via LUCEE_DEBUGGER_SECRET env var)
 			if ( !EnvUtil.isDebuggerEnabled() ) {
-				Log.info( "Native frame support disabled: LUCEE_DEBUGGER_ENABLED not set" );
+				Log.info( "Native frame support disabled: LUCEE_DEBUGGER_SECRET not set" );
 				nativeFrameSupportAvailable = false;
 				return false;
 			}

vscode-client/package.json

@@ -194,10 +194,10 @@
                 "default": false,
                 "description": "Log exceptions to the debug console."
               },
-              "logSystemOutput": {
+              "consoleOutput": {
                 "type": "boolean",
                 "default": false,
-                "description": "Show System.out/err in the debug console."
+                "description": "Stream console output to the debug console (Lucee 7.1+)."
               },
               "secret": {
                 "type": "string",