always use sentry code path, just don't send when no dsn in dev

Author: zspitzer

apps/updateserver/Application.cfc

@@ -93,8 +93,7 @@ component {
 		application.downloadsUrl            = server.system.environment.DOWNLOADS_URL         ?: "https://download.lucee.org/";
 		application.updateProviderUrl       = server.system.environment.UPDATE_PROVIDER       ?: "https://update.lucee.org/rest/update/provider/";
 		application.extensionProviderUrl    = server.system.environment.EXTENSION_PROVIDER    ?: "https://extensions.lucee.org/rest/extension/provider/";
-		application.sentryDsn               = server.system.environment.SENTRY_DSN             ?: "https://[email protected]/4507452800040960";
-		
+		application.sentryDsn               = server.system.environment.SENTRY_DSN            ?: "";
 
 		if ( left( application.coreS3Root, 3 ) == "s3:"
 				&& ( len( this.s3.awsSecretKey ) == 0 || len( this.s3.accessKeyId ) == 0) ) {

apps/updateserver/services/ExtensionMetadataReader.cfc

@@ -26,7 +26,7 @@ component accessors=true {
 
 			if (meta.recordcount == 0){ 
 				// rebuilding the index takes a while as all extensions need to be re-downloaded and processed
-				setting requesttimeout="#lexFiles.recordcount#*4";
+				setting requesttimeout="#(lexFiles.recordcount*4)#";
 			}
 
 			for( var lexFile in lexFiles ) {

apps/updateserver/services/SentryLogger.cfc

@@ -16,14 +16,17 @@ component {
 	public function init( required struct config ) {
 		variables.config = arguments.config;
 
-		// Validate required config keys
-		if ( !structKeyExists( variables.config, "dsn" ) || isEmpty( variables.config.dsn ) ) {
-			throw( type="Sentry.ConfigurationException", message="Missing required configuration key: dsn" );
+		// DSN is optional - if not provided or empty, logger will exercise all code paths but not send to Sentry
+		// Strip quotes in case DSN comes through as literal '""' string from environment variables
+		var cleanDsn = trim( replace( variables.config.dsn ?: "", '""', '', 'all' ) );
+		if ( len( cleanDsn ) && cleanDsn neq '""' ) {
+			// Parse the DSN
+			variables.sentryInfo = _parseDsn( cleanDsn );
+			variables.hasDsn = true;
+		} else {
+			variables.hasDsn = false;
 		}
 
-		// Parse the DSN
-		variables.sentryInfo = _parseDsn( variables.config.dsn );
-
 		// Set defaults
 		if ( !structKeyExists( variables.config, "environment" ) || isEmpty( variables.config.environment ) ) {
 			variables.config.environment = "production";
@@ -179,6 +182,17 @@ component {
 	 * Sends an event to Sentry via HTTP.
 	 */
 	private struct function _sendEvent( required struct event ) {
+		// If no DSN configured, skip the HTTP call but return success
+		// This allows full code path testing in dev without sending to Sentry
+		if ( !variables.hasDsn ) {
+			return {
+				"success" = true,
+				"eventId" = arguments.event.event_id,
+				"statusCode" = "200",
+				"note" = "No DSN configured - event not sent to Sentry"
+			};
+		}
+
 		var fullUrl = variables.sentryInfo.apiUrl;
 		var timestamp = _getTimestamp();