refactor: improve GroqClient and service provider setup

- Move config merging to the top of the service provider's register method
- Add a getApiKey method in GroqClient to access the API key via reflection
- Simplify test assertions in TranslationsTest by using direct array comparisons

Author: lucianotonet

.env.testing

@@ -0,0 +1,2 @@
+APP_ENV=testing
+GROQ_API_KEY="${GROQ_API_KEY}"

phpunit.xml

@@ -16,6 +16,5 @@
     </coverage>
     <php>
         <env name="APP_ENV" value="testing"/>
-        <env name="GROQ_API_KEY" value=""/>
     </php>
-</phpunit> 
+</phpunit>

src/GroqClient.php

@@ -39,8 +39,8 @@ public function __construct(?string $apiKey = null)
                 '1. Constructor parameter' . PHP_EOL .
                 '2. Environment variable (GROQ_API_KEY)' . PHP_EOL .
                 '3. Config file (config/groq.php)',
-                GroqException::CODE_INVALID_REQUEST,
-                GroqException::TYPE_INVALID_REQUEST,
+                400, // HTTP 400 Bad Request code
+                'invalid_request_error' // Error type
             );
         }
 
@@ -153,7 +153,7 @@ public function setConfig(array $options): void
 
         // Create new client with updated options
         $this->client = new Groq(
-            $this->client->apiKey,
+            $this->getApiKey(), // Use the getter method instead of direct property access
             $mergedOptions
         );
     }
@@ -178,4 +178,18 @@ public function getClient(): Groq
     {
         return $this->client;
     }
-} 
+    
+    /**
+     * Get the API key from the client
+     * 
+     * @return string
+     */
+    private function getApiKey(): string
+    {
+        // Access the API key through reflection since it's not directly accessible
+        $reflection = new \ReflectionClass($this->client);
+        $property = $reflection->getProperty('apiKey');
+        $property->setAccessible(true);
+        return $property->getValue($this->client);
+    }
+}

src/GroqServiceProvider.php

@@ -3,11 +3,15 @@
 namespace LucianoTonet\GroqLaravel;
 
 use Illuminate\Support\ServiceProvider;
+use LucianoTonet\GroqPHP\Groq;
 
 class GroqServiceProvider extends ServiceProvider
 {
     public function register(): void
     {
+        // Merge config
+        $this->mergeConfigFrom(__DIR__ . '/../config/groq.php', 'groq');
+
         $this->app->singleton(Groq::class, function ($app, $parameters = []) {
             return new Groq(
                 $parameters['apiKey'] ?? config('groq.api_key'),
@@ -17,6 +21,14 @@ public function register(): void
 
         // Register the alias 'groq' -> Groq::class
         $this->app->alias(Groq::class, 'groq');
+
+        // Register the GroqClient singleton
+        $this->app->singleton(GroqClient::class, function ($app) {
+            return new GroqClient(config('groq.api_key'));
+        });
+
+        // Register facade
+        $this->app->alias(GroqClient::class, 'groq');
     }
 
     /**
@@ -32,21 +44,4 @@ public function boot()
 
         $this->loadTranslationsFrom(__DIR__ . '/../lang', 'groq');
     }
-
-    /**
-     * Register the application services.
-     */
-    public function register()
-    {
-        // Merge config
-        $this->mergeConfigFrom(__DIR__ . '/../config/groq.php', 'groq');
-
-        // Register the GroqClient singleton
-        $this->app->singleton(GroqClient::class, function ($app) {
-            return new GroqClient(config('groq.api_key'));
-        });
-
-        // Register facade
-        $this->app->alias(GroqClient::class, 'groq');
-    }
 }

tests/Feature/TranslationsTest.php

@@ -39,11 +39,7 @@ public function it_can_create_translation_with_file()
         $mockTranslations = $this->createMock(Translations::class);
         $mockTranslations->expects($this->once())
             ->method('create')
-            ->with($this->callback(function ($params) {
-                return isset($params['file']) && 
-                       isset($params['model']) && 
-                       $params['model'] === 'whisper-large-v3';
-            }))
+            ->with(["file" => __DIR__ . '/test-audio.mp3', "model" => 'whisper-large-v3'])
             ->willReturn($expectedResponse);
 
         // Mock the Audio class that will return our mock Translations
@@ -103,13 +99,12 @@ public function it_can_create_translation_with_options()
         $mockTranslations = $this->createMock(Translations::class);
         $mockTranslations->expects($this->once())
             ->method('create')
-            ->with($this->callback(function ($params) {
-                return isset($params['file']) && 
-                       isset($params['temperature']) && 
-                       $params['temperature'] === 0.3 &&
-                       isset($params['response_format']) && 
-                       $params['response_format'] === 'verbose_json';
-            }))
+            ->with([
+                'file' => __DIR__ . '/test-audio.mp3',
+                'model' => 'whisper-large-v3',
+                'temperature' => 0.3,
+                'response_format' => 'verbose_json'
+            ])
             ->willReturn($expectedResponse);
 
         // Mock the Audio class that will return our mock Translations
@@ -146,4 +141,4 @@ public function it_can_create_translation_with_options()
         $this->assertCount(2, $result['segments']);
         $this->assertEquals('This is a test translation', $result['segments'][0]['text']);
     }
-} 
+}