refactor: Implement CodeRabbit suggestions and add project rules

Author: lucianotonet

.cursor/rules/codebase.mdc

@@ -0,0 +1 @@
+ 

.cursorrules

@@ -0,0 +1,39 @@
+# Groq Laravel Project Rules
+
+## Project Info
+- Package: Laravel integration for GroqCloud API
+- Uses PHP 8.1+ / Laravel support
+- Composer package: lucianotonet/groq-laravel
+- Base dependency: lucianotonet/groq-php
+
+## Key Guidelines
+
+### Code Style
+- Use English for all code and comments
+- Follow PSR-12 coding standards
+- Properly document all public methods with PHPDoc
+
+### Models
+- Default model: 'llama-3.1-8b-instant' (standardized throughout the codebase)
+- Model name should be consistent in config and code
+
+### Configuration
+- Config priorities: 
+  1. Runtime options (setConfig/setOptions)
+  2. Environment variables (.env)
+  3. Default values in config file
+
+### Testing
+- Integration tests should not rely on external resources (URLs, APIs)
+- Mock API responses when possible
+- Use base64 encoded test images instead of external URLs
+- Tests should have descriptive names and assertions
+
+### Error Handling
+- Validate API key early with clear error messages
+- Use proper exception types from GroqException
+
+### Important Learnings
+- GroqClient should preserve previously set options when calling setConfig()
+- The Facade is just a proxy to the underlying client instance
+- Avoid inconsistencies between default values in different parts of code 

config/groq.php

@@ -30,7 +30,7 @@
     | da API Groq. Esse modelo será usado se nenhum for especificado na requisição.
     |
     */
-    'model' => env('GROQ_MODEL', 'llama3-8b-8192'),
+    'model' => env('GROQ_MODEL', 'llama-3.1-8b-instant'),
 
     /*
     |--------------------------------------------------------------------------

src/GroqClient.php

@@ -58,7 +58,7 @@ protected function getDefaultConfig(): array
         return [
             'baseUrl' => config('groq.api_base', 'https://api.groq.com/openai/v1'),
             'timeout' => config('groq.timeout', 30),
-            'model' => config('groq.model', 'llama3-8b-8192'),
+            'model' => config('groq.model', 'llama-3.1-8b-instant'),
             'max_tokens' => config('groq.options.max_tokens', 150),
             'temperature' => config('groq.options.temperature', 0.7),
             'top_p' => config('groq.options.top_p', 1.0),
@@ -135,9 +135,26 @@ public function batches()
      */
     public function setConfig(array $options): void
     {
+        // Get current client options if available
+        $currentOptions = [];
+        if (property_exists($this->client, 'options')) {
+            $currentOptions = $this->client->options;
+        }
+        
+        // Merge in order of precedence: 
+        // 1. New options (highest priority)
+        // 2. Current options (if they exist)
+        // 3. Default config (lowest priority)
+        $mergedOptions = array_merge(
+            $this->getDefaultConfig(), 
+            $currentOptions, 
+            $options
+        );
+        
+        // Create new client with updated options
         $this->client = new Groq(
             $this->client->apiKey,
-            array_merge($this->getDefaultConfig(), $options)
+            $mergedOptions
         );
     }
 

tests/Feature/GroqIntegrationTest.php

@@ -15,9 +15,9 @@ protected function getPackageProviders($app)
 
     protected function getEnvironmentSetUp($app)
     {
-        // Use a chave real da API para testes de integração
+        // Use the real API key for integration tests
         $app['config']->set('groq.api_key', env('GROQ_API_KEY'));
-        $app['config']->set('groq.model', 'llama3-8b-8192');
+        $app['config']->set('groq.model', 'llama-3.1-8b-instant');
     }
 
     /** @test */
@@ -34,9 +34,9 @@ public function it_can_list_models()
     public function it_can_create_chat_completion()
     {
         $response = Groq::chat()->completions()->create([
-            'model' => 'llama3-8b-8192',
+            'model' => 'llama-3.1-8b-instant',
             'messages' => [
-                ['role' => 'user', 'content' => 'Diga olá em português']
+                ['role' => 'user', 'content' => 'Say hello in Portuguese']
             ]
         ]);
 
@@ -50,9 +50,10 @@ public function it_can_create_chat_completion()
     /** @test */
     public function it_can_analyze_image()
     {
-        $imageUrl = 'https://raw.githubusercontent.com/lucianotonet/groq-laravel/main/docs/art.png';
+        // Using a small embedded test image as Base64 to avoid external dependency
+        $base64Image = 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAoAAAAKCAYAAACNMs+9AAAAFElEQVR42mP8z8BQz0AEYBxVSF+FABJADveWkH6oAAAAAElFTkSuQmCC';
 
-        $response = Groq::vision()->analyze($imageUrl, 'Descreva esta imagem');
+        $response = Groq::vision()->analyze($base64Image, 'Describe this image');
 
         $this->assertIsArray($response);
         $this->assertArrayHasKey('choices', $response);
@@ -67,18 +68,18 @@ public function it_can_handle_errors_gracefully()
         $this->expectException(\LucianoTonet\GroqPHP\GroqException::class);
 
         Groq::chat()->completions()->create([
-            'model' => 'llama3-8b-8192',
-            'messages' => [] // Mensagens vazias devem gerar erro
+            'model' => 'llama-3.1-8b-instant',
+            'messages' => [] // Empty messages should generate an error
         ]);
     }
 
     /** @test */
     public function it_can_use_different_models()
     {
         $response = Groq::chat()->completions()->create([
-            'model' => 'llama3-8b-8192', // Usando o modelo padrão ao invés do mixtral
+            'model' => 'llama-3.1-8b-instant', // Using the default model instead of mixtral
             'messages' => [
-                ['role' => 'user', 'content' => 'Diga olá em português']
+                ['role' => 'user', 'content' => 'Say hello in Portuguese']
             ]
         ]);
 
@@ -89,9 +90,9 @@ public function it_can_use_different_models()
     /** @test */
     public function it_can_handle_file_operations()
     {
-        // Criar arquivo JSONL temporário
+        // Create temporary JSONL file
         $tempFile = tempnam(sys_get_temp_dir(), 'groq_test_') . '.jsonl';
-        file_put_contents($tempFile, json_encode(['prompt' => 'Olá']) . "\n" . json_encode(['prompt' => 'Mundo']) . "\n");
+        file_put_contents($tempFile, json_encode(['prompt' => 'Hello']) . "\n" . json_encode(['prompt' => 'World']) . "\n");
 
         // Upload
         $file = Groq::files()->upload($tempFile, 'batch');
@@ -115,23 +116,27 @@ public function it_can_handle_file_operations()
     /** @test */
     public function it_respects_configuration_options()
     {
-        // Configurando para gerar respostas curtas, mas com limite de tokens maior
+        // Configure to generate short responses with stricter token limit
         Groq::setConfig([
             'temperature' => 0.1,
-            'max_tokens' => 30 // Usando um valor muito mais restritivo para o teste
+            'max_tokens' => 30 // Using a much more restrictive value for testing
         ]);
 
         $response = Groq::chat()->completions()->create([
-            'model' => 'llama3-8b-8192',
+            'model' => 'llama-3.1-8b-instant',
             'messages' => [
-                ['role' => 'user', 'content' => 'Diga apenas "Olá, mundo!"']
+                ['role' => 'user', 'content' => 'Just say "Hello, world!"']
             ],
-            'max_tokens' => 30 // Garantindo que o valor seja passado na requisição também
+            'max_tokens' => 30 // Ensuring the value is also passed in the request
         ]);
 
         $this->assertIsArray($response);
         $this->assertArrayHasKey('choices', $response);
-        // Vamos apenas verificar se há resposta, sem verificar o tamanho
+        // Let's just check if there's a response, without verifying the size
         $this->assertNotEmpty($response['choices'][0]['message']['content']);
+        
+        // Verify the response is reasonably constrained by max_tokens
+        $content = $response['choices'][0]['message']['content'];
+        $this->assertLessThanOrEqual(100, strlen($content), 'Response should be constrained by max_tokens');
     }
 }