change make:controller params order

For consistency with the rest of the commands

Author: Mulkave

TODO.md

@@ -1,4 +1,4 @@
-- [ ] Specifying Laravel version on installation
+- [x] Specifying Laravel version on installation
 - [ ] Documentation
 - [ ] Change namespace using CLI
     - > By extending `Illuminate\Foundation\Console\AppNameCommand`

src/Commands/ControllerMakeCommand.php

@@ -67,7 +67,7 @@ public function fire()
             $this->info('Controller class created successfully.'.
                 "\n".
                 "\n".
-                'Find it at <comment>'.strstr($controller, 'src/').'</comment>'."\n"
+                'Find it at <comment>'.$controller.'</comment>'."\n"
             );
         } catch (Exception $e) {
             $this->error($e->getMessage());
@@ -82,8 +82,8 @@ public function fire()
     protected function getArguments()
     {
         return [
-            ['service', InputArgument::REQUIRED, 'The service in which the controller should be generated.'],
             ['controller', InputArgument::REQUIRED, 'The controller\'s name.'],
+            ['service', InputArgument::OPTIONAL, 'The service in which the controller should be generated.'],
         ];
     }
 

src/Finder.php

@@ -479,12 +479,15 @@ public function findControllerNamespace($service)
      */
     public function listServices()
     {
-        $finder = new SymfonyFinder();
-
         $services = new Collection();
-        foreach ($finder->directories()->depth('== 0')->in($this->findServicesRootPath())->directories() as $dir) {
-            $realPath = $dir->getRealPath();
-            $services->push(new Service($dir->getRelativePathName(), $realPath, $this->relativeFromReal($realPath)));
+
+        if (file_exists($this->findServicesRootPath())) {
+            $finder = new SymfonyFinder();
+
+            foreach ($finder->directories()->depth('== 0')->in($this->findServicesRootPath())->directories() as $dir) {
+                $realPath = $dir->getRealPath();
+                $services->push(new Service($dir->getRelativePathName(), $realPath, $this->relativeFromReal($realPath)));
+            }
         }
 
         return $services;