Skip to content

Commit 207d23a

Browse files
authored
Update denoising_diffusion_pytorch.py
Shouldn't eta be 0 for DDIM sampling? In the DDIM paper in section 5.1 they mention the eta=0 is DDIM, and eta=1 approximates the normal DDPM. They also use [eta=0](https://github.com/openai/improved-diffusion/blob/e94489283bb876ac1477d5dd7709bbbd2d9902ce/improved_diffusion/gaussian_diffusion.py#L487) in the openai implementation of DDIM.
1 parent cf4f449 commit 207d23a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

denoising_diffusion_pytorch/denoising_diffusion_pytorch.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -431,7 +431,7 @@ def __init__(
431431
beta_schedule = 'cosine',
432432
p2_loss_weight_gamma = 0., # p2 loss weight, from https://arxiv.org/abs/2204.00227 - 0 is equivalent to weight of 1 across time - 1. is recommended
433433
p2_loss_weight_k = 1,
434-
ddim_sampling_eta = 1.
434+
ddim_sampling_eta = 0.
435435
):
436436
super().__init__()
437437
assert not (type(self) == GaussianDiffusion and model.channels != model.out_dim)

0 commit comments

Comments
 (0)