Skip to content

Commit 1571765

Browse files
committed
Don't use services because that only works on linux. Also need the lucky binary to be available
1 parent d3b3872 commit 1571765

File tree

1 file changed

+24
-28
lines changed

1 file changed

+24
-28
lines changed

.github/workflows/ci.yml

Lines changed: 24 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -53,33 +53,31 @@ jobs:
5353
strategy:
5454
fail-fast: false
5555
matrix:
56+
postgres_version: 18
5657
include:
5758
- { os: macos-latest }
5859
- { os: windows-latest }
5960
- { os: ubuntu-latest }
6061
runs-on: ${{matrix.os}}
6162
continue-on-error: false
62-
services:
63-
postgres:
64-
image: postgres:18-alpine
65-
env:
66-
POSTGRES_USER: postgres
67-
POSTGRES_PASSWORD: postgres
68-
ports:
69-
- 5432:5432
70-
# needed because the postgres container does not provide a healthcheck
71-
options: >-
72-
--health-cmd pg_isready
73-
--health-interval 10s
74-
--health-timeout 5s
75-
--health-retries 5
7663
steps:
7764
- uses: actions/checkout@v6
65+
- name: Setup PostgreSQL v${{ matrix.postgres_version }}
66+
uses: ikalnytskyi/action-setup-postgres@v8
67+
with:
68+
username: postgres
69+
password: postgres
70+
port: 5432
71+
postgres-version: ${{ matrix.postgres_version }}
7872
- uses: crystal-lang/install-crystal@v1
7973
with:
8074
crystal: latest
8175
- name: Install shards
8276
run: shards install --skip-postinstall --skip-executables
77+
- name: Install LuckyCLI
78+
run: |
79+
crystal build src/lucky.cr
80+
pwd >> $GITHUB_PATH
8381
- name: Run e2e Browser app with authentication flow
8482
run: crystal spec spec/end_to_end/browser_with_auth_spec.cr
8583
env:
@@ -90,33 +88,31 @@ jobs:
9088
strategy:
9189
fail-fast: false
9290
matrix:
91+
postgres_version: 18
9392
include:
9493
- { os: macos-latest }
9594
- { os: windows-latest }
9695
- { os: ubuntu-latest }
9796
runs-on: ${{matrix.os}}
9897
continue-on-error: false
99-
services:
100-
postgres:
101-
image: postgres:18-alpine
102-
env:
103-
POSTGRES_USER: postgres
104-
POSTGRES_PASSWORD: postgres
105-
ports:
106-
- 5432:5432
107-
# needed because the postgres container does not provide a healthcheck
108-
options: >-
109-
--health-cmd pg_isready
110-
--health-interval 10s
111-
--health-timeout 5s
112-
--health-retries 5
11398
steps:
11499
- uses: actions/checkout@v6
100+
- name: Setup PostgreSQL v${{ matrix.postgres_version }}
101+
uses: ikalnytskyi/action-setup-postgres@v8
102+
with:
103+
username: postgres
104+
password: postgres
105+
port: 5432
106+
postgres-version: ${{ matrix.postgres_version }}
115107
- uses: crystal-lang/install-crystal@v1
116108
with:
117109
crystal: latest
118110
- name: Install shards
119111
run: shards install --skip-postinstall --skip-executables
112+
- name: Install LuckyCLI
113+
run: |
114+
crystal build src/lucky.cr
115+
pwd >> $GITHUB_PATH
120116
- name: Run e2e Browser app with authentication flow
121117
run: crystal spec spec/end_to_end/browser_no_auth_spec.cr
122118
env:

0 commit comments

Comments
 (0)