Skip to content

Commit 79ee19a

Browse files
authored
Fixing issues with generated projects (#907)
* Fixing generated project formatting issues * Fixing compile-time error when loading manifest on generated projects * Generate an initial asset manifest on setup so tasks will run properly * Update javascript dependencies for generated projects
1 parent 9598e57 commit 79ee19a

File tree

4 files changed

+11
-8
lines changed

4 files changed

+11
-8
lines changed

src/browser_app_skeleton/package.json.ecr

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"type": "module",
55
"dependencies": {
66
"@rails/ujs": "^7.1.0",
7-
"modern-normalize": "^2.0.0"
7+
"modern-normalize": "^3.0.1"
88
},
99
"scripts": {
1010
"heroku-postbuild": "yarn build",
@@ -14,9 +14,9 @@
1414
"watch": "vite build --watch"
1515
},
1616
"devDependencies": {
17-
"sass": "^1.69.5",
18-
"vite": "^5.0.0",
17+
"sass": "^1.97.2",
18+
"vite": "^7.3.1",
1919
"vite-plugin-compression": "^0.5.1",
20-
"vite-plugin-dev-manifest": "^1.2.1"
20+
"vite-plugin-dev-manifest": "^1.4.1"
2121
}
2222
}

src/web_app_skeleton/config/server.cr.ecr

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,4 +65,4 @@ end
6565
private def raise_missing_secret_key_in_production
6666
puts "Please set the SECRET_KEY_BASE environment variable. You can generate a secret key with 'lucky gen.secret_key'".colorize.red
6767
exit(1)
68-
end
68+
end

src/web_app_skeleton/script/setup.cr.ecr

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@ print_done
1010
notice "Installing node dependencies"
1111
run_command "yarn", "install", "--no-progress"
1212

13+
notice "Building initial asset manifest"
14+
run_command "yarn", "build"
15+
1316
print_done
1417
<%- end -%>
1518

src/web_app_skeleton/src/app.cr.ecr

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@ require "./shards"
55
# In development, vite-plugin-dev-manifest creates public/manifest.dev.json
66
# In production, Vite creates public/.vite/manifest.json
77
# The manifest path is determined by which file exists at compile time
8-
{% if File.exists?("public/manifest.dev.json") %}
8+
{% if file_exists?("public/manifest.dev.json") %}
99
Lucky::AssetHelpers.load_manifest "public/manifest.dev.json", use_vite: true
10-
{% elsif File.exists?("public/.vite/manifest.json") %}
10+
{% elsif file_exists?("public/.vite/manifest.json") %}
1111
Lucky::AssetHelpers.load_manifest "public/.vite/manifest.json", use_vite: true
1212
{% else %}
1313
# For initial compilation, we'll assume development mode
@@ -38,4 +38,4 @@ require "./components/**"
3838
require "./pages/**"
3939
<%- end -%>
4040
require "../db/migrations/**"
41-
require "./app_server"
41+
require "./app_server"

0 commit comments

Comments
 (0)