[Lint] fix lint warnings

Author: Luigi Cocozza

.clang-tidy

@@ -9,20 +9,25 @@ Checks: '
   readability-*,
   -readability-magic-numbers,
   -readability-identifier-length,
+  -readability-braces-around-statements,
   -readability-function-cognitive-complexity,
   -readability-avoid-nested-conditional-operator,
   -readability-non-const-parameter,
   -readability-implicit-bool-conversion,
   -readability-const-return-type,
   -readability-identifier-naming,
+  -readability-suspicious-call-argument,
   -misc-const-correctness,
   -performance-unnecessary-value-param,
   -modernize-use-cxx-headers,
   -cert-err33-c,
+  -cert-dcl37-c,
+  -cert-dcl51-cpp,
   -clang-analyzer-unix.MallocSizeof,
   -bugprone-easily-swappable-parameters,
   -bugprone-narrowing-conversions,
   -bugprone-multi-level-implicit-pointer-conversion,
+  -bugprone-reserved-identifier,
   -clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling,
   -clang-analyzer-security.insecureAPI.strcpy,
   -clang-analyzer-optin.performance.Padding,

includes/argus/options.h

@@ -84,13 +84,13 @@ ARGUS_API char *format_choices_validator(validator_data_t data);
  */
 #define MAKE_VALIDATOR(fn, _formatter_, _data_, _order_) \
     &(validator_entry_t){ \
-        .func = fn, \
-        .formatter = _formatter_, \
-        .data = _data_, \
-        .order = _order_ \
+        .func = (fn), \
+        .formatter = (_formatter_), \
+        .data = (_data_), \
+        .order = (_order_) \
     }
 #define _V_DATA_RANGE_(_min_, _max_) \
-    ((validator_data_t){ .range = (argus_range_t){ .min = _min_, .max = _max_ } })
+    ((validator_data_t){ .range = (argus_range_t){ .min = (_min_), .max = (_max_) } })
 #define _V_DATA_CUSTOM_(data) \
     ((validator_data_t){ .custom = (uintptr_t)(data) })
 

source/api/argus_value_access.c

@@ -15,7 +15,7 @@
 
 argus_value_t argus_get(argus_t *argus, const char *option_path)
 {
-    argus->error_code       = 0;
+    argus->error_code      = 0;
     argus_option_t *option = find_option_by_active_path(*argus, option_path);
     if (option == NULL) {
         argus->error_code = ARGUS_ERROR_NO_VALUE;
@@ -42,7 +42,7 @@ size_t argus_count(argus_t *argus, const char *option_path)
 
 argus_value_t argus_array_get(argus_t *argus, const char *option_path, size_t index)
 {
-    argus->error_code       = 0;
+    argus->error_code      = 0;
     argus_option_t *option = find_option_by_active_path(*argus, option_path);
 
     if (option == NULL) {
@@ -68,7 +68,7 @@ argus_value_t argus_array_get(argus_t *argus, const char *option_path, size_t in
 
 argus_value_t argus_map_get(argus_t *argus, const char *option_path, const char *key)
 {
-    argus->error_code       = 0;
+    argus->error_code      = 0;
     argus_option_t *option = find_option_by_active_path(*argus, option_path);
 
     if (option == NULL) {

source/callbacks/handlers/map_bool_handler.c

@@ -14,7 +14,6 @@
 #include <string.h>
 
 #include "argus/errors.h"
-#include "argus/internal/compiler.h"
 #include "argus/internal/cross_platform.h"
 #include "argus/internal/utils.h"
 #include "argus/options.h"

source/callbacks/handlers/map_float_handler.c

@@ -13,7 +13,6 @@
 #include <string.h>
 
 #include "argus/errors.h"
-#include "argus/internal/compiler.h"
 #include "argus/internal/cross_platform.h"
 #include "argus/internal/utils.h"
 #include "argus/options.h"

source/callbacks/handlers/map_int_handler.c

@@ -14,7 +14,6 @@
 #include <string.h>
 
 #include "argus/errors.h"
-#include "argus/internal/compiler.h"
 #include "argus/internal/cross_platform.h"
 #include "argus/internal/utils.h"
 #include "argus/options.h"

source/callbacks/handlers/map_string_handler.c

@@ -13,7 +13,6 @@
 #include <string.h>
 
 #include "argus/errors.h"
-#include "argus/internal/compiler.h"
 #include "argus/internal/cross_platform.h"
 #include "argus/internal/utils.h"
 #include "argus/options.h"

source/callbacks/validators/choices_validator.c

@@ -14,7 +14,6 @@
 
 #include "argus/errors.h"
 #include "argus/internal/cross_platform.h"
-#include "argus/internal/utils.h"
 #include "argus/types.h"
 
 // Forward declaration
@@ -97,10 +96,8 @@ char *format_choices_validator(validator_data_t data)
                 total_length += strlen(choices->as_strings[i]);
                 break;
             case VALUE_TYPE_INT:
-                total_length += 20;  // Max digits for int64_t
-                break;
             case VALUE_TYPE_FLOAT:
-                total_length += 20;  // Max digits for double
+                total_length += 20;  // Max digits for int64_t/double
                 break;
             default:
                 break;

source/callbacks/validators/count_validator.c

@@ -8,6 +8,7 @@
  */
 
 #include <inttypes.h>
+#include <stdint.h>
 #include <stdio.h>
 #include <stdlib.h>
 

source/callbacks/validators/length_validator.c

@@ -8,6 +8,7 @@
  */
 
 #include <inttypes.h>
+#include <stdint.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>