adjust typing for Controller

Author: leonstafford

phpstan.neon

@@ -19,7 +19,7 @@ parameters:
         # https://gist.github.com/nicolas-grekas/1028251#improving-native-php-interface
         - message: '#^In method "WP2Static\\\S+::\S+", you should not use the \$_(COOKIE|GET|POST) superglobal#'
           path: src/Controller.php
-          count: 6
+          count: 1
         - message: '#^In method "WP2Static\\\S+::\S+", you should not use the \$_(GET|POST) superglobal#'
           path: src/CoreOptions.php
           count: 16
@@ -47,4 +47,7 @@ parameters:
         - message: "#^Cannot access offset \\S+ on mixed\\.$#"
           path: src/SitemapParser.php
           count: 3
+        - message: "#^Cannot access property \\S+ on mixed\\.$#"
+          path: src/Controller.php
+          count: 6
         - '/^Parameter #2 \$callable of static method WP_CLI::add_command\(\) expects callable\(\): mixed, \S+ given\.$/'

src/Controller.php

@@ -364,8 +364,9 @@ public static function wp2staticProcessJobsQueue() : void {
     public static function wp2staticDeployCacheDelete() : void {
         check_admin_referer( 'wp2static-caches-page' );
 
-        if ( isset( $_POST['deploy_namespace'] ) ) {
-            DeployCache::truncate( $_POST['deploy_namespace'] );
+        $deploy_namespace = strval( filter_input( INPUT_POST, 'deploy_namespace' ) );
+        if ( $deploy_namespace !== '' ) {
+            DeployCache::truncate( $deploy_namespace );
         } else {
             DeployCache::truncate();
         }
@@ -377,11 +378,12 @@ public static function wp2staticDeployCacheDelete() : void {
     public static function wp2staticDeployCacheShow() : void {
         check_admin_referer( 'wp2static-caches-page' );
 
-        if ( isset( $_POST['deploy_namespace'] ) ) {
+        $deploy_namespace = strval( filter_input( INPUT_POST, 'deploy_namespace' ) );
+        if ( $deploy_namespace !== '' ) {
             wp_safe_redirect(
                 admin_url(
                     'admin.php?page=wp2static-deploy-cache&deploy_namespace=' .
-                    urlencode( $_POST['deploy_namespace'] )
+                    urlencode( $deploy_namespace )
                 )
             );
         } else {
@@ -515,7 +517,7 @@ public static function wp2staticToggleAddon( string $addon_slug = null ) : void
         } else {
             check_admin_referer( 'wp2static-addons-page' );
 
-            $addon_slug = sanitize_text_field( $_POST['addon_slug'] );
+            $addon_slug = sanitize_text_field( strval( filter_input( INPUT_POST, 'addon_slug' ) ) );
         }
 
         global $wpdb;