Skip to content

Commit 4490219

Browse files
authored
Run 25_id_generation with and without synthetic id (elastic#142770)
* Run 25_id_generation with and without synthetic id Add 25_id_generation_synthetic_id.yml as copy of 25_id_generation.yml but with index.mapping.synthetic_id=true and updated expected id value. Add synthetic id feature flag to ClientYamlTestSuiteIT Harden 25_id_generation.yml to use synthetic_id=false * Rename 25_id_generation_synthetic_id -> 26_id_... * yaml tsdb/25_id_generation backwards compatible Because tsdb/25_id_generation also runs in mixed and backwards compatible cluster we cannot use synthetic_id setting at all unless the cluster has cluster_features: "index.time_series_synthetic_id". Introduce tsdb/26_id_generation_synthetic_id_false that specifically set the setting to false and otherwise keep the behaviour from 25_generation_id. 26_id_generation_synthetic_id.yml is renamed to 27_id_generation_synthetic_id_true.yml TL;DR: Version <9.4 run 25_id_generation.yml Version >=9.4 run 26_id_generation_synthetic_id_synthetic_false.yml and 27_id_generation_synthetic_id_true.yml
1 parent dc07161 commit 4490219

File tree

4 files changed

+1029
-0
lines changed

4 files changed

+1029
-0
lines changed

rest-api-spec/src/yamlRestTest/java/org/elasticsearch/test/rest/ClientYamlTestSuiteIT.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ public class ClientYamlTestSuiteIT extends ESClientYamlSuiteTestCase {
3838
.feature(FeatureFlag.SYNTHETIC_VECTORS)
3939
.feature(FeatureFlag.RANDOM_SAMPLING)
4040
.feature(FeatureFlag.EXTENDED_DOC_VALUES_PARAMS)
41+
.feature(FeatureFlag.TSDB_SYNTHETIC_ID_FEATURE_FLAG)
4142
.build();
4243

4344
public ClientYamlTestSuiteIT(@Name("yaml") ClientYamlTestCandidate testCandidate) {

rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/tsdb/25_id_generation.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,10 @@ setup:
44
cluster_features: "gte_v8.14.0"
55
reason: _tsid hashing introduced in 8.13 and tsid routing changed in 8.14
66

7+
- skip:
8+
cluster_features: "index.time_series_synthetic_id"
9+
reason: when cluster has synthetic_id feature use 26_id_generation_synthetic_id_false instead
10+
711
- do:
812
indices.create:
913
index: id_generation_test

0 commit comments

Comments
 (0)