Optimize [locale].json with only required translations

Author: luisprmat

src/Console/InstallCommand.php

@@ -49,6 +49,12 @@ public function handle()
         }
 
         $discoveredPackages = $this->discoveredPackages();
+
+        // Add 'fortify' translations if 'jetstream' is installed
+        if (in_array('jetstream', $discoveredPackages)) {
+            array_push($discoveredPackages, 'fortify');
+        }
+
         $this->loadJsonFile($locale, $discoveredPackages);
 
         if (!$this->option('no-default')) {
@@ -85,24 +91,24 @@ private function loadJsonFile($locale, $packages = [])
         $baseSource = json_decode(File::get(base_path('vendor/laravel-lang/lang/source/en.json')));
         $jsonLocale = json_decode(File::get(base_path("vendor/laravel-lang/lang/locales/{$locale}/{$locale}.json")), true);
 
-        $modify = array_filter($jsonLocale, function ($item) use ($baseSource) {
-            return in_array($item, $baseSource);
+        $showTags = $baseSource;
+
+        foreach ($packages as $package) {
+            $showTags = array_merge(
+                $showTags,
+                json_decode(File::get(base_path("vendor/laravel-lang/lang/source/packages/{$package}.json")))
+            );
+        }
+
+        $showTags = array_unique($showTags);
+        sort($showTags);
+
+        $modify = array_filter($jsonLocale, function ($item) use ($showTags) {
+            return in_array($item, $showTags);
         }, ARRAY_FILTER_USE_KEY);
 
         $modifiedJson = json_encode($modify, JSON_PRETTY_PRINT | JSON_UNESCAPED_UNICODE);
 
-//        dd($baseSource, $jsonLocale, $modifiedJson);
-//        $modifiedJson = <<<JSON
-//{
-//    "Add Base": "Añadir base",
-//    "Changes Base": "Cambios base",
-//    "If you already have an account, you may accept this invitation by clicking the button below: base": "Si ya tiene una cuenta, puede aceptar esta invitación haciendo clic en el botón de abajo: base",
-//    "Whoops! all": "¡Ups! todo"
-//}
-//
-//JSON;
-
-//        copy(base_path("vendor/laravel-lang/lang/locales/{$locale}/{$locale}.json"), resource_path("lang/{$locale}.json"));
         File::put(resource_path("lang/{$locale}.json"), $modifiedJson);
     }
 

tests/Feature/InstallLanguageTest.php

@@ -112,7 +112,7 @@ function it_doesnt_modify_config_app_locale_if_pass_no_default_option()
     }
 
     /** @test */
-    function it_install_json_locale_only_with_base_translations()
+    function it_installs_json_locale_only_with_base_translations()
     {
         $this->artisan('lang:add es');
         $expected = <<<JSON
@@ -142,4 +142,84 @@ function it_install_json_locale_only_with_base_translations()
             File::get(resource_path('lang/xx_GB.json'))
         );
     }
+
+    /** @test */
+    function it_installs_json_with_base_plus_discovered_packages_one()
+    {
+        File::put(base_path('composer.json'), $this->buildComposerWithDependencies(
+            ['"laravel/cashier": "^13.5"']
+        ));
+
+        $this->artisan('lang:add es');
+        $expected = <<<JSON
+{
+    "Add Base": "Añadir base",
+    "Cancel both": "Cancelar ambos",
+    "Card cashier": "Tarjeta cashier",
+    "Changes Base": "Cambios base",
+    "Confirm your :amount payment cashier": "Confirme su pago de :amount cashier",
+    "If you already have an account, you may accept this invitation by clicking the button below: base": "Si ya tiene una cuenta, puede aceptar esta invitación haciendo clic en el botón de abajo: base",
+    "Whoops! all": "¡Ups! todo"
+}
+JSON;
+        $this->assertEquals(
+            $expected,
+            File::get(resource_path('lang/es.json'))
+        );
+
+    }
+
+    /** @test */
+    function it_installs_json_with_base_plus_discovered_packages_other()
+    {
+        File::put(base_path('composer.json'), $this->buildComposerWithDependencies(
+            ['"laravel/breeze": "^1.4"']
+        ));
+
+        $this->artisan('lang:add es');
+        $expected = <<<JSON
+{
+    "Add Base": "Añadir base",
+    "Cancel both": "Cancelar ambos",
+    "Changes Base": "Cambios base",
+    "Confirm Password breeze": "Confirmar contraseña breeze",
+    "If you already have an account, you may accept this invitation by clicking the button below: base": "Si ya tiene una cuenta, puede aceptar esta invitación haciendo clic en el botón de abajo: base",
+    "Log in breeze": "Iniciar sesión breeze",
+    "Whoops! all": "¡Ups! todo"
+}
+JSON;
+        $this->assertEquals(
+            $expected,
+            File::get(resource_path('lang/es.json'))
+        );
+
+    }
+
+    /** @test */
+    function it_installs_json_with_base_plus_discovered_packages_mixed()
+    {
+        File::put(base_path('composer.json'), $this->buildComposerWithDependencies(
+            ['"laravel/cashier": "^13.5"', '"laravel/breeze": "^1.4"']
+        ));
+
+        $this->artisan('lang:add es');
+        $expected = <<<JSON
+{
+    "Add Base": "Añadir base",
+    "Cancel both": "Cancelar ambos",
+    "Card cashier": "Tarjeta cashier",
+    "Changes Base": "Cambios base",
+    "Confirm Password breeze": "Confirmar contraseña breeze",
+    "Confirm your :amount payment cashier": "Confirme su pago de :amount cashier",
+    "If you already have an account, you may accept this invitation by clicking the button below: base": "Si ya tiene una cuenta, puede aceptar esta invitación haciendo clic en el botón de abajo: base",
+    "Log in breeze": "Iniciar sesión breeze",
+    "Whoops! all": "¡Ups! todo"
+}
+JSON;
+        $this->assertEquals(
+            $expected,
+            File::get(resource_path('lang/es.json'))
+        );
+
+    }
 }

tests/fixtures/vendor/laravel-lang/lang/source/packages/cashier.json

@@ -1,5 +1,6 @@
 [
     "Cancel both",
+    "Card cashier",
     "Confirm your :amount payment cashier",
     "Whoops! all"
 ]