Turn newSkyBox more agnostic.

[luizfilipe]

• The main objective of this issue is turn newSkyBox more agnostic, in other words receive the textures instead use them fixed inside of the function.
• We can do 2 functions one to handle every side of skybox separated and another to handle a unique file.

[lrpsantiago]

Sure. Actually that's how this should be made, with an "initSkyBox" function, that receive the textures as parameters. I'd like to suggest another thing, in drawSkyBox(), we use some constants to translate the skybox faces according to the camera translation. That constants AND the face's scale should be based on the zFar value of the camera.

[luizfilipe]

Maybe if we develop the TextureSet, we can handle a set of textures like a HashMap in initSkyBox(). i agree with the idea to improve drawSkyBox() with some constants like a SkyBoxTransforms.<CONSTANT_NAME> or then something like Transforms.SkyBox.<CONSTANT_NAME>, but we can open another issue with this improvement.

[luizfilipe]

Or maybe we can try another different approach...
@lrpsantiago what do you think of a usage like this:

SkyBox* sk = newSkyBox(camera);

sk.left = newTexture("left.bmp"):
sk.right = newTexture("right.bmp"):
sk.top = newTexture("top.bmp"):
sk.bottom = newTexture("bottom.bmp"):
sk.front = newTexture("front.bmp"):
sk.back = newTexture("back.bmp"):

sk.load();

also the struct have to be something like that

typedef struct
{
    Object3d* front;
    Object3d* back;
    Object3d* left;
    Object3d* right;
    Object3d* top;
    Object3d* bottom;
    Camera* camera;
    void (*load)();
}SkyBox;

[lrpsantiago]

I don't know if the TextureSet structure is a good idea, it seems too specific, being used only in SkyBox. In my opnion, the best way to do this is passing a instance of Texture for each face, something like:

SkyBox initSkyBox(Texture* front, ... , Texture* bottom);

But, we could pass an array of Texture* as argument to initSkyBox() and then create pre-processor definitions for each face, eg.:

#define SKYBOX_FRONT 0
...
#define SKYBOX_BOTTON 5

SkyBox initSkyBox( Texture** faces );

[luizfilipe]

@lrpsantiago I prefer the other approach that i have told before

SkyBox* sk = newSkyBox(camera);

sk.left = newTexture("left.bmp");
sk.right = newTexture("right.bmp");
sk.top = newTexture("top.bmp");
sk.bottom = newTexture("bottom.bmp");
sk.front = newTexture("front.bmp");
sk.back = newTexture("back.bmp");

//Something like that below to load the skybox
sk.load();
//otherwise
loadSkyBox(sk);

I have only one subject to prefer this instead an array of Textures.

• The order don't have to matter for library user, what your feellings about this?

[lrpsantiago]

Well, on the array approach, that's why we create the definitions, to use something like this:

facesTextures[SKYBOX_FRONT] = newTexture("MyTex.bmp");

Instead:

facesTextures[0] = newTexture("MyTex.bmp");

So the end user doesn't have to worry about the array index. But this is not my favorite way. I'd preffer passing an instance of Texture for each face, because it allow us to load the textures externally, avoiding texture overload.

[luizfilipe]

@lrpsantiago hmm, seems a good approach, but what the best usage that you think?

facesTextures[SKYBOX_LEFT] = newTexture("MyTex.bmp");

or

sk.left = newTexture("left.bmp");