Skip to content

Commit 828f1cf

Browse files
luizgrpluizgrp
committed
Add logcat to verify issue 184664890
1 parent 596d081 commit 828f1cf

File tree

3 files changed

+92
-3
lines changed

3 files changed

+92
-3
lines changed

‎PictureInPictureKotlin/app/src/main/java/com/example/android/pictureinpicture/MainActivity.kt‎

Lines changed: 40 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,17 +16,17 @@
1616

1717
package com.example.android.pictureinpicture
1818

19-
import android.app.PendingIntent
20-
import android.app.PictureInPictureParams
21-
import android.app.RemoteAction
19+
import android.app.*
2220
import android.content.BroadcastReceiver
2321
import android.content.Context
2422
import android.content.Intent
2523
import android.content.IntentFilter
2624
import android.content.res.Configuration
2725
import android.graphics.drawable.Icon
2826
import android.net.Uri
27+
import android.os.Build
2928
import android.os.Bundle
29+
import android.util.Log
3030
import android.util.Rational
3131
import android.view.View
3232
import android.widget.Button
@@ -178,6 +178,7 @@ class MainActivity : AppCompatActivity() {
178178

179179
override fun onCreate(savedInstanceState: Bundle?) {
180180
super.onCreate(savedInstanceState)
181+
registerActivityLifecycleCallbacks()
181182
setContentView(R.layout.activity_main)
182183

183184
// View references
@@ -268,6 +269,42 @@ class MainActivity : AppCompatActivity() {
268269
}
269270
}
270271

272+
private fun registerActivityLifecycleCallbacks() {
273+
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.Q) {
274+
registerActivityLifecycleCallbacks(object : Application.ActivityLifecycleCallbacks {
275+
private val TAG = MainActivity::class.java.simpleName
276+
277+
override fun onActivityCreated(activity: Activity, savedInstanceState: Bundle?) {
278+
Log.d(TAG, "onActivityCreated: [isInPictureInPictureMode=$isInPictureInPictureMode]")
279+
}
280+
281+
override fun onActivityStarted(activity: Activity) {
282+
Log.d(TAG, "onActivityStarted: [isInPictureInPictureMode=$isInPictureInPictureMode]")
283+
}
284+
285+
override fun onActivityResumed(activity: Activity) {
286+
Log.d(TAG, "onActivityResumed: [isInPictureInPictureMode=$isInPictureInPictureMode]")
287+
}
288+
289+
override fun onActivityPaused(activity: Activity) {
290+
Log.d(TAG, "onActivityPaused: [isInPictureInPictureMode=$isInPictureInPictureMode] [isFinishing=$isFinishing]")
291+
}
292+
293+
override fun onActivityStopped(activity: Activity) {
294+
Log.d(TAG, "onActivityStopped: [isInPictureInPictureMode=$isInPictureInPictureMode] [isFinishing=$isFinishing]")
295+
}
296+
297+
override fun onActivitySaveInstanceState(activity: Activity, outState: Bundle) {
298+
Log.d(TAG, "onActivitySaveInstanceState: [isInPictureInPictureMode=$isInPictureInPictureMode]")
299+
}
300+
301+
override fun onActivityDestroyed(activity: Activity) {
302+
Log.d(TAG, "onActivityDestroyed: [isInPictureInPictureMode=$isInPictureInPictureMode]")
303+
}
304+
})
305+
}
306+
}
307+
271308
/**
272309
* Launches [MediaSessionPlaybackActivity] and closes this activity.
273310
*/

‎documents/REPORT.MD‎

Lines changed: 52 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,52 @@
1+
### Scenario: launch player, go to Pip, dismiss Pip (dragging to the bottom)
2+
3+
##### Android 10
4+
```
5+
2021-04-07 14:22:35.434 18884-18884/com.example.android.pictureinpicture D/MainActivity: onActivityStarted: [isInPictureInPictureMode=false]
6+
2021-04-07 14:22:35.438 18884-18884/com.example.android.pictureinpicture D/MainActivity: onActivityResumed: [isInPictureInPictureMode=false]
7+
2021-04-07 14:22:59.436 18884-18884/com.example.android.pictureinpicture D/MainActivity: onActivityPaused: [isInPictureInPictureMode=true] [isFinishing=false]
8+
2021-04-07 14:23:04.868 18884-18884/com.example.android.pictureinpicture D/MainActivity: onActivityStopped: [isInPictureInPictureMode=false] [isFinishing=false]
9+
2021-04-07 14:23:04.898 18884-18884/com.example.android.pictureinpicture D/MainActivity: onActivitySaveInstanceState: [isInPictureInPictureMode=false]
10+
```
11+
12+
##### Android 11
13+
14+
```
15+
2021-04-07 14:24:22.956 10452-10452/com.example.android.pictureinpicture D/MainActivity: onActivityStarted: [isInPictureInPictureMode=false]
16+
2021-04-07 14:24:22.959 10452-10452/com.example.android.pictureinpicture D/MainActivity: onActivityResumed: [isInPictureInPictureMode=false]
17+
2021-04-07 14:24:34.530 10452-10452/com.example.android.pictureinpicture D/MainActivity: onActivityPaused: [isInPictureInPictureMode=true] [isFinishing=false]
18+
2021-04-07 14:24:38.336 10452-10452/com.example.android.pictureinpicture D/MainActivity: onActivityStopped: [isInPictureInPictureMode=true] [isFinishing=false]
19+
2021-04-07 14:24:38.337 10452-10452/com.example.android.pictureinpicture D/MainActivity: onActivitySaveInstanceState: [isInPictureInPictureMode=true]
20+
```
21+
22+
##### Observations:
23+
- in onStop, Android10 reports isInPictureInPictureMode=false whereas Android 11 reports isInPictureInPictureMode=true
24+
25+
26+
### Scenario: launch player, go to Pip, close Pip (with the x button)
27+
Same logs and results from previous scenario.
28+
29+
### Scenario: launch player, go to Pip, lock the device
30+
31+
##### Android 10
32+
```
33+
2021-04-07 14:54:48.415 23945-23945/com.example.android.pictureinpicture D/MainActivity: onActivityStarted: [isInPictureInPictureMode=false]
34+
2021-04-07 14:54:48.416 23945-23945/com.example.android.pictureinpicture D/MainActivity: onActivityResumed: [isInPictureInPictureMode=false]
35+
2021-04-07 14:54:50.705 23945-23945/com.example.android.pictureinpicture D/MainActivity: onActivityPaused: [isInPictureInPictureMode=true] [isFinishing=false]
36+
2021-04-07 14:54:55.116 23945-23945/com.example.android.pictureinpicture D/MainActivity: onActivityStopped: [isInPictureInPictureMode=true] [isFinishing=false]
37+
2021-04-07 14:54:55.117 23945-23945/com.example.android.pictureinpicture D/MainActivity: onActivitySaveInstanceState: [isInPictureInPictureMode=true]
38+
```
39+
40+
##### Android 11
41+
42+
```
43+
2021-04-07 14:59:01.788 8046-8046/com.example.android.pictureinpicture D/MainActivity: onActivityStarted: [isInPictureInPictureMode=false]
44+
2021-04-07 14:59:01.790 8046-8046/com.example.android.pictureinpicture D/MainActivity: onActivityResumed: [isInPictureInPictureMode=false]
45+
2021-04-07 14:59:04.876 8046-8046/com.example.android.pictureinpicture D/MainActivity: onActivityPaused: [isInPictureInPictureMode=true] [isFinishing=false]
46+
2021-04-07 14:59:09.917 8046-8046/com.example.android.pictureinpicture D/MainActivity: onActivityStopped: [isInPictureInPictureMode=true] [isFinishing=false]
47+
2021-04-07 14:59:09.919 8046-8046/com.example.android.pictureinpicture D/MainActivity: onActivitySaveInstanceState: [isInPictureInPictureMode=true]
48+
```
49+
50+
##### Observations:
51+
- no differences between Android 10 and Android 11
52+
- in onStop, Android 10 reports isInPictureInPictureMode=true, but in the scenario where the Pip is dismissed or closed, it returns isInPictureInPictureMode=false in onStop

‎documents/str.webm‎

8.21 MB
Binary file not shown.

0 commit comments

Comments
 (0)