feat(value): Make visitors of XML value types public. (#117)

* feat: Make visitors of XML value types public.

* `cargo clippy`

Author: lukasfri

xmlity/src/value/deserialize.rs

@@ -1,3 +1,4 @@
+//! This module contains the deserialization implementations for the XML value types including visitors.
 use crate::{
     de::{self, DeserializeContext, SeqAccess, Visitor},
     Deserialize, Deserializer, ExpandedName, Prefix, XmlNamespace,
@@ -116,20 +117,28 @@ impl<'de> Deserialize<'de> for XmlValue {
 
 // Text
 
-struct XmlTextVisitor<'v> {
+/// A visitor for deserializing to [`XmlText`].
+pub struct XmlTextVisitor<'v> {
     marker: PhantomData<XmlText>,
     lifetime: PhantomData<&'v ()>,
 }
 
 impl XmlTextVisitor<'_> {
-    fn new() -> Self {
+    /// Creates a new [`XmlTextVisitor`].
+    pub fn new() -> Self {
         Self {
             marker: PhantomData,
             lifetime: PhantomData,
         }
     }
 }
 
+impl Default for XmlTextVisitor<'_> {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl<'v> crate::de::Visitor<'v> for XmlTextVisitor<'v> {
     type Value = XmlText;
 
@@ -174,19 +183,27 @@ impl<'de> Deserialize<'de> for XmlText {
 
 // CData
 
-struct XmlCDataVisitor<'v> {
+/// A visitor for deserializing to [`XmlCData`].
+pub struct XmlCDataVisitor<'v> {
     marker: PhantomData<XmlCData>,
     lifetime: PhantomData<&'v ()>,
 }
 impl XmlCDataVisitor<'_> {
-    fn new() -> Self {
+    /// Creates a new [`XmlCDataVisitor`].
+    pub fn new() -> Self {
         Self {
             marker: PhantomData,
             lifetime: PhantomData,
         }
     }
 }
 
+impl Default for XmlCDataVisitor<'_> {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl<'de> Visitor<'de> for XmlCDataVisitor<'de> {
     type Value = XmlCData;
     fn expecting(&self, formatter: &mut fmt::Formatter) -> fmt::Result {
@@ -212,19 +229,27 @@ impl<'de> Deserialize<'de> for XmlCData {
 
 // Child
 
-struct XmlChildVisitor<'v> {
+/// A visitor for deserializing to [`XmlChild`].
+pub struct XmlChildVisitor<'v> {
     marker: PhantomData<XmlChild>,
     lifetime: PhantomData<&'v ()>,
 }
 impl XmlChildVisitor<'_> {
-    fn new() -> Self {
+    /// Creates a new [`XmlChildVisitor`].
+    pub fn new() -> Self {
         Self {
             marker: PhantomData,
             lifetime: PhantomData,
         }
     }
 }
 
+impl Default for XmlChildVisitor<'_> {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl<'v> crate::de::Visitor<'v> for XmlChildVisitor<'v> {
     type Value = XmlChild;
     fn expecting(&self, formatter: &mut fmt::Formatter) -> fmt::Result {
@@ -290,19 +315,28 @@ impl<'de> de::Deserialize<'de> for XmlChild {
 
 // Element
 
-struct XmlElementVisitor<'v> {
+/// A visitor for deserializing to [`XmlElement`].
+pub struct XmlElementVisitor<'v> {
     marker: PhantomData<XmlElement>,
     lifetime: PhantomData<&'v ()>,
 }
+
 impl XmlElementVisitor<'_> {
-    fn new() -> Self {
+    /// Creates a new [`XmlElementVisitor`].
+    pub fn new() -> Self {
         Self {
             marker: PhantomData,
             lifetime: PhantomData,
         }
     }
 }
 
+impl Default for XmlElementVisitor<'_> {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl<'v> crate::de::Visitor<'v> for XmlElementVisitor<'v> {
     type Value = XmlElement;
     fn expecting(&self, formatter: &mut fmt::Formatter) -> fmt::Result {
@@ -350,20 +384,28 @@ impl<'de> crate::de::Deserialize<'de> for XmlElement {
 
 // Attribute
 
-struct XmlAttributeVisitor<'v> {
+/// A visitor for deserializing to [`XmlAttribute`].
+pub struct XmlAttributeVisitor<'v> {
     marker: PhantomData<XmlAttribute>,
     lifetime: PhantomData<&'v ()>,
 }
 
 impl XmlAttributeVisitor<'_> {
-    fn new() -> Self {
+    /// Creates a new [`XmlAttributeVisitor`].
+    pub fn new() -> Self {
         Self {
             marker: PhantomData,
             lifetime: PhantomData,
         }
     }
 }
 
+impl Default for XmlAttributeVisitor<'_> {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl<'v> crate::de::Visitor<'v> for XmlAttributeVisitor<'v> {
     type Value = XmlAttribute;
     fn expecting(&self, formatter: &mut fmt::Formatter) -> fmt::Result {
@@ -418,20 +460,28 @@ impl<'de, T: Deserialize<'de>> Deserialize<'de> for XmlSeq<T> {
 
 // Processing Instruction
 
-struct XmlProcessingInstructionVisitor<'v> {
+/// A visitor for deserializing to [`XmlProcessingInstruction`].
+pub struct XmlProcessingInstructionVisitor<'v> {
     marker: PhantomData<XmlProcessingInstruction>,
     lifetime: PhantomData<&'v ()>,
 }
 
 impl XmlProcessingInstructionVisitor<'_> {
-    fn new() -> Self {
+    /// Creates a new [`XmlProcessingInstructionVisitor`].
+    pub fn new() -> Self {
         Self {
             marker: PhantomData,
             lifetime: PhantomData,
         }
     }
 }
 
+impl Default for XmlProcessingInstructionVisitor<'_> {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl<'v> crate::de::Visitor<'v> for XmlProcessingInstructionVisitor<'v> {
     type Value = XmlProcessingInstruction;
 
@@ -462,20 +512,28 @@ impl<'de> Deserialize<'de> for XmlProcessingInstruction {
 
 // Xml Decl
 
-struct XmlDeclVisitor<'v> {
+/// A visitor for deserializing to [`XmlDeclVisitor`].
+pub struct XmlDeclVisitor<'v> {
     marker: PhantomData<XmlDecl>,
     lifetime: PhantomData<&'v ()>,
 }
 
 impl XmlDeclVisitor<'_> {
-    fn new() -> Self {
+    /// Creates a new [`XmlDeclVisitor`].
+    pub fn new() -> Self {
         Self {
             marker: PhantomData,
             lifetime: PhantomData,
         }
     }
 }
 
+impl Default for XmlDeclVisitor<'_> {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl<'v> crate::de::Visitor<'v> for XmlDeclVisitor<'v> {
     type Value = XmlDecl;
     fn expecting(&self, formatter: &mut fmt::Formatter) -> fmt::Result {
@@ -510,12 +568,14 @@ impl<'de> Deserialize<'de> for XmlDecl {
 
 // Xml Comment
 
-struct XmlCommentVisitor<'v> {
+/// A visitor for deserializing to [`XmlComment`].
+pub struct XmlCommentVisitor<'v> {
     marker: PhantomData<XmlComment>,
     lifetime: PhantomData<&'v ()>,
 }
 
 impl XmlCommentVisitor<'_> {
+    /// Creates a new [`XmlCommentVisitor`].
     pub fn new() -> Self {
         Self {
             marker: PhantomData,
@@ -524,6 +584,12 @@ impl XmlCommentVisitor<'_> {
     }
 }
 
+impl Default for XmlCommentVisitor<'_> {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl<'v> crate::de::Visitor<'v> for XmlCommentVisitor<'v> {
     type Value = XmlComment;
 
@@ -551,12 +617,14 @@ impl<'de> Deserialize<'de> for XmlComment {
 
 // Xml Doctype
 
-struct XmlDoctypeVisitor<'v> {
+/// A visitor for deserializing to [`XmlDoctype`].
+pub struct XmlDoctypeVisitor<'v> {
     marker: PhantomData<XmlDoctype>,
     lifetime: PhantomData<&'v ()>,
 }
 
 impl XmlDoctypeVisitor<'_> {
+    /// Creates a new [`XmlDoctypeVisitor`].
     pub fn new() -> Self {
         Self {
             marker: PhantomData,
@@ -565,6 +633,12 @@ impl XmlDoctypeVisitor<'_> {
     }
 }
 
+impl Default for XmlDoctypeVisitor<'_> {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl<'v> crate::de::Visitor<'v> for XmlDoctypeVisitor<'v> {
     type Value = XmlDoctype;
 

xmlity/src/value/mod.rs

@@ -18,7 +18,7 @@ use crate::{
     ExpandedName, Prefix,
 };
 
-mod deserialize;
+pub mod deserialize;
 mod deserializer;
 mod serialize;
 mod serializer;