Skip to content

Commit 29c6fcb

Browse files
authored
Merge pull request #1700 from lukeautry/fix/1699
Fix: @response not handle undefined examples properly
2 parents 4b2fa72 + e3600e0 commit 29c6fcb

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

packages/cli/src/metadataGeneration/methodGenerator.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,11 @@ export class MethodGenerator {
197197

198198
return decorators.map(decorator => {
199199
const [name, description, example, produces] = getDecoratorValues(decorator, this.current.typeChecker);
200-
responseExamplesByName[name] = responseExamplesByName[name] ? [...responseExamplesByName[name], example] : [example];
200+
201+
if (example !== undefined) {
202+
responseExamplesByName[name] = responseExamplesByName[name] ? [...responseExamplesByName[name], example] : [example];
203+
}
204+
201205
return {
202206
description: description || '',
203207
examples: responseExamplesByName[name] || undefined,

tests/unit/swagger/definitionsGeneration/metadata.spec.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -177,6 +177,7 @@ describe('Metadata generation', () => {
177177
const unauthResponse = method.responses[2];
178178
expect(unauthResponse.name).to.equal('401');
179179
expect(unauthResponse.description).to.equal('Unauthorized');
180+
expect(unauthResponse.examples).to.be.undefined;
180181

181182
const defaultResponse = method.responses[3];
182183
expect(defaultResponse.name).to.equal('default');

0 commit comments

Comments
 (0)