Skip to content

Commit c146248

Browse files
authored
feat: switch from node 14 to 16 (aws-observability#1118)
* feat: switch nodejs to 16, fix linter * feat: switch nodejs to 16, fix linter for sample app * feat: switch builder to node 16 * feat: update runtimes list
1 parent 9f412c9 commit c146248

File tree

4 files changed

+9
-11
lines changed

4 files changed

+9
-11
lines changed

.github/workflows/ci-nodejs.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
- uses: actions/checkout@v4
2020
- uses: actions/setup-node@v4
2121
with:
22-
node-version: 14
22+
node-version: 16
2323
- uses: actions/cache@v4
2424
with:
2525
path: ~/.npm

.github/workflows/release-layer-nodejs.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020

2121
- uses: actions/setup-node@v4
2222
with:
23-
node-version: 14
23+
node-version: 16
2424

2525
- name: Build
2626
run: |
@@ -71,7 +71,7 @@ jobs:
7171
layer-name: opentelemetry-nodejs
7272
component-version: ${{needs.build-layer.outputs.NODEJS_VERSION}}
7373
# architecture:
74-
runtimes: nodejs14.x nodejs16.x nodejs18.x
74+
runtimes: nodejs16.x nodejs18.x nodejs20.x
7575
release-group: prod
7676
aws_region: ${{ matrix.aws_region }}
7777
secrets: inherit

nodejs/packages/layer/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
"repository": "open-telemetry/opentelemetry-lambda",
77
"scripts": {
88
"clean": "rimraf build/*",
9-
"lint": "eslint . --ext .ts",
10-
"lint:fix": "eslint . --ext .ts --fix",
9+
"lint": "ESLINT_USE_FLAT_CONFIG=false eslint . --ext .ts",
10+
"lint:fix": "ESLINT_USE_FLAT_CONFIG=false eslint . --ext .ts --fix",
1111
"prepare": "npm run compile",
1212
"compile": "tsc -p .",
1313
"postcompile": "copyfiles 'node_modules/**' build/workspace/nodejs && copyfiles -f 'scripts/*' build/workspace && copyfiles -f 'build/src/*' build/workspace && cd build/workspace && bestzip ../layer.zip *"
@@ -23,7 +23,7 @@
2323
"author": "OpenTelemetry Authors",
2424
"license": "Apache-2.0",
2525
"engines": {
26-
"node": ">=14.0.0"
26+
"node": ">=16.0.0"
2727
},
2828
"dependencies": {
2929
"@opentelemetry/api": "^1.7.0",

nodejs/sample-apps/aws-sdk/package.json

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@
88
"repository": "open-telemetry/opentelemetry-lambda",
99
"scripts": {
1010
"clean": "rimraf build/*",
11-
"lint": "eslint . --ext .ts",
12-
"lint:fix": "eslint . --ext .ts --fix",
11+
"lint": "ESLINT_USE_FLAT_CONFIG=false eslint . --ext .ts",
12+
"lint:fix": "ESLINT_USE_FLAT_CONFIG=false eslint . --ext .ts --fix",
1313
"precompile": "tsc --version",
1414
"prepare": "npm run compile",
1515
"compile": "tsc -p .",
@@ -26,7 +26,7 @@
2626
"author": "OpenTelemetry Authors",
2727
"license": "Apache-2.0",
2828
"engines": {
29-
"node": ">=14.0.0"
29+
"node": ">=16.0.0"
3030
},
3131
"files": [
3232
"build/src/**/*.js",
@@ -42,8 +42,6 @@
4242
"copyfiles": "2.4.1",
4343
"rimraf": "5.0.5",
4444
"ts-node": "10.9.2",
45-
"tslint-consistent-codestyle": "1.16.0",
46-
"tslint-microsoft-contrib": "6.2.0",
4745
"typescript": "5.3.3"
4846
},
4947
"dependencies": {

0 commit comments

Comments
 (0)