Skip to content

Commit 6ae6225

Browse files
authored
Revert "Fix: Unable to run ADOT Python unit tests with latest Tox release (aws-observability#521)" (aws-observability#523)
This reverts commit ffa291c, reversing changes made to 533fafd. *Issue #, if available:* App Signals E2E tests are failing. *Description of changes:* Revert the previous Tox related change. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
1 parent ffa291c commit 6ae6225

File tree

3 files changed

+7
-13
lines changed

3 files changed

+7
-13
lines changed

.github/actions/set_up/action.yml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,7 @@ runs:
2727

2828
- name: Install tox
2929
shell: bash
30-
run: |
31-
pip install tox==4.30.3
30+
run: pip install tox==3.27.1 tox-factor
3231

3332
- name: Cache tox environment
3433
# Preserves .tox directory between runs for faster installs
@@ -42,7 +41,4 @@ runs:
4241
- name: Run unit tests/benchmarks with tox
4342
if: ${{ inputs.run_unit_tests == 'true' }}
4443
shell: bash
45-
run: |
46-
ENV_NAME="${{ inputs.python_version }}-test-${{ inputs.package_name }}"
47-
echo "Running tox env: $ENV_NAME"
48-
tox -e "$ENV_NAME" -- -ra
44+
run: tox -f ${{ inputs.python_version }}-${{ inputs.package_name }} -- -ra

CHANGELOG.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,5 +17,3 @@ If your change does not need a CHANGELOG entry, add the "skip changelog" label t
1717
([#497](https://github.com/aws-observability/aws-otel-python-instrumentation/pull/497))
1818
- Fix timeout handling for exceeded deadline in retry logic in OTLPAwsLogsExporter
1919
([#501](https://github.com/aws-observability/aws-otel-python-instrumentation/pull/501))
20-
- Fix: Unable to run ADOT Python unit tests with latest Tox release
21-
([#521](https://github.com/aws-observability/aws-otel-python-instrumentation/pull/521))

tox.ini

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,11 @@ commands_pre =
3535
; cases but it saves a lot of boilerplate in this file.
3636
test: pip install botocore
3737
test: pip install gevent
38-
test: pip install opentelemetry-api[test]@{env:CORE_REPO}\#egg=opentelemetry-api&subdirectory=opentelemetry-api
39-
test: pip install opentelemetry-sdk[test]@{env:CORE_REPO}\#egg=opentelemetry-sdk&subdirectory=opentelemetry-sdk
40-
test: pip install opentelemetry-instrumentation[test]@{env:CONTRIB_REPO}\#egg=opentelemetry-instrumentation&subdirectory=opentelemetry-instrumentation
41-
test: pip install opentelemetry-exporter-otlp[test]@{env:CORE_REPO}\#egg=opentelemetry-exporter-otlp&subdirectory=exporter/opentelemetry-exporter-otlp
42-
test: pip install opentelemetry-test-utils@{env:CORE_REPO}\#egg=opentelemetry-test-utils&subdirectory=tests/opentelemetry-test-utils
38+
test: pip install "opentelemetry-api[test] @ {env:CORE_REPO}#egg=opentelemetry-api&subdirectory=opentelemetry-api"
39+
test: pip install "opentelemetry-sdk[test] @ {env:CORE_REPO}#egg=opentelemetry-sdk&subdirectory=opentelemetry-sdk"
40+
test: pip install "opentelemetry-instrumentation[test] @ {env:CONTRIB_REPO}#egg=opentelemetry-instrumentation&subdirectory=opentelemetry-instrumentation"
41+
test: pip install "opentelemetry-exporter-otlp[test] @ {env:CORE_REPO}#egg=opentelemetry-exporter-otlp&subdirectory=exporter/opentelemetry-exporter-otlp"
42+
test: pip install "opentelemetry-test-utils @ {env:CORE_REPO}#egg=opentelemetry-test-utils&subdirectory=tests/opentelemetry-test-utils"
4343
aws-opentelemetry-distro: pip install {toxinidir}/aws-opentelemetry-distro
4444

4545
commands =

0 commit comments

Comments
 (0)