Skip to content

Commit 835812e

Browse files
committed
fix: use FLY_APP_NAME secret for deployment
Prevents committing the Fly.io app name to the repository. Deployment now uses -a flag with the app name from secrets.
1 parent 2c02338 commit 835812e

File tree

2 files changed

+13
-2
lines changed

2 files changed

+13
-2
lines changed

.github/workflows/release-please.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,6 @@ jobs:
5858
uses: superfly/flyctl-actions/setup-flyctl@master
5959

6060
- name: Deploy to Fly.io
61-
run: flyctl deploy --env APP_VERSION=${{ github.ref_name }} --build-arg APP_VERSION=${{ github.ref_name }} --remote-only
61+
run: flyctl deploy -a ${{ secrets.FLY_APP_NAME }} --env APP_VERSION=${{ github.ref_name }} --build-arg APP_VERSION=${{ github.ref_name }} --remote-only
6262
env:
6363
FLY_API_TOKEN: ${{ secrets.FLY_API_TOKEN }}

docs/Release Process.md

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,10 +151,21 @@ Current version is managed in:
151151

152152
## Configuration Files
153153

154-
- **`.github/workflows/release-please.yml`** - GitHub Actions workflow for automated releases
154+
- **`.github/workflows/release-please.yml`** - GitHub Actions workflow for automated releases and deployment
155155
- **`.github/release-please-config.json`** - Release-please configuration
156156
- **`.github/.release-please-manifest.json`** - Version tracking
157157

158+
## GitHub Secrets Required
159+
160+
For automatic deployment to Fly.io, you need to configure:
161+
162+
- **`FLY_API_TOKEN`** - API token from Fly.io for deployments
163+
- Create at: [fly.io/user/personal_access_tokens](https://fly.io/user/personal_access_tokens)
164+
- Add to: Repository Settings → Secrets and variables → Actions
165+
- **`FLY_APP_NAME`** - Your Fly.io app name
166+
- Find with: `flyctl apps list`
167+
- Add to: Repository Settings → Secrets and variables → Actions
168+
158169
## Troubleshooting
159170

160171
### Release PR not created

0 commit comments

Comments
 (0)