Rename responder status to something clearer

Author: lukeredpath

CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+## 0.3.0
+
+### Changed
+
+* Remove RunLoop tick when updating first responder state
+* Replace `isEditing` binding with `firstResponderState` binding.
+
 ## 0.2.0
 
 ### Added

Demo Project/ResponsiveTextFieldDemo/ContentView.swift

@@ -17,10 +17,10 @@ struct ContentView: View {
     var password: String = ""
 
     @State
-    var emailResponderState: ResponsiveTextField.FirstResponderState = .become
+    var emailResponderState: ResponsiveTextField.FirstResponderState = .shouldBecomeFirstResponder
 
     @State
-    var passwordResponderState: ResponsiveTextField.FirstResponderState = .resigned
+    var passwordResponderState: ResponsiveTextField.FirstResponderState = .notFirstResponder
 
     @State
     var isEnabled: Bool = true
@@ -30,15 +30,23 @@ struct ContentView: View {
 
     var isEditingEmail: Binding<Bool> {
         Binding(
-            get: { emailResponderState == .current },
-            set: { emailResponderState = $0 ? .become : .resign }
+            get: { emailResponderState == .isFirstResponder },
+            set: {
+                emailResponderState = $0
+                    ? .shouldBecomeFirstResponder
+                    : .shouldResignFirstResponder
+            }
         )
     }
 
     var isEditingPassword: Binding<Bool> {
         Binding(
-            get: { passwordResponderState == .current },
-            set: { passwordResponderState = $0 ? .become : .resign }
+            get: { passwordResponderState == .isFirstResponder },
+            set: {
+                passwordResponderState = $0
+                    ? .shouldBecomeFirstResponder
+                    : .shouldResignFirstResponder
+            }
         )
     }
 
@@ -50,7 +58,7 @@ struct ContentView: View {
                     text: $email,
                     firstResponderState: $emailResponderState.animation(),
                     configuration: .email,
-                    handleReturn: { passwordResponderState = .become }
+                    handleReturn: { passwordResponderState = .shouldBecomeFirstResponder }
                 )
                 .responsiveKeyboardReturnType(.next)
                 .responsiveTextFieldTextColor(.blue)
@@ -65,10 +73,10 @@ struct ContentView: View {
                         firstResponderState: $passwordResponderState.animation(),
                         isSecure: hidePassword,
                         configuration: .combine(.password, .lastOfChain),
-                        handleReturn: { passwordResponderState = .resign },
+                        handleReturn: { passwordResponderState = .shouldResignFirstResponder },
                         handleDelete: {
                             if $0.isEmpty {
-                                emailResponderState = .become
+                                emailResponderState = .shouldBecomeFirstResponder
                             }
                         }
                     )

Sources/ResponsiveTextField/ResponsiveTextField.swift

@@ -109,10 +109,10 @@ public struct ResponsiveTextField {
     }
 
     public enum FirstResponderState: Equatable {
-        case resigned
-        case become
-        case current
-        case resign
+        case notFirstResponder
+        case shouldBecomeFirstResponder
+        case isFirstResponder
+        case shouldResignFirstResponder
     }
 }
 
@@ -154,9 +154,9 @@ extension ResponsiveTextField: UIViewRepresentable {
         uiView.font = font
 
         switch (uiView.isFirstResponder, firstResponderState.wrappedValue) {
-        case (true, .resign):
+        case (true, .shouldResignFirstResponder):
             uiView.resignFirstResponder()
-        case (false, .become):
+        case (false, .shouldBecomeFirstResponder):
             uiView.becomeFirstResponder()
         default:
             break
@@ -179,11 +179,11 @@ extension ResponsiveTextField: UIViewRepresentable {
         }
 
         public func textFieldDidBeginEditing(_ textField: UITextField) {
-            parent.skippingViewUpdates { self.firstResponderState = .current }
+            parent.skippingViewUpdates { self.firstResponderState = .isFirstResponder }
         }
 
         public func textFieldDidEndEditing(_ textField: UITextField) {
-            parent.skippingViewUpdates { self.firstResponderState = .resigned }
+            parent.skippingViewUpdates { self.firstResponderState = .notFirstResponder }
         }
 
         public func textFieldShouldReturn(_ textField: UITextField) -> Bool {
@@ -321,7 +321,7 @@ struct ResponsiveTextField_Previews: PreviewProvider {
         var text: String = ""
 
         @State
-        var firstResponderState: ResponsiveTextField.FirstResponderState = .resigned
+        var firstResponderState: ResponsiveTextField.FirstResponderState = .shouldBecomeFirstResponder
 
         var body: some View {
             ResponsiveTextField(

Tests/ResponsiveTextFieldTests/ResponsiveTextFieldTests.swift

@@ -15,7 +15,7 @@ final class ResponsiveTextFieldTests: XCTestCase {
             matching: ResponsiveTextField(
                 placeholder: "Placeholder Text",
                 text: .constant(""),
-                firstResponderState: .constant(.resigned),
+                firstResponderState: .constant(.notFirstResponder),
                 isSecure: false,
                 configuration: .empty
             ).padding(),
@@ -28,7 +28,7 @@ final class ResponsiveTextFieldTests: XCTestCase {
             matching: ResponsiveTextField(
                 placeholder: "Placeholder Text",
                 text: .constant("Textfield with some text"),
-                firstResponderState: .constant(.resigned),
+                firstResponderState: .constant(.notFirstResponder),
                 isSecure: false,
                 configuration: .empty
             ).padding(),
@@ -41,7 +41,7 @@ final class ResponsiveTextFieldTests: XCTestCase {
             matching: ResponsiveTextField(
                 placeholder: "Placeholder Text",
                 text: .constant("ssh this is top secret"),
-                firstResponderState: .constant(.resigned),
+                firstResponderState: .constant(.notFirstResponder),
                 isSecure: true,
                 configuration: .empty
             ).padding(),
@@ -54,7 +54,7 @@ final class ResponsiveTextFieldTests: XCTestCase {
             matching: ResponsiveTextField(
                 placeholder: "Placeholder Text",
                 text: .constant("Textfield with some text"),
-                firstResponderState: .constant(.resigned),
+                firstResponderState: .constant(.notFirstResponder),
                 isSecure: false,
                 configuration: .empty
             )
@@ -70,7 +70,7 @@ final class ResponsiveTextFieldTests: XCTestCase {
             matching: ResponsiveTextField(
                 placeholder: "Placeholder Text",
                 text: .constant("Textfield with some text"),
-                firstResponderState: .constant(.resigned),
+                firstResponderState: .constant(.notFirstResponder),
                 isSecure: false,
                 configuration: .empty
             )
@@ -83,7 +83,7 @@ final class ResponsiveTextFieldTests: XCTestCase {
             matching: ResponsiveTextField(
                 placeholder: "Placeholder Text",
                 text: .constant("Textfield with some text"),
-                firstResponderState: .constant(.resigned),
+                firstResponderState: .constant(.notFirstResponder),
                 isSecure: false,
                 configuration: .empty
             )