Skip to content

Bug: games with byte 14 & 15 in cartridge header won't load #430

@bgevko

Description

@bgevko

Describe the issue

When header 14 or 15 are set, emulator auto-refuses the game. Legitimate games like SMB3 are not able to load because of this.

To Reproduce

SMB2 and SMB3 have this problem, but others may have it. I checked out the header in Mesen and byte 15 was set for SMB 3.

Expected behavior

In tetanes_core/src/cart.rs, in pub fn load, this line filters out legitimate titles:

            if header[14] > 0 || header[15] > 0 {
                return Err(Error::InvalidHeader {
                    byte: 14,
                    value: header[14],
                    message: "unrecognized data found at header offsets 14-15".to_string(),
                });
            }

Removing it fixes the issue, and SMB games load as expected.

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingtetanes-coreChange related to tetanes-core

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions