Add recommended type-checking ESLint rules

Author: lumaxis

.eslintrc.json

@@ -2,11 +2,13 @@
 	"root": true,
 	"extends": [
 		"eslint:recommended",
-		"plugin:@typescript-eslint/recommended"
+		"plugin:@typescript-eslint/recommended",
+		"plugin:@typescript-eslint/recommended-requiring-type-checking"
 	],
 	"parser": "@typescript-eslint/parser",
 	"parserOptions": {
 		"ecmaVersion": 6,
+		"project": "./tsconfig.json",
 		"sourceType": "module"
 	},
 	"plugins": ["@typescript-eslint"],

src/extension.ts

@@ -3,17 +3,17 @@ import { generateSnippet } from './lib/textHelpers';
 
 export function activate(context: ExtensionContext): void {
 	context.subscriptions.push(
-		commands.registerTextEditorCommand('snippet-copy.copySnippet', async (editor) => {
+		commands.registerTextEditorCommand('snippet-copy.copySnippet', (editor) => {
 			const snippet = generateSnippet(editor.document, editor.selections, false);
 
-			await env.clipboard.writeText(snippet);
+			void env.clipboard.writeText(snippet);
 		})
 	);
 	context.subscriptions.push(
-		commands.registerTextEditorCommand('snippet-copy.copySnippetAsMarkdownCodeBlock', async (editor) => {
+		commands.registerTextEditorCommand('snippet-copy.copySnippetAsMarkdownCodeBlock', (editor) => {
 			const snippet = generateSnippet(editor.document, editor.selections, true);
 
-			await env.clipboard.writeText(snippet);
+			void env.clipboard.writeText(snippet);
 		})
 	);
 }

src/test/runTest.ts

@@ -1,7 +1,7 @@
 import * as path from 'path';
-
 import { runTests } from 'vscode-test';
 
+
 async function main() {
 	try {
 		// The folder containing the Extension Manifest package.json
@@ -20,4 +20,5 @@ async function main() {
 	}
 }
 
+// eslint-disable-next-line @typescript-eslint/no-floating-promises
 main();

src/test/suite/index.ts

@@ -1,6 +1,6 @@
-import * as path from 'path';
-import * as Mocha from 'mocha';
 import * as glob from 'glob';
+import * as Mocha from 'mocha';
+import * as path from 'path';
 
 export function run(): Promise<void> {
 	// Create the mocha test
@@ -12,7 +12,7 @@ export function run(): Promise<void> {
 	const testsRoot = path.resolve(__dirname, '..');
 
 	return new Promise((c, e) => {
-		glob('**/**.test.js', { cwd: testsRoot }, async (err, files) => {
+		glob('**/**.test.js', { cwd: testsRoot }, (err, files) => {
 			if (err) {
 				return e(err);
 			}
@@ -22,7 +22,6 @@ export function run(): Promise<void> {
 
 			try {
 				// Run the mocha test
-				await mocha.loadFilesAsync();
 				mocha.run(failures => {
 					if (failures > 0) {
 						e(new Error(`${failures} tests failed.`));

src/test/suite/lib/documentHelpers.test.ts

@@ -28,7 +28,7 @@ describe('Document Helpers', function () {
 		});
 	});
 
-	context('minimumIndentationLevelForLineIndexes', async () => {
+	context('minimumIndentationLevelForLineIndexes', () => {
 		it('calculates the correct minimum indentation level for a single line', () => {
 			assert.equal(minimumIndentationForLineIndexes(document, [3]), 6);
 		});
@@ -38,7 +38,7 @@ describe('Document Helpers', function () {
 		});
 	});
 
-	context('contentOfLinesWithAdjustedIndentation', async () => {
+	context('contentOfLinesWithAdjustedIndentation', () => {
 		it('returns multiline text with the indentation adjusted correctly', () => {
 			assert.equal(contentOfLinesWithAdjustedIndentation(document, [2, 3, 4], 4), 'if (aValue) {\n  console.log(`Doing something with ${aValue}!`);\n}');
 		});
@@ -68,7 +68,7 @@ describe('Document Helpers', function () {
 	});
 
 	context('endOfLineCharacter', () => {
-		it('correctly returns LF', async () => {
+		it('correctly returns LF', () => {
 			assert.equal(endOfLineCharacter(document), '\n');
 		});