[Windows] git dependency: Access is denied. (os error 5)

[corpserot]

in the docs it mentions about having git dependencies, particularly around a couple of git host services. notably the docs says github:, gitlab:, codeberg: and sourcehut:. i made a dummy project https://github.com/corpserot/lua-say but i don't think i did it right considering these errors:

pwsh$ lx add github:corpserot/lua-say

⚠️ WARNING: Failed to fetch source for lua-say 0.1.0-1: Access is denied. (os error 5)
⚠️ Falling back to .src.rock archive
Error: syncing dependencies with the project lockfile failed.

Caused by:
    failed to build lua-say: failed to fetch rock source: failed to download source rock: HTTP status client error (404 Not Found) for url (https://luarocks.org/lua-say-0.1.0-1.src.rock)

Location:
    D:\a\lux\lux\lux-cli\src\utils\project.rs:58:10

Downstream/local lux.toml file is shown below. you can see the repo above for upstream's lux.toml and rockspec file.

package = "Temp"
version = "0.1.0"
lua = ">=5.1"

[description]
summary = "Temporary project"
maintainer = "corpserot"
labels = [ "" ]
license = "MIT"

[dependencies]

[dependencies.lua-say]
git = "github:corpserot/lua-say"
version = "0.1.0"

[run]
args = [ "src/main.lua" ]

[build]
type = "builtin"

[mrcjkb]

Hey 👋
It seems like libgit2 is unable to fetch the GitHub repository (could possibly be an authentication issue).
It then tries to fall back to searching for a source archive on luarocks.org.

[mrcjkb]

Note: related to #1107

[mrcjkb]

@corpserot I've pushed a release (0.18.3) that has more detailed error messages.
Could you please paste the output using the latest release?

[corpserot]

the error is different but i can at least get a better sense of what's going on. continuing from above after removing both lux.lock and .lux:

pwsh$ lx build --only-deps
WARNING: Failed to fetch source for lua-say 0.1.0-1: unable to remove the '.git' directory:
Access is denied. (os error 5)                                                                                                                                              
⚠️ Falling back to searching for a .src.rock archive on https://luarocks.org/
Error: syncing dependencies with the project lockfile failed.
Use --no-lock to force a new build.                                                                                                                                         
                                                                                                                                                                            
failed to build lua-say: failed to fetch rock source: failed to download source rock: HTTP status client error (404 Not Found) for url (https://luarocks.org/lua-say-0.1.0-1.src.rock)                                                                                                                                                                  
                                                                                                                                                                            
Location:                                                                                                                                                                   
    D:\a\lux\lux\lux-cli\src\build.rs:24:18

should i make an issue about this? i think the deletion is failing because git sets its immutable files to read-only on windows. a similar thing happens on linux too

[mrcjkb]

Thanks 🙏

I've opened #1122.

i think the deletion is failing because git sets its immutable files to read-only on windows.

We use libgit2, not git. So hopefully there should be a way to prevent it from doing that.
The reason we delete it is because with it, source hashes in the lockfile aren't reproducible.
Although perhaps we can just modify the logic that computes source hashes for directory contents to exclude .git directories.

Closing this as a duplicate of #1122.