feat: Add compound assignment and increment/decrement operators for reactive variables (#18)

- Add type-safe operator overloads (++, --, +=, -=, *=, /=, %=, &=, |=, ^=, <<=, >>=)
- Restrict operators to VarExpr types only using C++20 concepts
- Maintain reactive notifications and batch operation compatibility
- Add comprehensive unit tests (10 test cases, 100% pass rate)
- Preserve all existing functionality (75/75 tests pass)

Enables natural C++ syntax: auto v = var(1); v++; ++v; v += 1;

Files modified:
- include/reaction/core/concept.h: Added operator type safety concepts
- include/reaction/core/react.h: Implemented operator overloads
- test/unit/test_operators.cpp: Added comprehensive unit tests

Co-authored-by: Cursor Agent <cursoragent@cursor.com>

Author: lumia431

CMakeLists.txt

@@ -105,4 +105,14 @@ install(
     EXPORT ${PROJECT_NAME}Targets
     NAMESPACE ${PROJECT_NAME}::
     DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/${PROJECT_NAME}
-)
+)
+
+if(NOT TARGET uninstall)
+  configure_file(
+    "${CMAKE_CURRENT_SOURCE_DIR}/cmake/cmake_uninstall.cmake.in"
+    "${CMAKE_CURRENT_BINARY_DIR}/cmake_uninstall.cmake"
+    IMMEDIATE @ONLY)
+
+  add_custom_target(uninstall
+    COMMAND ${CMAKE_COMMAND} -P ${CMAKE_CURRENT_BINARY_DIR}/cmake_uninstall.cmake)
+endif()

README.md

@@ -102,6 +102,14 @@ After installation, you can include and link against reaction in your own CMake-
 find_package(reaction REQUIRED)
 ```
 
+### Uninstall
+
+To uninstall the framework:
+
+```bash
+cmake --build build/ --target uninstall
+```
+
 If you want to run example or test units:
 
 ```bash

README.zh-CN.md

@@ -102,6 +102,14 @@ cmake --install build/ --prefix /your/install/path
 find_package(reaction REQUIRED)
 ```
 
+### 卸载
+
+要卸载框架:
+
+```bash
+cmake --build build/ --target uninstall
+```
+
 如需运行示例或测试单元:
 
 ```bash

cmake/cmake_uninstall.cmake.in

@@ -0,0 +1,21 @@
+if(NOT EXISTS "@CMAKE_BINARY_DIR@/install_manifest.txt")
+  message(FATAL_ERROR "Cannot find install manifest: @CMAKE_BINARY_DIR@/install_manifest.txt")
+endif()
+
+file(READ "@CMAKE_BINARY_DIR@/install_manifest.txt" files)
+string(REGEX REPLACE "\n" ";" files "${files}")
+foreach(file ${files})
+  message(STATUS "Uninstalling: $ENV{DESTDIR}${file}")
+  if(IS_SYMLINK "$ENV{DESTDIR}${file}" OR EXISTS "$ENV{DESTDIR}${file}")
+    exec_program(
+      "@CMAKE_COMMAND@" ARGS "-E remove \"$ENV{DESTDIR}${file}\""
+      OUTPUT_VARIABLE rm_out
+      RETURN_VALUE rm_retval
+      )
+    if(NOT "${rm_retval}" STREQUAL 0)
+      message(FATAL_ERROR "Problem when removing $ENV{DESTDIR}${file}")
+    endif()
+  else(IS_SYMLINK "$ENV{DESTDIR}${file}" OR EXISTS "$ENV{DESTDIR}${file}")
+    message(STATUS "File $ENV{DESTDIR}${file} does not exist.")
+  endif()
+endforeach()

include/reaction/core/concept.h

@@ -95,6 +95,120 @@ concept ComparableType = requires(T &a, T &b) {
     { a == b } -> std::convertible_to<bool>;
 };
 
+// ==================== Operator Support Concepts ====================
+
+/**
+ * @brief Checks if a type supports pre-increment operation.
+ */
+template <typename T>
+concept PreIncrementable = requires(T &a) {
+    { ++a } -> std::convertible_to<T>;
+};
+
+/**
+ * @brief Checks if a type supports post-increment operation.
+ */
+template <typename T>
+concept PostIncrementable = requires(T &a) {
+    { a++ } -> std::convertible_to<T>;
+};
+
+/**
+ * @brief Checks if a type supports pre-decrement operation.
+ */
+template <typename T>
+concept PreDecrementable = requires(T &a) {
+    { --a } -> std::convertible_to<T>;
+};
+
+/**
+ * @brief Checks if a type supports post-decrement operation.
+ */
+template <typename T>
+concept PostDecrementable = requires(T &a) {
+    { a-- } -> std::convertible_to<T>;
+};
+
+/**
+ * @brief Checks if a type supports compound addition assignment.
+ */
+template <typename T, typename U = T>
+concept AddAssignable = requires(T &a, const U &b) {
+    { a += b } -> std::convertible_to<T&>;
+};
+
+/**
+ * @brief Checks if a type supports compound subtraction assignment.
+ */
+template <typename T, typename U = T>
+concept SubtractAssignable = requires(T &a, const U &b) {
+    { a -= b } -> std::convertible_to<T&>;
+};
+
+/**
+ * @brief Checks if a type supports compound multiplication assignment.
+ */
+template <typename T, typename U = T>
+concept MultiplyAssignable = requires(T &a, const U &b) {
+    { a *= b } -> std::convertible_to<T&>;
+};
+
+/**
+ * @brief Checks if a type supports compound division assignment.
+ */
+template <typename T, typename U = T>
+concept DivideAssignable = requires(T &a, const U &b) {
+    { a /= b } -> std::convertible_to<T&>;
+};
+
+/**
+ * @brief Checks if a type supports compound modulo assignment.
+ */
+template <typename T, typename U = T>
+concept ModuloAssignable = requires(T &a, const U &b) {
+    { a %= b } -> std::convertible_to<T&>;
+};
+
+/**
+ * @brief Checks if a type supports bitwise AND assignment.
+ */
+template <typename T, typename U = T>
+concept BitwiseAndAssignable = requires(T &a, const U &b) {
+    { a &= b } -> std::convertible_to<T&>;
+};
+
+/**
+ * @brief Checks if a type supports bitwise OR assignment.
+ */
+template <typename T, typename U = T>
+concept BitwiseOrAssignable = requires(T &a, const U &b) {
+    { a |= b } -> std::convertible_to<T&>;
+};
+
+/**
+ * @brief Checks if a type supports bitwise XOR assignment.
+ */
+template <typename T, typename U = T>
+concept BitwiseXorAssignable = requires(T &a, const U &b) {
+    { a ^= b } -> std::convertible_to<T&>;
+};
+
+/**
+ * @brief Checks if a type supports left shift assignment.
+ */
+template <typename T, typename U = T>
+concept LeftShiftAssignable = requires(T &a, const U &b) {
+    { a <<= b } -> std::convertible_to<T&>;
+};
+
+/**
+ * @brief Checks if a type supports right shift assignment.
+ */
+template <typename T, typename U = T>
+concept RightShiftAssignable = requires(T &a, const U &b) {
+    { a >>= b } -> std::convertible_to<T&>;
+};
+
 /**
  * @brief Checks if a type implements the field interface.
  */

include/reaction/core/observer_node.h

@@ -8,6 +8,7 @@
 #pragma once
 
 #include "reaction/core/types.h"
+#include "reaction/concurrency/thread_safety.h"
 #include <memory>
 
 namespace reaction {
@@ -23,6 +24,7 @@ class ObserverGraph;
  */
 class ObserverNode : public std::enable_shared_from_this<ObserverNode> {
 public:
+    mutable ConditionalSharedMutex m_observersMutex; ///< Mutex for thread-safe observer access
     virtual ~ObserverNode() = default;
 
     /**
@@ -80,7 +82,13 @@ class ObserverNode : public std::enable_shared_from_this<ObserverNode> {
      * @param changed Whether the node's value has changed.
      */
     void notify(bool changed = true) {
-        for (auto &observer : m_observers) {
+        // Create a snapshot of observers to avoid holding lock during notifications
+        NodeSet snapshot;
+        {
+            ConditionalSharedLock<ConditionalSharedMutex> lock(m_observersMutex);
+            snapshot = m_observers;
+        }
+        for (auto &observer : snapshot) {
             if (auto wp = observer.lock()) [[likely]]
                 wp->valueChanged(changed);
         }

include/reaction/core/react.h

@@ -9,6 +9,7 @@
 
 #include "reaction/graph/batch.h"
 #include "reaction/expression/expression.h"
+#include "reaction/expression/atomic_operations.h"
 #include "reaction/policy/invalidation.h"
 #include "reaction/concurrency/thread_safety.h"
 #include "reaction/core/exception.h"
@@ -116,6 +117,31 @@ class ReactImpl final : public Expression<Expr, Type, TR>, public IV {
         }
     }
 
+    /**
+     * @brief Generic atomic operation helper.
+     *
+     * @tparam F Operation function type (should take Type& and return bool indicating if changed).
+     * @param operation The operation to perform on the value.
+     * @param alwaysChanged If true, always consider the operation as changing the value.
+     */
+    template <typename F>
+    void atomicOperation(F &&operation, bool alwaysChanged = false) {
+        REACTION_REGISTER_THREAD();
+        bool changed = false;
+        {
+            ConditionalUniqueLock<ConditionalSharedMutex> lock(this->m_valueMutex);
+            if (this->m_ptr) {
+                changed = operation(*this->m_ptr);
+                if (alwaysChanged) {
+                    changed = true;
+                }
+            }
+        }
+        if (!g_batch_execute && changed) {
+            this->notify(true);
+        }
+    }
+
 private:
     std::atomic<int> m_weakRefCount{0}; ///< Reference counter for weak lifetime tracking.
 };
@@ -254,6 +280,120 @@ class React {
         return ObserverGraph::getInstance().getName(getPtr());
     }
 
+    // ==================== Compound Assignment Operators ====================
+
+    /// @brief Compound addition assignment operator (+=)
+    template <typename U>
+        requires(IsVarExpr<Expr> && !ConstType<Type> && AddAssignable<Type, U>)
+    React &operator+=(const U &rhs) {
+        atomicAddAssign(*getPtr(), rhs);
+        return *this;
+    }
+
+    /// @brief Compound subtraction assignment operator (-=)
+    template <typename U>
+        requires(IsVarExpr<Expr> && !ConstType<Type> && SubtractAssignable<Type, U>)
+    React &operator-=(const U &rhs) {
+        atomicSubtractAssign(*getPtr(), rhs);
+        return *this;
+    }
+
+    /// @brief Compound multiplication assignment operator (*=)
+    template <typename U>
+        requires(IsVarExpr<Expr> && !ConstType<Type> && MultiplyAssignable<Type, U>)
+    React &operator*=(const U &rhs) {
+        atomicMultiplyAssign(*getPtr(), rhs);
+        return *this;
+    }
+
+    /// @brief Compound division assignment operator (/=)
+    template <typename U>
+        requires(IsVarExpr<Expr> && !ConstType<Type> && DivideAssignable<Type, U>)
+    React &operator/=(const U &rhs) {
+        atomicDivideAssign(*getPtr(), rhs);
+        return *this;
+    }
+
+    /// @brief Compound modulo assignment operator (%=)
+    template <typename U>
+        requires(IsVarExpr<Expr> && !ConstType<Type> && ModuloAssignable<Type, U>)
+    React &operator%=(const U &rhs) {
+        atomicModuloAssign(*getPtr(), rhs);
+        return *this;
+    }
+
+    /// @brief Compound bitwise AND assignment operator (&=)
+    template <typename U>
+        requires(IsVarExpr<Expr> && !ConstType<Type> && BitwiseAndAssignable<Type, U>)
+    React &operator&=(const U &rhs) {
+        atomicBitwiseAndAssign(*getPtr(), rhs);
+        return *this;
+    }
+
+    /// @brief Compound bitwise OR assignment operator (|=)
+    template <typename U>
+        requires(IsVarExpr<Expr> && !ConstType<Type> && BitwiseOrAssignable<Type, U>)
+    React &operator|=(const U &rhs) {
+        atomicBitwiseOrAssign(*getPtr(), rhs);
+        return *this;
+    }
+
+    /// @brief Compound bitwise XOR assignment operator (^=)
+    template <typename U>
+        requires(IsVarExpr<Expr> && !ConstType<Type> && BitwiseXorAssignable<Type, U>)
+    React &operator^=(const U &rhs) {
+        atomicBitwiseXorAssign(*getPtr(), rhs);
+        return *this;
+    }
+
+    /// @brief Compound left shift assignment operator (<<=)
+    template <typename U>
+        requires(IsVarExpr<Expr> && !ConstType<Type> && LeftShiftAssignable<Type, U>)
+    React &operator<<=(const U &rhs) {
+        atomicLeftShiftAssign(*getPtr(), rhs);
+        return *this;
+    }
+
+    /// @brief Compound right shift assignment operator (>>=)
+    template <typename U>
+        requires(IsVarExpr<Expr> && !ConstType<Type> && RightShiftAssignable<Type, U>)
+    React &operator>>=(const U &rhs) {
+        atomicRightShiftAssign(*getPtr(), rhs);
+        return *this;
+    }
+
+    // ==================== Increment/Decrement Operators ====================
+
+    /// @brief Pre-increment operator (++var)
+    template <typename T = Type>
+        requires(IsVarExpr<Expr> && !ConstType<Type> && PreIncrementable<T>)
+    React &operator++() {
+        atomicIncrement(*getPtr());
+        return *this;
+    }
+
+    /// @brief Post-increment operator (var++)
+    template <typename T = Type>
+        requires(IsVarExpr<Expr> && !ConstType<Type> && PostIncrementable<T>)
+    Type operator++(int) {
+        return atomicPostIncrement(*getPtr());
+    }
+
+    /// @brief Pre-decrement operator (--var)
+    template <typename T = Type>
+        requires(IsVarExpr<Expr> && !ConstType<Type> && PreDecrementable<T>)
+    React &operator--() {
+        atomicDecrement(*getPtr());
+        return *this;
+    }
+
+    /// @brief Post-decrement operator (var--)
+    template <typename T = Type>
+        requires(IsVarExpr<Expr> && !ConstType<Type> && PostDecrementable<T>)
+    Type operator--(int) {
+        return atomicPostDecrement(*getPtr());
+    }
+
     /// @brief Get the internal shared pointer for advanced operations.
     [[nodiscard]] std::shared_ptr<react_type> getPtr() const {
         // Thread-safe access to weak_ptr using conditional mutex