Refactor GitHub Actions workflow to streamline SmartThings CLI usage

- Removed redundant verification steps for SmartThings CLI installation and authentication.
- Introduced a smartthings function to simplify command execution for SmartThings CLI.
- Replaced npx commands with the new smartthings function for improved readability and consistency in the deployment process.

Author: lunDreame

.github/workflows/deploy.yml

@@ -34,23 +34,6 @@ jobs:
       - name: Install SmartThings CLI
         run: |
           npm install -g @smartthings/cli@latest
-          # Add npm global bin directory to PATH (works for both npm and npx)
-          NPM_GLOBAL_BIN=$(npm config get prefix)/bin
-          echo "$NPM_GLOBAL_BIN" >> $GITHUB_PATH
-          export PATH="$NPM_GLOBAL_BIN:$PATH"
-
-      - name: Verify SmartThings CLI installation
-        run: |
-          npx @smartthings/cli --version
-
-      - name: Verify SmartThings CLI authentication
-        run: |
-          # SmartThings CLI uses ST_TOKEN environment variable for authentication
-          if [[ -z "$ST_TOKEN" ]]; then
-            echo "ERROR: ST_TOKEN environment variable is not set"
-            exit 1
-          fi
-          echo "SmartThings CLI authentication configured via ST_TOKEN"
 
       - name: Setup dependencies
         run: |
@@ -71,6 +54,11 @@ jobs:
 
       - name: Update device profiles
         run: |
+          # Define smartthings function to run with node
+          smartthings() {
+            node "$(npm config get prefix)/bin/smartthings" "$@"
+          }
+
           IFS=',' read -ra FOLDERS <<< "${{ steps.find-drivers.outputs.folders }}"
           for folder in "${FOLDERS[@]}"; do
             echo "Processing profiles for: $folder"
@@ -94,27 +82,27 @@ jobs:
               PROFILE_NAME=$(basename "$file" .yml)
               echo "Processing profile: $PROFILE_NAME"
 
-              PROFILE_ID=$(npx @smartthings/cli deviceprofiles --json 2>/dev/null | jq -r '.[] | select(.name=="'"$PROFILE_NAME"'") | .id' 2>/dev/null || echo "")
+              PROFILE_ID=$(smartthings deviceprofiles --json 2>/dev/null | jq -r '.[] | select(.name=="'"$PROFILE_NAME"'") | .id' 2>/dev/null || echo "")
 
               if [[ -n "$PROFILE_ID" && "$PROFILE_ID" != "null" ]]; then
                 echo "Deleting existing profile: $PROFILE_NAME ($PROFILE_ID)"
-                npx @smartthings/cli deviceprofiles:delete "$PROFILE_ID" >/dev/null 2>&1 || true
+                smartthings deviceprofiles:delete "$PROFILE_ID" >/dev/null 2>&1 || true
               fi
 
               echo "Creating profile from file: $file"
-              if ! npx @smartthings/cli deviceprofiles:create --input "$file" 2>&1; then
+              if ! smartthings deviceprofiles:create --input "$file" 2>&1; then
                 echo "ERROR: Failed to create profile $PROFILE_NAME"
                 continue
               fi
 
-              NEW_ID=$(npx @smartthings/cli deviceprofiles --json 2>/dev/null | jq -r '.[] | select(.name=="'"$PROFILE_NAME"'") | .id' 2>/dev/null || echo "")
+              NEW_ID=$(smartthings deviceprofiles --json 2>/dev/null | jq -r '.[] | select(.name=="'"$PROFILE_NAME"'") | .id' 2>/dev/null || echo "")
               if [[ -z "$NEW_ID" || "$NEW_ID" == "null" ]]; then
                 echo "ERROR: Failed to find created profile $PROFILE_NAME"
                 continue
               fi
 
               echo "Publishing profile: $PROFILE_NAME ($NEW_ID)"
-              if ! npx @smartthings/cli deviceprofiles:publish "$NEW_ID" 2>&1; then
+              if ! smartthings deviceprofiles:publish "$NEW_ID" 2>&1; then
                 echo "ERROR: Failed to publish profile $PROFILE_NAME"
                 continue
               fi
@@ -176,6 +164,11 @@ jobs:
 
       - name: Package and deploy drivers
         run: |
+          # Define smartthings function to run with node
+          smartthings() {
+            node "$(npm config get prefix)/bin/smartthings" "$@"
+          }
+
           IFS=',' read -ra FOLDERS <<< "${{ steps.find-drivers.outputs.folders }}"
 
           CHANNEL_ID="${{ steps.channel.outputs.channel_id }}"
@@ -186,7 +179,7 @@ jobs:
 
             # Package driver
             echo "Packaging driver in $folder..."
-            if ! npx @smartthings/cli edge:drivers:package "$folder" 2>&1; then
+            if ! smartthings edge:drivers:package "$folder" 2>&1; then
               echo "ERROR: Failed to package driver $folder"
               continue
             fi
@@ -198,7 +191,7 @@ jobs:
             echo "Looking for driver with packageKey: $PACKAGE_KEY or name: $DRIVER_NAME"
 
             # Find driver ID by packageKey or name
-            DRIVER_ID=$(npx @smartthings/cli edge:drivers --json 2>/dev/null | jq -r --arg pk "$PACKAGE_KEY" --arg name "$DRIVER_NAME" '.[] | select(.packageKey == $pk or .name == $name) | .driverId' 2>/dev/null | head -n1)
+            DRIVER_ID=$(smartthings edge:drivers --json 2>/dev/null | jq -r --arg pk "$PACKAGE_KEY" --arg name "$DRIVER_NAME" '.[] | select(.packageKey == $pk or .name == $name) | .driverId' 2>/dev/null | head -n1)
 
             if [[ -z "$DRIVER_ID" || "$DRIVER_ID" == "null" ]]; then
               echo "WARNING: Driver not found in existing drivers list"
@@ -211,7 +204,7 @@ jobs:
 
             # Assign driver to channel
             echo "Assigning driver $DRIVER_ID to channel $CHANNEL_ID..."
-            if ! npx @smartthings/cli edge:channels:assign --channel "$CHANNEL_ID" "$DRIVER_ID" 2>&1; then
+            if ! smartthings edge:channels:assign --channel "$CHANNEL_ID" "$DRIVER_ID" 2>&1; then
               echo "ERROR: Failed to assign driver $DRIVER_ID to channel $CHANNEL_ID"
               continue
             fi