Fix resource leak with cached update blocks

Author: lare96

src/main/java/io/luna/game/model/mob/Mob.java

@@ -312,8 +312,6 @@ public ByteBuf acquireCachedBlock() {
     public boolean cacheBlockIfAbsent(ByteMessage msg) {
         ByteBuf cachedMsg = msg.getBuffer().retainedDuplicate();
         if (cachedBlock.compareAndSet(null, cachedMsg)) {
-            if (this instanceof Npc && asNpc().getIndex() == 1)
-                System.err.println("cached block , won by " + Thread.currentThread().getName() + ", refs: " + cachedMsg.refCnt());
             return true;
         }
         cachedMsg.release();
@@ -335,8 +333,6 @@ public boolean cacheBlockIfAbsent(ByteMessage msg) {
     public void clearCachedBlock() {
         ByteBuf old = cachedBlock.getAndSet(null);
         if (old != null) {
-            if (this instanceof Npc && asNpc().getIndex() == 1)
-                System.err.println("About to clear old block, refs: " + old.refCnt());
             old.release();
         }
     }

src/main/java/io/luna/game/model/mob/block/PlayerUpdateBlockSet.java

@@ -32,13 +32,15 @@ public final class PlayerUpdateBlockSet extends AbstractUpdateBlockSet<Player> {
     @Override
     public void addBlockSet(Player player, ByteMessage msg, UpdateState state) {
         // The block has already been encoded for someone this cycle; reuse it.
-        ByteBuf cachedBlock = player.acquireCachedBlock();
-        if (state == UpdateState.UPDATE_LOCAL && cachedBlock != null) {
-            try {
-                msg.putBytes(cachedBlock);
-                return;
-            } finally {
-                cachedBlock.release();
+        if (state == UpdateState.UPDATE_LOCAL) {
+            ByteBuf cachedBlock = player.acquireCachedBlock();
+            if (cachedBlock != null) {
+                try {
+                    msg.putBytes(cachedBlock);
+                    return;
+                } finally {
+                    cachedBlock.release();
+                }
             }
         }