feat: support multiple finally calls within a single test (#753)

Author: goldenstein64

busted/init.lua

@@ -29,7 +29,13 @@ local function init(busted)
     if not element.env then element.env = {} end
 
     block.rejectAll(element)
-    element.env.finally = function(fn) finally = fn end
+    element.env.finally = function(fn)
+      local old_finally = finally or function() end
+      finally = function()
+        fn()
+        old_finally()
+      end
+    end
     element.env.pending = busted.pending
 
     local pass, ancestor = block.execAll('before_each', parent, true)

spec/core_spec.lua

@@ -229,6 +229,27 @@ describe('finally callback is called in case of success', function()
   end)
 end)
 
+describe('multiple finally callbacks', function()
+  local order = {}
+  local f1 = spy.new(function() table.insert(order, "f1") end)
+  local f2 = spy.new(function() table.insert(order, "f2") end)
+  local f3 = spy.new(function() table.insert(order, "f3") end)
+
+  it('pushes all finally blocks', function()
+    finally(f1)
+    finally(f2)
+    finally(f3)
+    assert.is_true(true)
+  end)
+
+  it('ensures all finally blocks were called', function()
+    assert.spy(f1).was_called(1)
+    assert.spy(f2).was_called(1)
+    assert.spy(f3).was_called(1)
+    assert.are_same({ "f3", "f2", "f1" }, order)
+  end)
+end)
+
 describe('tests environment', function()
   global = 'global'  --luacheck: ignore