INFO: API change in lane's :join() method for lanes v4.0.0 will break task handling in multithreading.lua

[KritzelKratzel]

FYI - the recently introduced API change in LuaLanes/lanes@bfdc7a9 will break collection of worker results in multithreading.lua. Quote from referenced lanes commit:

Change lane:join() return values

• when no error is raised in the lane, lane:join() now precedes the lane returned values with true

Changing local _, ok, worker_results = assert(worker:join()) to local _, _, ok, worker_results = assert(worker:join()) in line 93 of multithreading.lua fixes the issue. I suggest to add some kind of version checking around this line of code with lanes.ABOUT.version.

[alerque]

Thanks for reporting this. PRs welcome.

It might make more sense to just do the latter assignment, then test the variables for expected type and shift them if they are wrong (e.g. the old layout). That might end up being less brittle and easier to test than version comparisons, especially if there is a possibility of RCs or other formats turning up that we don't know exactly what to parse for ahead of time.