Cart adds shipping subtotal to cart subtotal

[yhortuk]

• Lunar version: v0.2-rc1

Expected Behaviour:

Cart subtotal shouldn't include shipping costs (at least it is what the field description states).

Actual Behaviour:

$cart->subTotal returns cart lines subtotal including the shipping costs.

Steps To Reproduce:

1. Create a cart instance
2. Add non zero shipping option to the cart
3. Call $cart->calculate()
4. Call $cart->subTotal

[glennjacobs]

Yes, I agree with this. It seems the accepted standard is to have the sub-total before shipping is applied.

I'm going to change to enhancement, as it's not technically a bug.

[ryanmitchell]

@glennjacobs This is biting us too. Is this something youre working on or do you need a PR for it?

[glennjacobs]

@glennjacobs This is biting us too. Is this something youre working on or do you need a PR for it?

I would be looking at this for the 0.3 release.

[ryanmitchell]

I've opened a PR anyway in case you want to sneak it into 0.2
😄