[anno] [add check logic for path]

Author: leobert-lan

router-anno-compiler/src/main/java/com/ljsw/router/compiler/processor/RouterProcessor.java

@@ -71,7 +71,13 @@ public class RouterProcessor extends AbstractProcessor {
     private Types types;
     private Elements elements;
 
+    /**
+     * (group,hostInfo)
+     */
     private Map<String, HostInfo> routers;
+    /**
+     * (group,List(Node))
+     */
     private Map<String, List<Node>> routerNodes;
 
     private TypeMirror type_TextUtils;
@@ -141,58 +147,6 @@ public boolean process(Set<? extends TypeElement> set, RoundEnvironment roundEnv
         return false;
     }
 
-//    @Deprecated
-//    private void write2Util() {
-//        Set<String> groups = routers.keySet();
-//
-//        ClassName type_UiRouterLoader = ClassName.get(elements.getTypeElement(TYPE_UIROUTER_LOADER));
-//        for (String group : groups) {
-//            logger.info(">>> write for group:" + group);
-//
-//            TypeMirror value = routers.get(group);
-//            String path = value.toString();
-//
-//            String pkg = path.substring(0, path.lastIndexOf("."));
-//            String cn = path.substring(path.lastIndexOf(".") + 1) + "Loader";
-//
-//            ParameterizedTypeName inputMapTypeOfGroup = ParameterizedTypeName.get(
-//                    ClassName.get(Map.class),
-//                    ClassName.get(String.class),
-//                    ClassName.get(Class.class)
-//            );
-//
-//            ParameterSpec groupParamSpec =
-//                    ParameterSpec.builder(inputMapTypeOfGroup, "mapper").build();
-//
-//
-//            MethodSpec.Builder loadIntoMethodOfRootBuilder =
-//                    MethodSpec.methodBuilder(ROUTER_UTIL_METHOD_ADDTO)
-//                            .addParameter(groupParamSpec)
-//                            .addAnnotation(Override.class)
-//                            .addModifiers(PUBLIC);
-//
-//            List<Node> nodes = routerNodes.get(group);
-//            for (Node node : nodes) {
-//                loadIntoMethodOfRootBuilder.addStatement(
-//                        "mapper.put($S,$T.class)",
-//                        node.getPath(),
-//                        ClassName.get((TypeElement) node.getRawType()));
-//            }
-//
-//
-//            try {
-//                JavaFile.builder(pkg, TypeSpec.classBuilder(cn)
-//                        .addModifiers(PUBLIC)
-//                        .addSuperinterface(type_UiRouterLoader)
-//                        .addMethod(loadIntoMethodOfRootBuilder.build())
-//                        .build()
-//                ).build().writeTo(mFiler);
-//            } catch (IOException e) {
-//                e.printStackTrace();
-//            }
-//        }
-//    }
-
     private void generateRouterImpl() {
         Set<String> groups = routers.keySet();
 
@@ -255,6 +209,8 @@ private void parseRouteNodes(Set<? extends Element> routeElements) {
 
         TypeMirror type_Activity = elements.getTypeElement(ACTIVITY).asType();
 
+        Map<String, List<String>> cacheForConflictCheck = new HashMap<>();
+
         for (Element element : routeElements) {
             TypeMirror tm = element.asType();
             RouteNode route = element.getAnnotation(RouteNode.class);
@@ -263,9 +219,23 @@ private void parseRouteNodes(Set<? extends Element> routeElements) {
                 logger.info(">>> Found activity route: " + tm.toString() + " <<<");
 
                 String group = route.group();
+                List<String> groupPaths;
+
+                if (cacheForConflictCheck.containsKey(group)) {
+                    groupPaths = cacheForConflictCheck.get(group);
+                } else {
+                    groupPaths = new ArrayList<>();
+                    cacheForConflictCheck.put(group, groupPaths);
+                }
 
                 Node node = new Node();
-                node.setPath(route.path());
+                String path = route.path();
+
+                checkPath(group, path, groupPaths);
+
+                groupPaths.add(path);
+
+                node.setPath(path);
                 node.setPriority(route.priority());
                 node.setNodeType(NodeType.ACTIVITY);
                 node.setRawType(element);
@@ -283,6 +253,21 @@ private void parseRouteNodes(Set<? extends Element> routeElements) {
         }
     }
 
+    private void checkPath(String group, String path, List<String> groupPaths) {
+        if (groupPaths.contains(path))
+            throw new IllegalStateException("conflict path in group:" + group + ",path is:" + path);
+
+        if (path == null || path.isEmpty() || !path.startsWith("/"))
+            throw new IllegalArgumentException("path cannot be null or empty,and should start with /,this is:" + path);
+
+        if (path.contains("//") || path.contains("&") || path.contains("?"))
+            throw new IllegalArgumentException("path should not contain // ,& or ?,this is:" + path);
+
+        if (path.endsWith("/"))
+            throw new IllegalArgumentException("path should not endWith /,this is:" + path
+                    + ";or append a token:index");
+    }
+
     private void foundRouters(Set<? extends Element> routers) {
         for (Element element : routers) {
             Router router = element.getAnnotation(Router.class);
@@ -517,4 +502,5 @@ private MethodSpec generateVerify() {
         return openUriMethodSpecBuilder.build();
     }
 
+
 }

router-anno-compiler/src/main/java/com/ljsw/router/compiler/utils/AnnoUtils.java

@@ -1,13 +1,11 @@
 package com.ljsw.router.compiler.utils;
 
 import com.ljsw.router.compiler.model.MethodInfo;
-import com.squareup.javapoet.ClassName;
 import com.squareup.javapoet.ParameterSpec;
 import com.squareup.javapoet.ParameterizedTypeName;
 import com.squareup.javapoet.TypeName;
 
 import java.util.ArrayList;
-import java.util.Iterator;
 import java.util.List;
 
 import javax.lang.model.element.Element;
@@ -48,17 +46,6 @@ public static String getSimpleName(Element element) {
         return element.getSimpleName().toString();
     }
 
-//    public static ParameterSpec generateMethodParameterSpec(String clzPkg,
-//                                                            String clzSimpleName,
-//                                                            String paramName) {
-//        ClassName cn = ClassName.get(clzPkg, clzSimpleName);
-//
-//        ParameterizedTypeName ptn =
-//                ParameterizedTypeName.get(cn);
-//
-//        return ParameterSpec.builder(ptn, paramName).build();
-//    }
-
     public static ParameterSpec generateMethodParameterSpec(TypeMirror typeMirror,
                                                             String paramName) {
         TypeName tn =
@@ -67,30 +54,5 @@ public static ParameterSpec generateMethodParameterSpec(TypeMirror typeMirror,
         return ParameterSpec.builder(tn, paramName).build();
     }
 
-//    public static ParameterSpec generateMethodParameterSpec(Class clz,
-//                                                            String paramName) {
-//        ClassName cn = ClassName.get(clz);
-//
-//        ParameterizedTypeName ptn =
-//                ParameterizedTypeName.get(cn);
-//
-//        return ParameterSpec.builder(ptn, paramName).build();
-//    }
 
-//    public static String join(Iterator iterator, String separator) {
-//        if (separator == null) {
-//            separator = "";
-//        }
-//
-//        StringBuilder buf = new StringBuilder(256);
-//
-//        while (iterator.hasNext()) {
-//            buf.append(iterator.next());
-//            if (iterator.hasNext()) {
-//                buf.append(separator);
-//            }
-//        }
-//
-//        return buf.toString();
-//    }
 }