Feature/snaps events v2 integration #1492
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to limits and quotas
…es. Source app identifiers are now set using env variables
…s, added FileGroup
moratom
reviewed
Oct 13, 2025
Collaborator
moratom
left a comment
moratom
left a comment
There was a problem hiding this comment.
Thanks Aljaz!
Left a few questions, comments
| uint64_t size; | ||
| std::string checksum; | ||
| proto::event::PrepareFileUploadClass classification; | ||
| friend class EventsManager; |
Collaborator
There was a problem hiding this comment.
Why does the EventsManager need to be a friend here?
Contributor
Author
There was a problem hiding this comment.
In the current implementation it's accessing FileData's private members directly
| # Properties | ||
| # Enter you hub team's api-key | ||
| eventMan = dai.EventsManager() | ||
| eventMan.setToken("") |
Contributor
Author
There was a problem hiding this comment.
I left it here to "alert" the user that the token must be set - specifically in the peripheral mode. I can remove it, if this doesn't make sense
moratom
reviewed
Oct 13, 2025
moratom
reviewed
Oct 13, 2025
moratom
reviewed
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Update snaps and events to V2
Specification
None / not applicable
Changes in the uploading of the events and snaps to the Luxonis Hub, the protobuf definition used in connection to events and snaps, examples in C++ & Python
Dependencies & Potential Impact
None / not applicable
Deployment Plan
None / not applicable
Testing & Validation
This was tested using the stg and prod versions of the Hub, by uploading different snaps and events