Skip to content

Commit 633d497

Browse files
lwasserlwasser
committed
Fix: rebase and cleanup
No css changes in this pr No css changes in this pr
1 parent 75668c0 commit 633d497

File tree

5 files changed

+63
-56
lines changed

5 files changed

+63
-56
lines changed

‎_data/navigation.yml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@ main:
66
- title: "About peer review"
77
icon:
88
url: "/about-peer-review/index.html"
9+
- title: "How to submit a package for review"
10+
icon:
11+
url: "/how-to-submit-a-package-to-pyopensci.html"
912
- title: "Community partners"
1013
icon:
1114
url: "/partners.html"
@@ -15,9 +18,6 @@ main:
1518
- title: "Peer review guide"
1619
url: "https://www.pyopensci.org/software-peer-review/"
1720
icon: "fas fa-external-link-alt"
18-
- title: "How to submit a package"
19-
icon:
20-
url: "/how-to-submit-a-package-to-pyopensci.html"
2121
- title: "Python Packaging"
2222
icon: "fas fa-fw fa-envelope-square"
2323
url:

‎_pages/how-to-submit-package.md‎

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,9 @@ toc: true
1414

1515
## <i class="fa-solid fa-rocket" style="color:#a193c6"></i> Submit your Python package for review
1616

17-
You’ve created a Python package—now what? How do you ensure it follows best practices, is well-documented, and reaches the right audience?
17+
You’ve created a Python package! Yay! Now, how do you ensure it follows best practices and gets seen by the broader Python community?
1818

19-
**pyOpenSci’s peer review process** connects you with experts who will help refine your package’s structure, documentation, and usability. Accepted packages become part of our vetted ecosystem, increasing their visibility and credibility. And finally, if your package is in scope, you can also publish it in the [Journal of Open Source Software (JOSS)](https://www.pyopensci.org/software-peer-review/partners/joss.html) through our single end-to-end review process.
20-
21-
### <i class="fa-solid fa-circle-chevron-down"></i> Why submit a Python package for review?
22-
- <i class="fa-solid fa-eye" style="color:#8B868E"></i> **Visibility & support:** Gain expert feedback on your code, documentation, and packaging.
23-
- <i class="fa-solid fa-check-circle" style="color:#8B868E"></i> **Quality & best practices:** Ensure your package follows open-source and scientific standards.
24-
- <i class="fa-solid fa-book-open" style="color:#8B868E"></i> **JOSS publication:** Get the option to publish in the Journal of Open Source Software (JOSS) after acceptance.
19+
**pyOpenSci’s peer review process** connects you with community members who will review your package, help refine its structure, documentation, and usability. Accepted packages become part of our vetted ecosystem, increasing their visibility. And finally, if your package is in scope, you can also publish it in the [Journal of Open Source Software (JOSS)](https://www.pyopensci.org/software-peer-review/partners/joss.html) through our single end-to-end review process.
2520

2621
<i class="fa-solid fa-book" style="color:#81c0aa;"></i> **[Learn more about the benefits of our peer review process](https://www.pyopensci.org/software-peer-review/about/benefits.html)**
2722

@@ -35,8 +30,6 @@ You’ve created a Python package—now what? How do you ensure it follows best
3530
</figcaption>
3631
</figure>
3732

38-
Read more about the benefits of pyOpenSci's open peer review process in our [Peer Review Guide](https://www.pyopensci.org/software-peer-review/about/benefits.html).
39-
4033
<div class="notice" markdown="1">
4134

4235
#### <i class="fa-solid fa-graduation-cap"></i> New to Python packaging?
@@ -51,8 +44,8 @@ If you're still working on your package and want guidance, check out our
5144
Our **open peer review process** happens through GitHub issues in the [**pyOpenSci software submission repository**](https://github.com/pyopensci/software-submission). Using open GitHub issues ensures a **transparent and constructive** review process focused on improving:
5245

5346
- **Package structure & quality:** Ensure best practices in documentation, testing, and maintenance.
54-
- **Usability & reproducibility:** Improve user experience and scientific reliability.
55-
- **Visibility:** Join a vetted ecosystem of high-quality, community-endorsed Python tools.
47+
- **Usability:** Improve a users experience by adding clear documentation and quick start tutorials.
48+
- **Visibility:** Join a vetted ecosystem of high-quality, community-endorsed Python tools that scientists can discover and trust.
5649

5750
Follow the steps below to submit your package for review.
5851

‎_sass/minimal-mistakes/_base.scss‎

Lines changed: 19 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
========================================================================== */
44

55
html {
6-
/* sticky footer fix */
6+
/* Sticky footer fix */
77
position: relative;
88
min-height: 100%;
99
}
@@ -14,16 +14,16 @@
1414
color: $text-color;
1515
font-family: $global-font-family;
1616
line-height: 1.6;
17-
weight: $weight-3;
18-
font-size: 1em;
17+
font-weight: $weight-3;
18+
font-size: 1rem;
1919

2020
&.overflow--hidden {
2121
/* when primary navigation is visible, the content in the background won't scroll */
2222
overflow: hidden;
2323
}
2424
}
2525

26-
strong {font-weight:$bold-weight}
26+
strong {font-weight:$semibold-weight}
2727
ul li {margin-bottom: 0}
2828

2929
h1,
@@ -35,49 +35,43 @@
3535
margin: 3.5rem 0 1rem 0;
3636
line-height: 1.2;
3737
color: #542668;
38-
text-wrap: pretty;
3938
}
40-
// All fonts h2 and lower are poppins
41-
h2,
42-
h3,
43-
h4,
44-
h5,
45-
h6 {
39+
40+
// Use poppins for subheaders
41+
h2, h3, h4, h5, h6 {
4642
font-family: $header-font-family;
43+
font-weight: $bold-weight;
44+
letter-spacing: -.03em;
45+
max-width: $medium;
4746
}
4847

4948
h1 {
5049
margin-top: 0;
5150
font-size: $h-size-1;
52-
font-weight: 200 !important;
53-
font-family: $header-font;
51+
font-weight: 400 !important;
52+
font-family: $title-font-family;
5453
}
5554

5655
h2 {
5756
font-size: $h-size-2;
58-
padding-bottom: 0.2em;
59-
margin-bottom: 1rem;
60-
margin-top: 3rem;
61-
font-weight: $semibold-weight; //600
62-
line-height: 1.1;
63-
letter-spacing: -0.03em;
57+
58+
&:first-of-type {
59+
//margin-top: 1rem!important;
60+
}
6461
}
6562

6663
h3 {
6764
font-size: $h-size-3;
68-
font-weight: $semibold-weight;
6965
line-height: 1.1em;
7066
margin-top: 2.7em;
7167
}
7268

7369
h4 {
7470
font-size: $h-size-4;
75-
font-weight: $semibold-weight;
7671
}
7772

7873
h5 {
7974
font-size: $h-size-5;
80-
font-weight: $semibold-weight;
8175
}
8276

8377
h6 {
@@ -91,7 +85,6 @@
9185

9286
p {
9387
margin-bottom: 1.3em;
94-
text-wrap: pretty;
9588
}
9689

9790
u,
@@ -423,8 +416,9 @@
423416
overflow: hidden;
424417
}
425418

426-
/* Navigation lists */
427-
419+
/*
420+
Navigation lists
421+
========================================================================== */
428422

429423
nav {
430424
ul {

‎_sass/minimal-mistakes/_page.scss‎

Lines changed: 24 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -82,12 +82,19 @@
8282
}
8383
}
8484

85+
// in our flowing layout the title should be max width
86+
.page__content .pyos-section h2 {
87+
max-width: 100%;
88+
89+
}
8590
.page__lead {
86-
font-family: $global-font-family;
91+
font-family: $header-font; //poppins
8792
font-size: $type-size-5;
8893
font-weight: $weight-3;
8994
}
9095

96+
97+
9198
.page__content {
9299
figure {
93100
max-width: 35rem;
@@ -100,6 +107,11 @@
100107
font-weight: $weight-4;
101108
}
102109

110+
h2 {
111+
margin-bottom: 2.0rem;
112+
margin-top: 4.1rem;
113+
}
114+
103115
h1,
104116
h2,
105117
h3,
@@ -127,7 +139,7 @@
127139
p,
128140
dl {
129141
font-size: $type-size-5;
130-
line-height: 1.5em;
142+
line-height: 1.6rem;
131143
}
132144

133145
/* paragraph indents */
@@ -595,6 +607,11 @@
595607
}
596608
}
597609

610+
.layout--splash .page__content h2 {
611+
width: 100%;
612+
max-width: 100%;
613+
}
614+
598615
/* Media queries */
599616

600617
@media screen and (max-width: 768px) {
@@ -633,10 +650,7 @@
633650
.feature__item {
634651
width: 95%!important;
635652
}
636-
.cards {
637-
margin-right: auto!important;
638-
margin-left: auto!important;
639-
}
653+
640654

641655
.wide__p_text {
642656
max-width: 90%!important;
@@ -650,7 +664,10 @@
650664

651665
/* max 480 px */
652666
@media screen and (max-width: 480px) {
653-
body{
667+
body {
654668
font-size: 1.4em;
655669
}
670+
#main {
671+
padding: 0 .6rem;
672+
}
656673
}

‎_sass/minimal-mistakes/_variables.scss‎

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -47,26 +47,27 @@ $calisto: "Calisto MT", serif !default;
4747
$garamond: Garamond, serif !default;
4848

4949
$global-font-family: $sans-serif !default;
50-
$header-font-family: "Poppins", cursive, $sans-serif !default;
51-
$caption-font-family: $sans-serif !default;
52-
$header-font: "Itim", cursive; //h1 only
53-
$body-font: "Nunito Sans", sans-serif !default; //'Open Sans', sans-serif;
50+
$title-font-family: "Itim", cursive, $sans-serif !default;
51+
$header-font-family: "Poppins", $sans-serif;
52+
$caption-font-family: "Nunito Sans", sans-serif !default;
53+
$header-font: "Poppins", san-serif !default;
54+
$body-font: "Nunito Sans", sans-serif !default;
5455

5556
/* type scale */
5657
$type-size-1: 2.441em !default; // ~39.056px
57-
$type-size-2: 2.49em !default; // ~31.248px h2
58+
$type-size-2: 1.953em !default; // ~31.248px
5859
$type-size-3: 1.563em !default; // ~25.008px
5960
$type-size-4: 1.25em !default; // ~20px
60-
$type-size-5: 0.85em !default; // ~13.6px
61+
$type-size-5: 0.95em !default; // ~13.6px
6162
$type-size-6: 0.75em !default; // ~12px main body font
6263
$type-size-7: 0.64em !default; // ~10.24px
6364
$type-size-8: 0.635em !default; // ~10.16px
6465

6566
/* headline scale */
66-
$h-size-1: 1.563rem !default; // ~25.008px
67-
$h-size-2: 2.5rem !default; // ~20px H2 increased 2.0
68-
$h-size-3: 2.07rem !default; // ~18px increased
69-
$h-size-4: 1.78rem !default; // ~17px
67+
$h-size-1: 1.563em !default; // ~25.008px
68+
$h-size-2: 2.6em !default; // ~20px H2 increased 2.0
69+
$h-size-3: 2.0em !default; // ~18px
70+
$h-size-4: 1.5em !default; // ~17px
7071
$h-size-5: 1.03125em !default; // ~16.5px
7172
$h-size-6: 1em !default; // ~16px
7273

@@ -84,7 +85,9 @@ $background-block: #d6cfde;
8485

8586
/* pyos colors */
8687

88+
$pyos-deeppurple: #33205c;
8789
$pyos-darkpurple: #542668;
90+
$pyos-mediumpurple: #735fab; //brand color
8891
$pyos-lightpurple: #e1dfed;
8992
$pyos-teal: #81c0aa;
9093
$pyos-magenta: #bb82b0;

0 commit comments

Comments
 (0)