Skip to content

Commit 2d6e186

Browse files
committed
Fix: edits to doc section from @SimonMolinsky
1 parent 3019cf0 commit 2d6e186

File tree

2 files changed

+34
-23
lines changed

2 files changed

+34
-23
lines changed

documentation/contributing-file.md

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ A healthy Python package repository (or any open source software repository) sho
55
* Contributing.md file
66
* A development guide (if possible)
77
* A License file and
8-
* A code of conduct file
8+
* A CODE_OF_CONDUCT.md file
99

1010
## What a CONTRIBUTING.md file should contain
1111

@@ -22,6 +22,7 @@ submitting issues or pull requests:
2222
* Any guidelines that you have in place for users submitting issues, pull requests or asking questions.
2323
* A link to your code of conduct
2424
* A link to a development guide if you have one
25+
* A link to licensing information found in your README file.
2526

2627
## What the development guide for your Python package should contain
2728

@@ -68,16 +69,17 @@ review. Some maintainers may also opt to include the development information in
6869
creating a contributing guide](https://mozillascience.github.io/working-open-workshop/contributing/)
6970
```
7071

71-
## Your repository should have a license file
72+
## Your repository should have a LICENSE.md file
7273

73-
The root of your GitHub repository sshould also have a License.txt file.
74+
The root of your GitHub repository should also have a LICENSE.txt file.
7475

75-
To be reviewed by pyOpenSci your project should use an open source software license that is approved
76+
To be reviewed by pyOpenSci your project should use an open source
77+
software license that is approved
7678
by the Open Software Initiative (OSI). OSI's website has a
7779
[list of popular licenses](https://opensource.org/licenses). GitHub also has a
7880
[handy tool](https://choosealicense.com/) for choosing a license.
7981

80-
If you chose your license through GitHub, you can also automatically get a copy of the license file to add to your repository.
82+
If you choose your license through GitHub, you can also automatically get a copy of the license file to add to your repository.
8183

8284
<!--
8385
pyOpenSci packages must:

documentation/readme-file-best-practices.md

Lines changed: 27 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,13 @@ install your package.
55

66
The README.md file is the landing page of:
77

8-
* Your file on package manager landing pages like PyPI and Anaconda
8+
* Your package's landing page on a repository site such as PyPI or Anaconda
99
* Your package's GitHub repository
1010

11-
It is also used to measure:
12-
* community health by github
13-
* and included in package health landing pages such as snyk
11+
Your README.md file is also used as a measure of package and community
12+
health on sites such as:
13+
* [GitHub community health (available for all repositories - this link demonstrates movingpandas)](https://github.com/anitagraser/movingpandas/community), and
14+
* [snyk - moving pandas example)
1415

1516

1617
```{figure} ../images/pandera-python-package-readme-github.png
@@ -40,9 +41,9 @@ Your README file should have the following information:
4041
- [ ] Badges for the packages current published version, documentation and test suite build. (OPTIONAL: test coverage)
4142
- [ ] Easy-to-understand explanation (2-4 sentences) of what your tool does
4243
- [ ] Context for how the tool fits into the broader ecosystem
43-
- [ ] If it's your package is a wrapper, link to the package that it is wrapping and any associated documentation. (If you do'nt know what a wrapper is - this probably doesn't apply to you!)
44-
- [ ] A simple quickstart code example that a user can follow to provide a demonstration of what the package can do for them
45-
- [ ] Links to your package documentation / website.
44+
- [ ] If your package "wraps" around another package, link to the package that it is wrapping and any associated documentation. *(HINT: If you don't know what a wrapper is, this probably doesn't apply to you!)*
45+
- [ ] A simple quick-start code example that a user can follow to provide a demonstration of what the package can do for them
46+
- [ ] Links to your packages documentation / website.
4647
- [ ] A few descriptive links to any tutorials you've created for your package.
4748
```
4849
````
@@ -122,33 +123,41 @@ your README file.
122123

123124
This description ideally includes a quick start vignette that provides a code sample demonstrating use of your package.
124125

125-
### ✔️ Descriptive links to package documentation, tutorials or vignettes.
126+
### ✔️ Descriptive links to package documentation, short tutorials
126127

127128
Include descriptive links to:
128129

129130
* The package's documentation page.
130-
* Tutorials or vignettes that demonstrate application of your package.
131+
* Short tutorials that demonstrate application of your package.
131132

132133
```{tip}
133-
### TOO MUCH OF A GOOD thing
134+
### Too Much Of A Good Thing
134135
135-
Try to avoid including several tutorials in the readme file itself. This too will overwhelm the user with information.
136+
Try to avoid including several tutorials in the README.md file itself. This too will overwhelm the user with information.
136137
137-
A short quick-start vignette that shows a user how to use your package is plenty for the README file. All other tutorials and documentation should be presented as descriptive links.
138+
A short quick-start tutorial that shows a user how to use your package
139+
is plenty of content for the README file. All other tutorials and
140+
documentation
141+
should be presented as descriptive links.
138142
```
139143

140144
### ✔️ A Community Section with Links to Contributing Guide, Code of Conduct
141-
In your readme file direct users to more information on:
142-
* contributing to your package
143-
* development setup for more advanced technical contributors
144-
* your code of conduct.
145145

146-
All of the above files are important for building community around your project.
146+
Use your README.md file to direct users to more information on:
147+
148+
* Contributing to your package
149+
* Development setup for more advanced technical contributors
150+
* Your code of conduct
151+
* Licensing information
152+
153+
All of the above files are important for building community around your
154+
project.
147155

148156
### ✔️ Citation information
149157

150158
Finally be sure to include instructions on how to cite your package.
151-
159+
Citation should include the DOI that you want used when citing your package,
160+
and any language that you'd like to see associated with the citation.
152161

153162
```{tip}
154163
### README Resources

0 commit comments

Comments
 (0)