Fix incorrect emit of 'move-cursor' on GtkTreeView

lwindolf · lwindolf · commit 74a6873010a9 · 2025-08-27T12:09:29.000+02:00
diff --git a/ChangeLog b/ChangeLog
@@ -20,6 +20,9 @@ To be released
 	* GtkShortCutsWindow is now used for displaying hotkeys, new hotkey is Ctrl-?
 	  (Lars Windolf)
 
+	* Fixes incorrectly emitting "move-cursor" signal in GtkTreeView
+	  (Lars Windolf)
+
 
 2025-08-20  Lars Windolf <lars.windolf@gmx.de>
 
diff --git a/src/ui/ui_common.c b/src/ui/ui_common.c
@@ -60,10 +60,10 @@ ui_common_setup_combo_text (GtkComboBox *combo, gint col)
 void
 ui_common_treeview_move_cursor (GtkTreeView *treeview, gint step)
 {
-	gboolean	ret;
+	gboolean unused;
 
 	gtk_widget_grab_focus (GTK_WIDGET (treeview));
-	g_signal_emit_by_name (treeview, "move-cursor", GTK_MOVEMENT_DISPLAY_LINES, step, &ret);
+	g_signal_emit_by_name (treeview, "move-cursor", GTK_MOVEMENT_DISPLAY_LINES, step, FALSE /* extend selection */, FALSE /* modify selection */, &unused);
 }
 
 void

Original file line number	Diff line number	Diff line change
`@@ -60,10 +60,10 @@ ui_common_setup_combo_text (GtkComboBox *combo, gint col)`
`60`	`60`	`void`
`61`	`61`	`ui_common_treeview_move_cursor (GtkTreeView *treeview, gint step)`
`62`	`62`	`{`
`63`		`- gboolean ret;`
	`63`	`+ gboolean unused;`
`64`	`64`
`65`	`65`	`gtk_widget_grab_focus (GTK_WIDGET (treeview));`
`66`		`- g_signal_emit_by_name (treeview, "move-cursor", GTK_MOVEMENT_DISPLAY_LINES, step, &ret);`
	`66`	`+ g_signal_emit_by_name (treeview, "move-cursor", GTK_MOVEMENT_DISPLAY_LINES, step, FALSE /* extend selection /, FALSE / modify selection */, &unused);`
`67`	`67`	`}`
`68`	`68`
`69`	`69`	`void`