Skip to content

Commit ac5b9d5

Browse files
committed
llext: move logging context to base firmware
Move the logging context of eq_iir and mixin_mixout to the base firmware image too. This improves logging entries, dropped due to LLEXT unloading. Signed-off-by: Guennadi Liakhovetski <[email protected]>
1 parent 312459f commit ac5b9d5

File tree

7 files changed

+70
-13
lines changed

7 files changed

+70
-13
lines changed

src/audio/eq_iir/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# SPDX-License-Identifier: BSD-3-Clause
22

3-
add_local_sources(sof eq_iir.c eq_iir_generic.c)
3+
add_local_sources(sof eq_iir.c eq_iir_generic.c eq_iir_log.c)
44
if(CONFIG_IPC_MAJOR_3)
55
add_local_sources(sof eq_iir_ipc3.c)
66
elseif(CONFIG_IPC_MAJOR_4)

src/audio/eq_iir/eq_iir.c

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,10 @@
3535
#include <stddef.h>
3636
#include <stdint.h>
3737

38-
LOG_MODULE_REGISTER(eq_iir, CONFIG_SOF_LOG_LEVEL);
38+
LOG_MODULE_DECLARE(eq_iir, CONFIG_SOF_LOG_LEVEL);
3939

40-
SOF_DEFINE_REG_UUID(eq_iir);
41-
42-
DECLARE_TR_CTX(eq_iir_tr, SOF_UUID(eq_iir_uuid), LOG_LEVEL_INFO);
40+
extern const struct sof_uuid eq_iir_uuid;
41+
extern struct tr_ctx eq_iir_tr;
4342

4443
/*
4544
* End of EQ setup code. Next the standard component methods.

src/audio/eq_iir/eq_iir_log.c

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
// SPDX-License-Identifier: BSD-3-Clause
2+
//
3+
// Copyright(c) 2024 Intel Corporation.
4+
5+
#include <rtos/symbol.h>
6+
#include <sof/lib/uuid.h>
7+
#include <sof/trace/trace.h>
8+
#include <user/trace.h>
9+
10+
LOG_MODULE_REGISTER(eq_iir, CONFIG_SOF_LOG_LEVEL);
11+
EXPORT_SYMBOL(log_const_eq_iir);
12+
13+
SOF_DEFINE_REG_UUID(eq_iir);
14+
EXPORT_SYMBOL(eq_iir_uuid);
15+
16+
DECLARE_TR_CTX(eq_iir_tr, SOF_UUID(eq_iir_uuid), LOG_LEVEL_INFO);
17+
EXPORT_SYMBOL(eq_iir_tr);
Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,7 @@
1-
add_local_sources(sof mixin_mixout.c mixin_mixout_generic.c mixin_mixout_hifi3.c mixin_mixout_hifi5.c)
1+
add_local_sources(sof
2+
mixin_mixout.c
3+
mixin_mixout_generic.c
4+
mixin_mixout_hifi3.c
5+
mixin_mixout_hifi5.c
6+
mixin_mixout_log.c
7+
)

src/audio/mixin_mixout/mixin_mixout.c

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -31,15 +31,13 @@
3131

3232
#include "mixin_mixout.h"
3333

34-
LOG_MODULE_REGISTER(mixin_mixout, CONFIG_SOF_LOG_LEVEL);
34+
LOG_MODULE_DECLARE(mixin_mixout, CONFIG_SOF_LOG_LEVEL);
3535

36-
/* mixin 39656eb2-3b71-4049-8d3f-f92cd5c43c09 */
37-
SOF_DEFINE_REG_UUID(mixin);
38-
DECLARE_TR_CTX(mixin_tr, SOF_UUID(mixin_uuid), LOG_LEVEL_INFO);
36+
extern const struct sof_uuid mixin_uuid;
37+
extern struct tr_ctx mixin_tr;
3938

40-
/* mixout 3c56505a-24d7-418f-bddc-c1f5a3ac2ae0 */
41-
SOF_DEFINE_REG_UUID(mixout);
42-
DECLARE_TR_CTX(mixout_tr, SOF_UUID(mixout_uuid), LOG_LEVEL_INFO);
39+
extern const struct sof_uuid mixout_uuid;
40+
extern struct tr_ctx mixout_tr;
4341

4442
#define MIXIN_MAX_SINKS IPC4_MIXIN_MODULE_MAX_OUTPUT_QUEUES
4543
#define MIXOUT_MAX_SOURCES IPC4_MIXOUT_MODULE_MAX_INPUT_QUEUES
Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
// SPDX-License-Identifier: BSD-3-Clause
2+
//
3+
// Copyright(c) 2024 Intel Corporation.
4+
5+
#include <rtos/symbol.h>
6+
#include <sof/lib/uuid.h>
7+
#include <sof/trace/trace.h>
8+
#include <user/trace.h>
9+
10+
LOG_MODULE_REGISTER(mixin_mixout, CONFIG_SOF_LOG_LEVEL);
11+
EXPORT_SYMBOL(log_const_mixin_mixout);
12+
13+
/* mixin 39656eb2-3b71-4049-8d3f-f92cd5c43c09 */
14+
SOF_DEFINE_REG_UUID(mixin);
15+
EXPORT_SYMBOL(mixin_uuid);
16+
17+
DECLARE_TR_CTX(mixin_tr, SOF_UUID(mixin_uuid), LOG_LEVEL_INFO);
18+
EXPORT_SYMBOL(mixin_tr);
19+
20+
/* mixout 3c56505a-24d7-418f-bddc-c1f5a3ac2ae0 */
21+
SOF_DEFINE_REG_UUID(mixout);
22+
EXPORT_SYMBOL(mixout_uuid);
23+
24+
DECLARE_TR_CTX(mixout_tr, SOF_UUID(mixout_uuid), LOG_LEVEL_INFO);
25+
EXPORT_SYMBOL(mixout_tr);

zephyr/CMakeLists.txt

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -549,6 +549,12 @@ elseif(CONFIG_COMP_IIR)
549549
)
550550
endif()
551551

552+
if(NOT CONFIG_COMP_IIR STREQUAL "n")
553+
zephyr_library_sources(
554+
${SOF_AUDIO_PATH}/eq_iir/eq_iir_log.c
555+
)
556+
endif()
557+
552558
zephyr_library_sources_ifdef(CONFIG_MATH_FIR
553559
${SOF_MATH_PATH}/fir_generic.c
554560
${SOF_MATH_PATH}/fir_hifi2ep.c
@@ -617,6 +623,12 @@ elseif(CONFIG_COMP_MIXIN_MIXOUT)
617623
)
618624
endif()
619625

626+
if(NOT CONFIG_COMP_MIXIN_MIXOUT STREQUAL "n")
627+
zephyr_library_sources(
628+
${SOF_AUDIO_PATH}/mixin_mixout/mixin_mixout_log.c
629+
)
630+
endif()
631+
620632
zephyr_library_sources_ifdef(CONFIG_COMP_TONE
621633
${SOF_AUDIO_PATH}/tone.c
622634
)

0 commit comments

Comments
 (0)