Remove updating the policy check run (#717)

We no longer need it with the new workflow check run combining the plan
and validate steps together.

Author: samrabelachew

server/legacy/events/vcs/github_client.go

@@ -18,7 +18,6 @@ import (
 	"encoding/base64"
 	"fmt"
 	"net/http"
-	"regexp"
 	"strconv"
 	"strings"
 	"time"
@@ -96,8 +95,6 @@ func (e ChecksConclusion) String() string {
 	return ""
 }
 
-var policyCheckRunRegex = regexp.MustCompile("atlantis/policy_check.*")
-
 // github checks status
 type CheckStatus int
 
@@ -507,9 +504,7 @@ func (g *GithubClient) UpdateStatus(ctx context.Context, request types.UpdateSta
 		return "", errors.Wrap(err, "unable to allocate legacy deprecation feature flag")
 	}
 	// if legacy deprecation is enabled, don't mutate check runs in legacy workflow
-	// exception: we always want to mutate atlantis/policy_check since new PR workflow has no knowledge of it
-	// eventually we will get rid of it entirely
-	if shouldAllocate && !policyCheckRunRegex.MatchString(request.StatusName) {
+	if shouldAllocate {
 		g.logger.InfoContext(ctx, "legacy deprecation feature flag enabled, not updating check runs")
 		return "", nil
 	}