Skip to content

Commit ea83ac1

Browse files
authored
feat(rspeedy/core)!: requires typescript 5.1.6 - 5.8.x (#480)
<!-- Thank you for submitting a pull request! We appreciate the time and effort you have invested in making these changes. Please ensure that you provide enough information to allow others to review your pull request. Upon submission, your pull request will be automatically assigned with reviewers. If you want to learn more about contributing to this project, please visit: https://github.com/lynx-family/lynx-stack/blob/main/CONTRIBUTING.md. --> ## Summary <!-- Can you explain the reasoning behind implementing this change? What problem or issue does this pull request resolve? --> Since we are now bundling `ts-blank-space` and externalizing `typescript` (#475), we need to manually specify the `peerDependencies`. The version requirement is copied from [`ts-blank-space/package.json`](https://github.com/bloomberg/ts-blank-space/blob/4102b1f26b1c53d38a1de74c10f262af5fd34fe8/package.json#L26). > [!NOTE] > The `typescript` is not required when: > > 1. Using JavaScript (`.js`) configuration > 1. Using Node.js v23.6+ > 1. Using Node.js v22.6+ with `--experimental-strip-types` or `--experimental-transform-types` <!-- It would be helpful if you could provide any relevant context, such as GitHub issues or related discussions. --> ## Checklist <!--- Check and mark with an "x" --> - [ ] Tests updated (or not required). - [ ] Documentation updated (or not required).
1 parent 50cff2a commit ea83ac1

File tree

3 files changed

+22
-0
lines changed

3 files changed

+22
-0
lines changed

.changeset/tired-lamps-attend.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
---
2+
"@lynx-js/rspeedy": minor
3+
---
4+
5+
**BREAKING CHANGE**: Added explicit TypeScript peer dependency requirement of 5.1.6 - 5.8.x.
6+
7+
This formalizes the existing TypeScript version requirement in `peerDependencies` (marked as optional since it is only needed for TypeScript configurations). The actual required TypeScript version has not changed.
8+
9+
Note: This may cause installation to fail if you have strict peer dependency checks enabled.
10+
11+
Node.js v22.7+ users can bypass TypeScript installation using `--experimental-transform-types` or `--experimental-strip-types` flags. Node.js v23.6+ users don't need any flags. See [Node.js - TypeScript](https://nodejs.org/api/typescript.html) for details.

packages/rspeedy/core/package.json

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,14 @@
8181
"vitest": "^3.1.1",
8282
"webpack": "^5.98.0"
8383
},
84+
"peerDependencies": {
85+
"typescript": "5.1.6 - 5.8.x"
86+
},
87+
"peerDependenciesMeta": {
88+
"typescript": {
89+
"optional": true
90+
}
91+
},
8492
"engines": {
8593
"node": ">=18"
8694
},

pnpm-lock.yaml

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)